494484 - Clicking on default preview twice results in overlay with no loaded image

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Aaron Train [:aaronmt]]

After clicking on a 

Testcase: https://preview.addons.mozilla.org/en-US/firefox/addon/1419#reviews

Steps to reproduce: 

1. Click the lovely FF 2.0 thumbnail on the left. It opens.
2. Click the lovely FF 2.0 thumbnail again. Something funky happens (throbber spins and tries (does it?) to load again but never actually finishes (throbber continues to spin)

Expected Results: The pop up image should close when clicking the thumbnail again.


Tested on: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.0.10) Gecko/2009042315 Firefox/3.0.10

and 

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090522 Shiretoko/3.5pre

Comment 1

[Aaron Train [:aaronmt]]

Attachment: Overlay of popup images for an addon

Comment 2

[Dave Garrett]

Only reproducible for the default preview in the upper left and when it does work correctly I get it behind the search box. (3.5pre on Linux) Other previews seem to work fine, though I can't click "prev" on the first extra preview to go to the default preview. The default preview doesn't seem to be counted with the rest which might be what's confusing things here. (or is just another bug)

Comment 3

[Dave Garrett]

Other bug you filed as bug 494482. I think these may be both the same broken thing.

Comment 4

[Stephen Donner [:stephend] Not actively reading bugmail]

Aaron, priorities are best set by development or the triage team -- feel free to set severity, though!

Comment 5

[Dave Garrett]

Attachment: screenshot - it's adding a second box that fails, not breaking it

Actually, turns out it does load behind the non-loading box. If you scroll down first before you do it, you can get a working one under the non-working one.

Comment 6

[Wil Clouser [:clouserw]]

Attachment: Fix broken lightbox

This is a short patch - the new slimbox was conflicting with the old lightbox.  We should deprecate lightbox once mozilla.thtml goes away.

Comment 7

[Les Orchard [:lorchard]]

Comment on attachment 379475 [details] [diff] [review]
Fix broken lightbox

Looks fine to me, seems to work.

Comment 8

[Wil Clouser [:clouserw]]

thanks r26317

Comment 9

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED on https://preview.addons.mozilla.org/en-US/firefox/addon/271.

Comment 10

[Dave Garrett]

Bug 494482 is also fixed now as well as the other issue I mentioned in comment 2.