494588 - Go button in the search form points to right in RTL mode

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[(no longer active)]

Attachment: Patch (v1)

Go button in the search form points to right in RTL mode, while it should point to left.

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Hey Ehsan -- mind switching all these reviews to Wil, or someone else on the dev team?  I'm QA, and not really qualified to review these patches (though I'd love it if I were!)  Thanks!

Comment 2

[(no longer active)]

Comment on attachment 379348 [details] [diff] [review]
Patch (v1)

(In reply to comment #1)
> Hey Ehsan -- mind switching all these reviews to Wil, or someone else on the
> dev team?  I'm QA, and not really qualified to review these patches (though I'd
> love it if I were!)  Thanks!

Sure, sorry for the confusion!

Comment 3

[Wil Clouser [:clouserw]]

Comment on attachment 379348 [details] [diff] [review]
Patch (v1)

Clearleft decided to make IE6 not load styles (!) so this will be broken for them.  I think that is a larger overall problem though so I don't have a problem with this.

Comment 4

[(no longer active)]

Committed in r26356.

Comment 5

[(no longer active)]

Verified in https://preview.addons.mozilla.org/fa/firefox/.