49487 - If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next"

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect, P5)

Description

[David Epstein]

Linux only. Mozilla build 2000-08-18-08-M18.
1. Download Linux installer stub and run the installer.
2. Click OK and Accept.
3. Click Next. (the default Directory location is unchanged. It's still 
/usr/local/Mozilla).
4. We get Mozilla msg "Directory /usr/local/Mozilla doesn't exist. Create it?"
5. Click the close checkbox.
6. From the install window, click Next.
Result: Nothing happens. Even if we change the directory location, it's hosed. 
Workaround is to press Cancel.
Expected: Same as if we pressed "No" (don't create it). the "dir doesn't exist" 
msg should reappear.

Comment 1

[Sean Su]

reassigning to Samir.

Comment 2

[Samir Gehani]

Over to Syd for installer bug triage

Comment 3

[Andrew Schultz]

Attachment: patch

this is actually a problem throughout the installer.  this patch uses the
OK/cancel handler for close dialog event in cases where the handler does
something more than destroying the dialog widget.

Comment 4

[Andrew Schultz]

Comment on attachment 144546 [details] [diff] [review]
patch

this isn't needed for the SetupType dialogs with bug 240929.  it's still needed
for the CRC dailog and the error dialog.

Comment 5

[Daniel Veditz [:dveditz]]

Comment on attachment 144546 [details] [diff] [review]
patch

r=dveditz

Comment 6

[Andrew Schultz]

Comment on attachment 144546 [details] [diff] [review]
patch

note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here
is relevant.

Comment 7

[Andrew Schultz]

Comment on attachment 144546 [details] [diff] [review]
patch

the Setup Type dialogs are modal and the CRC dialog is gone.

Unfortunately, the ErrorHandler fix doesn't work.  gtk (at least gtk1) steps on
the aData parameter and passes in a pointer to NULL.  As a result it thinks all
errors are fatal.

Comment 8

[Andrew Schultz]

Attachment: fix error dialog

this reworks the dialog so passing the aData parameter isn't necessary since
gtk does want to play nicely.

Comment 9

[Daniel Veditz [:dveditz]]

Comment on attachment 147374 [details] [diff] [review]
fix error dialog

r=dveditz

Comment 10

[David Epstein]

What happened to this patch? Looks like it needs to be superreviewed. 

Comment 11

[Andrew Schultz]

fixed