If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next"

RESOLVED FIXED in Future

Status

P5
normal
RESOLVED FIXED
18 years ago
14 years ago

People

(Reporter: depman1, Assigned: ajschult784)

Tracking

Trunk
Future
x86
Linux

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

1.72 KB, patch
dveditz
: review+
bryner
: superreview+
Details | Diff | Splinter Review
(Reporter)

Description

18 years ago
Linux only. Mozilla build 2000-08-18-08-M18.
1. Download Linux installer stub and run the installer.
2. Click OK and Accept.
3. Click Next. (the default Directory location is unchanged. It's still 
/usr/local/Mozilla).
4. We get Mozilla msg "Directory /usr/local/Mozilla doesn't exist. Create it?"
5. Click the close checkbox.
6. From the install window, click Next.
Result: Nothing happens. Even if we change the directory location, it's hosed. 
Workaround is to press Cancel.
Expected: Same as if we pressed "No" (don't create it). the "dir doesn't exist" 
msg should reappear.
(Reporter)

Updated

18 years ago
QA Contact: gemal → gbush
Summary: If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard gets hosed → If Linux inst msg "dir doesn't exist" is closed by checkbox, install wizard won't advance past "Next"

Comment 1

18 years ago
reassigning to Samir.
Assignee: ssu → sgehani

Updated

18 years ago
Status: NEW → ASSIGNED
Priority: P3 → P5

Comment 2

17 years ago
Over to Syd for installer bug triage
Assignee: sgehani → syd
Status: ASSIGNED → NEW

Updated

17 years ago
Target Milestone: --- → M1

Updated

17 years ago
Target Milestone: M1 → Future
(Assignee)

Comment 3

15 years ago
Created attachment 144546 [details] [diff] [review]
patch

this is actually a problem throughout the installer.  this patch uses the
OK/cancel handler for close dialog event in cases where the handler does
something more than destroying the dialog widget.
Assignee: slogan → ajschult
Status: NEW → ASSIGNED
(Assignee)

Updated

15 years ago
Attachment #144546 - Flags: review?(dveditz+bmo)
(Assignee)

Comment 4

15 years ago
Comment on attachment 144546 [details] [diff] [review]
patch

this isn't needed for the SetupType dialogs with bug 240929.  it's still needed
for the CRC dailog and the error dialog.
Comment on attachment 144546 [details] [diff] [review]
patch

r=dveditz
Attachment #144546 - Flags: review?(dveditz) → review+
(Assignee)

Comment 6

15 years ago
Comment on attachment 144546 [details] [diff] [review]
patch

note that with bug 240929 and bug 236294 fixed, only the ErrorHandler part here
is relevant.
Attachment #144546 - Flags: superreview?(bryner)
Attachment #144546 - Flags: superreview?(bryner) → superreview+
(Assignee)

Comment 7

15 years ago
Comment on attachment 144546 [details] [diff] [review]
patch

the Setup Type dialogs are modal and the CRC dialog is gone.

Unfortunately, the ErrorHandler fix doesn't work.  gtk (at least gtk1) steps on
the aData parameter and passes in a pointer to NULL.  As a result it thinks all
errors are fatal.
Attachment #144546 - Attachment is obsolete: true
(Assignee)

Comment 8

15 years ago
Created attachment 147374 [details] [diff] [review]
fix error dialog

this reworks the dialog so passing the aData parameter isn't necessary since
gtk does want to play nicely.
(Assignee)

Updated

15 years ago
Attachment #147374 - Flags: review?(dveditz)
Comment on attachment 147374 [details] [diff] [review]
fix error dialog

r=dveditz
Attachment #147374 - Flags: review?(dveditz) → review+
(Assignee)

Updated

15 years ago
Attachment #147374 - Flags: superreview?(bryner)
(Reporter)

Comment 10

15 years ago
What happened to this patch? Looks like it needs to be superreviewed. 
Attachment #147374 - Flags: superreview?(bryner) → superreview+
(Assignee)

Comment 11

14 years ago
fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.