495419 - Port tango smiley icons to XP theme

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Andreas Nilsson (:andreasn)]

Bug 490784 updated the icons for the message compose window, among them the smiley dropdown menu. The smileys inside the menu didn't get updated though.

Comment 1

[Joe Sabash [:JoeS1]]

What do you propose to use as new icons. I don't see a full set of 16 here:
http://tango.freedesktop.org/Tango_Icon_Library

I think we should be very careful in changing these as they have been in use for
many years now.
For some plaintext users, they are barely tolerated as they are, more colorful
versions may not be welcome.

There is also the matter of retaining the exact same metaphorical meaning.
Some seem pretty close, such as "smile" , "frown" , and "wink"
Others may not be perceived as straight equivalents.

People using different versions will see different icons of course.
Sending a "foot-in-mouth" and the recipient seeing a "monkey-face" ? :)
could be disastrous.

Comment 2

[rsx11m]

Will those be the same smilies that SeaMonkey introduced in bug 484484?
Those look different than the ones in the link Joe is referring to.

Comment 3

[Phil Ringnalda (:philor)]

No, it would be the same smilies that Thunderbird introduced in bug 484800 (the way the SM patch was a string of |copy from mail/themes/gnomestripe/mail/icons/smiley-cry.png| was a hint).

So yeah, if you send a :-! in Tb3 thinking that you're saying "I am a stereotypical mustachioed bandito in a spaghetti Western" someone in Tb2 will think that you meant "I had a chocolate ice cream cone and smeared it on my face."

I'm all for bikeshedding every image bug within an inch of its life, but the meaning of the "foot-in-mouth" graphical smilie is, as it always has been, "{blur}".

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: icons as patch

Comment 5

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 380803 [details] [diff] [review]
icons as patch

philor, can you take this one as well?

Comment 6

[Phil Ringnalda (:philor)]

http://build.mozillamessaging.com/mercurial/comm-central/rev/3d35f0adc86c