495943 - Attachment reminder should not search quoted text in replies (plain-text case)

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Nathan Weston]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b5pre) Gecko/20090519 Lightning/1.0pre Shredder/3.0b3pre

When send a reply to a message, the "Check for missing attachments" feature looks at your entire reply, including parts of the original message that you've quoted. Since the whole original message is quoted by default, you'll see the attachment reminder dialog if a keyword like "attachment" appears anywhere in the message -- even if you haven't actually typed such a keyword.

This could be avoid by ignoring text from the message you're replying to.



Reproducible: Always

Steps to Reproduce:
1. Receive a message containing the word "attachment"
2. Reply to it.
3. Send your reply.
4. The attachment reminder dialog pops up.
Actual Results:  
The reminder dialog always appears.

Expected Results:  
The reminder dialog should not appear unless the un-quoted portion of my reply contains a matching keyword.

Comment 1

[rsx11m]

Confirming per discussion in bug 492934 comment #3 since this is filed now.
Quotes are omitted from checking in HTML but not plain-text composition.
Some code from the spell checker may be helpful for guidance, it nicely
takes care of quote/non-quote also in plain-text messages.

Comment 3

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 4

[Phil Ringnalda (:philor)]

Fun fact: we actually have a pref that controls whether the quote is in a span or a pre (apparently we were nervous that bug 92331 would break something other than timeless hitting an assertion once in 2002).

Fun fact two: I've been led to believe that hasAttribute is way, way, way faster than getAttribute when you don't much care about the value. I really wish we had some sort of perf testing that would tell us how much it's costing us while sending something like a reply to a mailing list digest with a few thousand quote-spans to check that the value is the only value that we ever set on _moz_quote, just so that someone in the future could hypothetically be silly and set some other value.

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: small getAttribute vs hasAttribute test

Seems hasAttribute is about 20% faster

Comment 6

[Magnus Melin [:mkmelin]]

Attachment: proposed fix, v2

Use hasAttribute and look at the editor.quotesPreformatted too.

Comment 7

[Gervase Markham [:gerv]]

Yes, please! Currently, I've seen that dialog about 20 times, perhaps one time in three I send an email, and it's been wrong every single time. I suspect a large part of the problem is that it's scanning quoted text.

Gerv

Comment 8

[Phil Ringnalda (:philor)]

Comment on attachment 382746 [details] [diff] [review]
proposed fix, v2

Pretty!

Comment 9

[Magnus Melin [:mkmelin]]

changeset:   2962:bb94ed177f1f
http://hg.mozilla.org/comm-central/rev/bb94ed177f1f

->FIXED