496543 - Marks folders as read only marks first folder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Brian]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9.0.10) Gecko/2009042316 Firefox/3.0.10
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1pre) Gecko/20090604 Lightning/1.0pre Shredder/3.0b3pre

In the tree view selecting two or more folders to mark as read only marks the first folder.

Reproducible: Always

Steps to Reproduce:
1. Select 2 or more folders with unread mail in tree view ( I didn't use inbox subfolders)
2. Right click, select mark folders as read

Actual Results:  
First folder is marked correctly, other folders are unchanged

Expected Results:  
All selected folders should be marked as read

As an aside it would be nice to have a delete folders in this context too.

Comment 1

[Ludovic Hirlimann [:Usul]]

confirming with Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.1pre) Gecko/20090604 Shredder/3.0b3pre.

Brian is this a regression , did it used to work in older versions ?

Comment 2

[Brian]

> Brian is this a regression , did it used to work in older versions ?

I only noticed this feature yesterday, it didn't work then & it doesn't on the latest nightly. FYI I use IMAP.

Comment 3

[David :Bienvenu]

the regression is that we allow multiple folder selection in the folder pane. We didn't used to, and the backend doesn't support applying commands to multiple selected folders.

Comment 4

[Magnus Melin [:mkmelin]]

Apparently i didn't missed this in bug 296655.

The patch i have fixes the obvious issue, but there's some occacional funkiness if the remote count isn't up to date... bug 243029, also the problems in bug 240209 for news...

Comment 5

[Magnus Melin [:mkmelin]]

Attachment: proposed fix

Comment 6

[David :Bienvenu]

Comment on attachment 382564 [details] [diff] [review]
proposed fix

how about let folders...?

This has the potential to lock up the ui if the user selects a bunch of large folders and does this, but that should be pretty rare.

Comment 7

[Magnus Melin [:mkmelin]]

changeset:   2878:ddb48960e0ac
http://hg.mozilla.org/comm-central/rev/ddb48960e0ac

->FIXED