496626 - Space doesn't go to next unread in second tab

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Phil Ringnalda (:philor)]

STR:
1. Select a folder in one account in the folderpane (Inbox on Local Folders, for me)
2. Right-click another folder (Inbox of an IMAP account, for me), which has unread messages, and open in a tab
3. In the new tab, click on a read message in the folderpane, to ensure focus is there
4. Press the spacebar

Rather than moving to the next unread message, nothing happens other than the console showing "contentWindow is null" from |var rssiframe = contentWindow.document.getElementById('_mailrssiframe');| in mailWindowOverlay.js::SpaceHit()

Bonus fun:
1. In the first tab, try to select the same folder that's selected in the second tab.
2. When you notice that the threadpane didn't change, select another folder in that account, then reselect the folder you wanted.
3. Now, go back to that same folder in the second tab, and scrolling via space will work, but expanding collapsed threads won't.

Comment 1

[Mark Banner (:standard8)]

Ok, according to my tests this will also have broken viewing RSS messages (and possibly a few other things when tabs are opened for the first time (switching to and from should clear the error I believe, I hope Phil was seeing something else in his bonus fun step 3, because that WFM with the patch and I don't see how it would be broken without).

Patch coming up.

Comment 2

[Mark Banner (:standard8)]

Attachment: The fix

Comment 3

[Mark Banner (:standard8)]

Opps, I meant to add some commentary. I forgot when I wrote the original patch on bug 495818 that when we first open a new tab we only get openTab called on the tab type definition. Hence my original patch just set content-primary correctly whilst we were switching from tab to tab. New tabs were stuck with content-targetable (thanks to the sharing of the messagepane element).

The content tab wasn't affected because that builds its elements in openTab and hence sets content-primary there.

Comment 4

[Mark Banner (:standard8)]

Oh, and according to devmo, _content is obsolete, and content should be used instead.

Comment 5

[Phil Ringnalda (:philor)]

Comment on attachment 381861 [details] [diff] [review]
The fix

Yep, r=me, and an invalid but use it anyway r=me for fixing the parallel two uses of _content in suite/

One of these years, we really should fix all the uses in viewsource and stop mapping it to .content for chrome - it's been something like 5 years since most of them were purged from the tree.

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/955154475be4