Closed Bug 496647 Opened 12 years ago Closed 12 years ago

Set content tab titles from the actual content not pre-stored values.

Categories

(Thunderbird :: Toolbars and Tabs, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b3

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch The fix (obsolete) — Splinter Review
When we're loading pages into content tabs, I think we should be using the page title of the content we're loading, rather than a pre-defined title.

This means extensions should be able to do page loading more easily, and means we don't have to worry about what pages we load where and getting separate localised names for the tabs.

This does affect the what's new and the about:rights tabs.

Currently the What's New tab has title "What's New", this would be changed to "Welcome to Shredder!" with what is currently on the website.

Also, about:rights which is currently titled "About Your Rights" would become "about:rights".

Both of these we can change if we want to, but I'm leaving them as they are for now.

I think the attached patch should work, I just want to do a little more checking before review.
Flags: wanted-thunderbird3+
Attached patch The fix v2Splinter Review
This version has minor improvements (added comments, better structure).

Requesting ui-review to get Bryan's opinions on the tab titles in comment 0. If we want to change either of the titles I'll do them in follow up patches/bugs (the Welcome to Shredder one is website anyway).
Attachment #381865 - Attachment is obsolete: true
Attachment #381974 - Flags: ui-review?(clarkbw)
Attachment #381974 - Flags: review?(philringnalda)
Comment on attachment 381974 [details] [diff] [review]
The fix v2

Nice!

We should carry over the "About Your Rights" title in a followup.
Attachment #381974 - Flags: ui-review?(clarkbw) → ui-review+
Comment on attachment 381974 [details] [diff] [review]
The fix v2

Looks good.

>+++ b/mail/base/content/specialTabs.js
>+    closeTab: function onTabClosed(aTab) { 

Trailing whitespace.

>     onTitleChanged: function onTitleChanged(aTab) {
>-    },
>+      aTab.title = aTab.panel.firstChild.contentDocument.title;
>+   },
>     supportsCommand: function supportsCommand(aTab, aCommand) {

One space shy of lining up.
Attachment #381974 - Flags: review?(philringnalda) → review+
Blocks: 497066
Checked in: http://hg.mozilla.org/comm-central/rev/61d5f8fd0fe2

Raised bug 497066 on the title issue.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.