497066 - Give about:rights a proper page title

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

Spun off from bug 496647 comment 2.

After the change in that bug, the about:rights page shows "about:rights" in the tab bar as the page title. It would be more descriptive that this is "About Your Rights".

This patch changes the title and re-uses the first title header with the page title. I can't see l10n teams having an issue with that.

Comment 1

[Phil Ringnalda (:philor)]

I like to phrase that as "I can't see how l10n teams will have an issue with that" - that way you have an out, you can claim you meant that you knew the inevitable would happen and someone would, you just didn't know what the issue would be :)

Comment 2

[Magnus Melin [:mkmelin]]

Actually, why not keep the title as about:rights?

That gives people a chance to know how to find it again, and let's face it, the small minority that will bother to look at the page are exactly the kind of people that like geeky things like that.

Firefox also shows about:rights as title

Comment 3

[Ludovic Hirlimann [:Usul]]

(In reply to comment #2)
> Actually, why not keep the title as about:rights?
> 

I like that idea.

Comment 4

[Axel Hecht [:Pike]]

Comment on attachment 382266 [details] [diff] [review]
The fix

I suggest to not share the string value between tab title and header element, people might want to use a shorter string for the tab title, and use a full-quality translated lengthy string in the h1 element.

Comment 5

[Mark Banner (:standard8)]

(In reply to comment #2)
> Actually, why not keep the title as about:rights?

This was Bryan's call.

> That gives people a chance to know how to find it again, and let's face it, the
> small minority that will bother to look at the page are exactly the kind of
> people that like geeky things like that.

I think fixing bug 481685 would fix this in a much better way, and for about:rights that is the correct way to fix it.

Comment 6

[Mark Banner (:standard8)]

(In reply to comment #5)
> I think fixing bug 481685 would fix this in a much better way, and for
> about:rights that is the correct way to fix it.

May that bug 480533.

Comment 7

[Mark Banner (:standard8)]

Attachment: The fix v2

Revised patch to keep the two titles separate.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

With bug 480533 people should be able to "easily" get back to this page.  I do like the separate titles for better translation.

Comment 9

[Phil Ringnalda (:philor)]

Comment on attachment 382352 [details] [diff] [review]
The fix v2

Looks like the objections have settled down, this must be right :)

Comment 10

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/3bfd54bf08cb