496976 - Add-on Manager in Admin panel should find add-ons regardless of locale

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect, P3)

Description

[Rey Bango]

I was searching for an add-on via the Add-on Manager in the Admin panel and couldn't find it, even though it had a public profile page. 

The add-on in question is Tuentifox:

https://addons.mozilla.org/en-US/firefox/addon/10496/
https://addons.mozilla.org/en-US/developers/addon/edit/10496

I asked Fligtar and he thinks it may have to do with the add-on not having a "en-us" translation. In looking at the add-on code, it only has one locale which is "en-ES". In terms of an admin search by name, this shouldn't be the standard functionality. If the search is limited to only add-ons which include a "en-us" translation, we need to modify the code to allow an add-on search regardless of locale. Searching by add-on ID works.

To duplicate:

1) Go to Admin Tools->Add-on Manager
2) Enter "TuentiFox"

Notice no results appear in the autocomplete input field.

Comment 1

[Nick Nguyen [:osunick]]

DD-
is this something you can do in 5.0.9?

Comment 2

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Nick,

No this isn't.  Justin Scott explained this to me in detail:

I think what's wanted is:

* Surfacing addons that you search for in your default language, falling back on the addons' default language.

I think what reasonably can be delivered (prolly in 5.1) is:

* Surfacing addons you search for with a boost given to your language, and then to the language of the addon - but it would still surface everything.

Comment 3

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

The solution to this may fix this: bug 518618.

Comment 4

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

Attachment: v1

The solution to this will also fix this: bug 518618.

We're also solving the issue of addons w/o files showing up (duly noted that stub listings need to be handled separately - I'll have to see how that's implimented).

* We're indexing the file count - which doesn't slow things down too much.
* Disabling the query log for the admin ajax search
* the ajax search now uses sphinx instead of SQL
* We now boost your own language and public addons, rather than strictly filtering for your language + en-US, per jorge's suggestion

enjoy

Comment 5

[Dave Dash [:davedash, :dd] (assign all bugs to mbrandt)]

------------------------------------------------------------------------
r53999 | [e-mail] | 2009-10-22 11:20:08 -0700 (Thu, 22 Oct 2009) | 2 lin

[bug 496976] Boosting locale

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED: https://preview.addons.mozilla.org/en-US/admin/addons?q=TuentiFox+[10496]