497743 - Audit site for more collections-related memory problems

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Collections, defect, P1)

Description

[Justin Scott [:fligtar]]

We should audit the site for queries that pull collections data without need to avoid more bugs like bug 497706.

Jeff says anything using getListAddons() is succeptible.

Comment 1

[Justin Scott [:fligtar]]

Jeff mentioned that the category landing pages are prone to this. They are starting to load a bit slowly for me.

The irony of this bug is that we don't yet have a page to list all of the collections associated with an add-on (bug 491407), but random other pages are pulling that data. :)

Comment 2

[Stephen Donner [:stephend] Not actively reading bugmail]

Currently visible on https://addons.mozilla.org/en-US/firefox/browse/type:1/cat:5; AMO serves a page with 0-byte content-length.

Comment 3

[Justin Scott [:fligtar]]

Jeff is taking the category page emergency. We'll probably have to apply the patch locally since we've had so many changes since last svn up.

Comment 4

[Jeff Balogh (:jbalogh)]

Attachment: quick patch to use getAddonList

may lose some sorting functionality in the switch; oh well

Comment 5

[Wil Clouser [:clouserw]]

Comment on attachment 384184 [details] [diff] [review]
quick patch to use getAddonList

I dropped around 15 add-ons on this page in over 1000 collections each and this patch still let the pages render with a 32M memory_limit.

Comment 6

[Jeff Balogh (:jbalogh)]

Attachment: replacing more getAddonList

Including the search controller this time.

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 384188 [details] [diff] [review]
replacing more getAddonList

I put all 10 add-ons on a search result page into between 1000 and 3000 collections each and with this patch it still worked.

Comment 8

[Wil Clouser [:clouserw]]

This patch is currently on the live site

Comment 9

[Jeff Balogh (:jbalogh)]

Attachment: fully replacing and removing getListAddons

New paths affected:
http://jbalogh.khan.mozilla.org/amo/site/en-US/firefox/browse/type:3
http://jbalogh.khan.mozilla.org/amo/site/en-US/firefox/browse/type:2/
http://jbalogh.khan.mozilla.org/amo/site/en-US/firefox/browse/type:4

Comment 10

[Stephen Donner [:stephend] Not actively reading bugmail]

(In reply to comment #8)
> This patch is currently on the live site

I can confirm that this (at least temporarily) fixes the blank pages I was seeing; ran my Selenium script and clicked around for a while.

Comment 11

[Jeff Balogh (:jbalogh)]

Committed in r28244; most of it is already in production.