498155 - open folder in new tab is labeled <blank> (when load tabs in foreground is set)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Wayne Mery (:wsmwk)]

perhaps related to standard8's bug 498145, open folder in new tab results in account central and tab is labeled "undefined". none are gmail. nothing in error console

STR
1. click on a folder
2. r-click anotther folder and open in tabs.
3. repeat if necessary
 
results:
 right pane is account central and tab is labeled "undefined

4. click any folder while in the undefined tab

results:
 tab label changes to inbox of that account, as does the thread pane contents
 (can't seem to reproduce this last step at the moment)
 
Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1pre) Gecko/20090613 Shredder/3.0b3pre

Comment 1

[klonos]

Any news on this one?

Importance for this one is set to 'normal' that is described as 'regular issue, some loss of functionality under specific circumstances'. I am setting this to 'Major' -> 'major loss of function' for three reasons:

- it is one of the most-advertised features of thunderbird 3.
- the loss of functionality is *always* and not under specific circumstances.
- [personal] I myself use this feature A LOT and want this to get some attention.

If someone feels different you are welcomed to change it back to 'normal'.

Comment 2

[Wayne Mery (:wsmwk)]

after Friday's checkin of bug 474701, I don't see "undefined".

But still see account central instead of the expected thread pane. Isn't there a bug filed on that?

Comment 3

[rsx11m]

Using today's Win32 nightly, if I select "Open in new tab" for the folder I'm currently looking at, the thread pane appears as desired. If I have one folder open and right-click on another one to open it in a tab though, account central appears and the window heading reads "- Shredder" only.

There is bug 498145 on account central showing up in every case, was fixed, maybe this is either a regression of that fix or a case not being covered.

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

This is/will be serendipitously fixed by bug 467768.

Comment 5

[Magnus Melin [:mkmelin]]

Only partly though. If you set mail.contextMenuBackgroundTabs false the tab title is now blank instead.

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

I'm somewhat inclined to say that this can wait until b4.  Thoughts?

Comment 7

[Magnus Melin [:mkmelin]]

While not default, load in bg is probably a pref many people change (I know it's the first i do in ff), and it makes this an always-in-your-face kind of bug.

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

If it's not exposed in the preferences dialog I don't think it should block beta 3.  Having said that, I think we should be exposing the option in the preferences dialog like Firefox and it should be a first-class feature with unit tests and such.

Resetting assignment as I had just done that with the assumption bug 467768 would fix this conclusively.

Comment 9

[Rain [:rain1] (inactive)]

(In reply to comment #8)
> If it's not exposed in the preferences dialog I don't think it should block
> beta 3.  Having said that, I think we should be exposing the option in the
> preferences dialog like Firefox and it should be a first-class feature with
> unit tests and such.
> 

While we currently do have unit tests for middle click to open messages in the foreground (and adding tests for folder tabs is somewhere on my list), clarkbw would know if/where we would want to have such a pref in the dialog. Bryan?

Comment 10

[Rain [:rain1] (inactive)]

Oh, and I'll take this bug anyway. ;)

Comment 11

[Rain [:rain1] (inactive)]

Attachment: patch without tests

The code hadn't been updated for the newfangled transient selection stuff, so we were performing updates on the transient selection, which of course weren't carried over to the real one.

Comment 12

[Rain [:rain1] (inactive)]

Attachment: patch with tests

I've implemented most but not all of the stuff from test-right-click-middle-click.js (now test-right-click-middle-click-messages.js).

There's a small change to the folder pane too, so asking bienvenu for review there.

Comment 13

[David :Bienvenu]

Comment on attachment 386558 [details] [diff] [review]
patch with tests

sr=me for the folderPane.js change.

Comment 14

[Rain [:rain1] (inactive)]

Comment on attachment 386558 [details] [diff] [review]
patch with tests

>+ * - A list containing two integers, indicating a range of view indices.
>+ * - An nsIMsgFolder.
>+ * - A list of nsIMsgFolders.
>+ *
>+ * In each case, since we can only have one folder 
>+ */
>+function assert_folder_displayed() {

That comment should read "In each case, since we can only have one folder displayed, we only look at the first folder you pass in."

Comment 15

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 386558 [details] [diff] [review]
patch with tests

Hooray for unit tests!


on file: mail/test/mozmill/folder-display/test-right-click-middle-click-folders.js line 44
> var MODULE_NAME = 'test-deletion-with-multiple-displays';

Please update the name.  It appears that test-right-click-middle-click.js may
be trying to start a trend of being mis-named, but no matter how cool it is,
we must never give in to peer pressure.

If you could fix the other file in this regard too, I wouldn't complain...

Comment 16

[Rain [:rain1] (inactive)]

Pushed to c-c: http://hg.mozilla.org/comm-central/rev/e33a0b494e4d

sorry about the rename turning into an add/delete -- guess the hg bug still isn't fixed in 1.3. I'll look into it.