498343 - Account Central gives unread and total counts in status bar (shows -1 for accounts)

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Mark Banner (:standard8)]

Viewing account central used to not display any unread/total counts in the bottom-right of the main mail window. Now these are displayed with values of "-1".

Comment 1

[Mark Banner (:standard8)]

This will probably be fixed by bug 498106 and/or bug 498342

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

Regrettably, neither of those fixed it.

Comment 3

[Mark Banner (:standard8)]

Attachment: Possible fix

What is happening is the folder pane display is now making extra calls to UpdateStatusMessageCounts where I guess that was called with null before for servers (or not at all).

This patch fixes it, but not sure if this is the right check we want to do here and we may want to redo how the status counts work anyway to hook them closer to the new code. Additionally, they aren't non-mail-tab-type aware and hence don't get hidden (but we can always move that bit out to a different bug).

Comment 5

[Thomas D. (:thomas8)]

modified summary for improved retrievability (I couldn't find it when I posted the dupe)

Comment 7

[Mark Banner (:standard8)]

Attachment: The fix

Improved fix: This disables the display of unread counts on the account summary pane, as well as for non-folder tabs (e.g. message, content tabs). I've also got rid of the two nasty get functions that didn't really need to try and cache global variables for the elements.

Comment 8

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/eff3d4e64872