fennec l10n nightly repacks -- win32/osx desktop

RESOLVED FIXED

Status

defect
P2
normal
RESOLVED FIXED
10 years ago
6 years ago

People

(Reporter: aki, Assigned: coop)

Tracking

Dependency tree / graph

Firefox Tracking Flags

(status1.9.2 beta2-fixed)

Details

(Whiteboard: [fennec l10n])

Attachments

(11 attachments, 4 obsolete attachments)

1.36 KB, patch
coop
: review+
Details | Diff | Splinter Review
2.02 KB, patch
ted
: review+
Details | Diff | Splinter Review
16.04 KB, patch
aki
: review+
Details | Diff | Splinter Review
1.38 KB, patch
armenzg
: review+
armenzg
: checked-in+
Details | Diff | Splinter Review
1.98 KB, patch
coop
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
2.25 KB, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
1.50 KB, patch
nthomas
: review+
nthomas
: checked-in+
Details | Diff | Splinter Review
1.10 KB, patch
coop
: review+
Details | Diff | Splinter Review
808 bytes, patch
mfinkle
: review+
Details | Diff | Splinter Review
4.71 KB, patch
Details | Diff | Splinter Review
2.84 KB, patch
kairo
: review+
sgautherie
: checked-in+
Details | Diff | Splinter Review
These will just be tarballs/zips.
Thanks Coop!
Assignee: aki → ccooper
Status: NEW → ASSIGNED
Priority: -- → P2
Status: ASSIGNED → NEW
Priority: P2 → P3
Coop -- I'm going to be taking a look at the osx/win32 desktop repacks since you're out today and I took so long getting the en-US versions building.
Whiteboard: [fennec l10n]
I'll be attaching my patches shortly.
On Win32, the slave died mid-nightly so I haven't see it try to repack yet.
On OSX, during the make ident in mobile/locales, I hit this:

make ident
 in dir /builds/slave/macosx-fennec-trunk-l10n-nightly/l10n/mozilla-central/mobile/locales (timeout 1200 secs)
 watching logfiles {}
 argv: ['make', 'ident']
 environment:
  Apple_PubSub_Socket_Render=/tmp/launch-NqMuWu/Render
  CVS_RSH=ssh
  DISPLAY=/tmp/launch-b6SYLH/:0
  HOME=/Users/cltbld
  LOGNAME=cltbld
  PATH=/tools/buildbot/bin:/tools/python/bin:/opt/local/bin:/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/X11/bin
  PWD=/builds/slave/macosx-fennec-trunk-l10n-nightly/l10n/mozilla-central/mobile/locales
  PYTHONHOME=/tools/python
  PYTHONPATH=/tools/buildbot/lib/python2.5/site-packages:/tools/twisted/lib/python2.5/site-packages/:/tools/twisted-core/lib/python2.5/site-packages:/tools/zope-interface/lib/python2.5/site-packages
  SHELL=/bin/bash
  SSH_AUTH_SOCK=/tmp/launch-IE2Hp1/Listeners
  TMPDIR=/var/folders/TL/TLg3RrMbFAur2hBCXvCeqk+++TM/-Tmp-/
  USER=cltbld
 closing stdin
 using PTY: True
-n gecko_revision 
Section [Build] not found.
make: *** [ident] Error 1
program finished with exit code 2
elapsedTime=0.271784


I'll totally punt on OSX to get Win32 running if that's the fastest path, though.
As far as the win32 side, it seems to be looking for the exe instead of the zip file.

(view as text)

make wget-en-US
 in dir e:\builds\slave\w32mob-trunk-l10n-nightly\./mozilla-central/mobile/locales (timeout 1200 secs)
 watching logfiles {}
 argv: ['make', 'wget-en-US']
 environment:
  !::=::\
  !EXITCODE=00000001
  ALLUSERSPROFILE=C:\Documents and Settings\All Users
  APPDATA=C:\Documents and Settings\cltbld\Application Data
  APR_ICONV_PATH=d:/mozilla-build/svn-win32-1.6.3/iconv
  BOOTMODE=BKSTD
  CLUSTERLOG=C:\WINDOWS\Cluster\cluster.log
  COLORFGBG=0;default;15
  COLORTERM=rxvt-xpm
  COMMONPROGRAMFILES=C:\Program Files\Common Files
  COMPUTERNAME=WIN32-SLAVE03
  COMSPEC=C:\WINDOWS\system32\cmd.exe
  CVS_RSH=ssh
  DEVENVDIR=D:\msvs8\Common7\IDE
  DISPLAY=:0
  EDITOR=emacs.exe --no-window-system
  EN_US_BINARY_URL=http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-trunk
  FP_NO_HOST_CHECK=NO
  FRAMEWORKDIR=C:\WINDOWS\Microsoft.NET\Framework
  FRAMEWORKSDKDIR=D:\msvs8\SDK\v2.0
  FRAMEWORKVERSION=v2.0.50727
  HOME=c:/Documents and Settings/cltbld
  HOMEDRIVE=C:
  HOMEPATH=\
  HOSTTYPE=i686
  INCLUDE=C:\Program Files\Microsoft SDKs\Windows\v6.0A\\include;C:\Program Files\Microsoft SDKs\Windows\v6.0A\\include\atl;D:\msvs8\VC\ATLMFC\INCLUDE;D:\msvs8\VC\INCLUDE;D:\msvs8\VC\PlatformSDK\include;
  INPUTRC=D:/mozilla-build/msys/etc/inputrc
  LIB=C:\Program Files\Microsoft SDKs\Windows\v6.0A\\lib;D:\msvs8\VC\ATLMFC\LIB;D:\msvs8\VC\LIB;D:\msvs8\VC\PlatformSDK\lib;D:\msvs8\SDK\v2.0\lib;;D:\mozilla-build\\atlthunk_compat
  LIBPATH=C:\WINDOWS\Microsoft.NET\Framework\v2.0.50727;D:\msvs8\VC\ATLMFC\LIB
  LOGNAME=cltbld
  LOGONSERVER=\\WIN32-SLAVE03
  MACHTYPE=i686-pc-msys
  MAKE_MODE=unix
  MOZILLABUILD=D:\mozilla-build\
  MOZILLABUILDDRIVE=D:
  MOZILLABUILDPATH=\mozilla-build\
  MOZ_MSVCVERSION=8
  MOZ_NO_RESET_PATH=1
  MOZ_TOOLS=D:\mozilla-build\\moztools
  MSVC6KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\6.0\Setup\Microsoft Visual C++
  MSVC71KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\7.1\Setup\VC
  MSVC8EXPRESSKEY=HKLM\SOFTWARE\Microsoft\VCExpress\8.0\Setup\VC
  MSVC8KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\8.0\Setup\VC
  MSVC9EXPRESSKEY=HKLM\SOFTWARE\Microsoft\VCExpress\9.0\Setup\VC
  MSVC9KEY=HKLM\SOFTWARE\Microsoft\VisualStudio\9.0\Setup\VC
  MSVCEXPROOTKEY=HKLM\SOFTWARE\Microsoft\VCExpress
  MSVCROOTKEY=HKLM\SOFTWARE\Microsoft\VisualStudio
  MSYSTEM=MINGW32
  NUMBER_OF_PROCESSORS=1
  NVAPSDK=D:\sdks\tegra042\
  OLDPWD=d:/mozilla-build
  OS=Windows_NT
  OSTYPE=msys
  PATH=D:\mozilla-build\msys\local\bin;d:\mozilla-build\wget;d:\mozilla-build\7zip;d:\mozilla-build\blat261\full;d:\mozilla-build\python25;d:\mozilla-build\svn-win32-1.6.3\bin;d:\mozilla-build\upx203w;d:\mozilla-build\emacs-22.3\bin;d:\mozilla-build\info-zip;d:\mozilla-build\nsis-2.22;d:\mozilla-build\nsis-2.33u;d:\mozilla-build\hg;d:\mozilla-build\python25\Scripts;d:\mozilla-build\kdiff3;d:\mozilla-build\vim\vim72;.;D:\mozilla-build\msys\local\bin;D:\mozilla-build\msys\mingw\bin;D:\mozilla-build\msys\bin;c:\Program Files\Microsoft SDKs\Windows\v6.0A\bin;d:\msvs8\Common7\IDE;d:\msvs8\VC\BIN;d:\msvs8\Common7\Tools;d:\msvs8\Common7\Tools\bin;d:\msvs8\VC\PlatformSDK\bin;d:\msvs8\SDK\v2.0\bin;c:\WINDOWS\Microsoft.NET\Framework\v2.0.50727;d:\msvs8\VC\VCPackages;c:\WINDOWS\system32;c:\WINDOWS;c:\WINDOWS\System32\Wbem;d:\mozilla-build\python25;d:\mercurial;c:\Program Files\Microsoft SQL Server\90\Tools\binn\;d:\sdks\tegra042\tools;d:\sdks\tegra042\platformlibs\bin\winxp\x86\release;d:\sdks\tegra042\3rdparty\bin\winxp\x86\release;d:\mozilla-build\moztools\bin
  PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH
  PROCESSOR_ARCHITECTURE=x86
  PROCESSOR_IDENTIFIER=x86 Family 6 Model 23 Stepping 8, GenuineIntel
  PROCESSOR_LEVEL=6
  PROCESSOR_REVISION=1708
  PROGRAMFILES=C:\Program Files
  PROMPT=$P$G
  PS1=\[\033]0;$MSYSTEM:\w\007
\033[32m\]\u@\h \[\033[33m\w\033[0m\]
$ 
  PWD=c:/Documents and Settings/cltbld
  SDK2003SP1KEY=HKLM\SOFTWARE\Microsoft\MicrosoftSDK\InstalledSDKs\8F9E5EF3-A9A5-491B-A889-C58EFFECE8B3
  SDK2003SP2KEY=HKLM\SOFTWARE\Microsoft\MicrosoftSDK\InstalledSDKs\D2FF9F89-8AA2-4373-8A31-C838BF4DBBE1
  SDK61KEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v6.1
  SDK6AKEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v6.0A
  SDK6KEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v6.0
  SDK7KEY=HKLM\SOFTWARE\Microsoft\Microsoft SDKs\Windows\v7.0
  SDKDIR=C:\Program Files\Microsoft SDKs\Windows\v6.0A\
  SDKMINORVER=0A
  SDKROOTKEY=HKLM\SOFTWARE\Microsoft\MicrosoftSDK\InstalledSDKs
  SDKVER=6
  SESSIONNAME=Console
  SHELL=D:/mozilla-build/msys/bin/sh
  SHLVL=1
  SSH_AGENT_PID=2468
  SSH_AUTH_SOCK=C:/DOCUME~1/cltbld/LOCALS~1/Temp/ssh-frtdOD2416/agent.2416
  SYSTEMDRIVE=C:
  SYSTEMROOT=C:\WINDOWS
  TEMP=C:/DOCUME~1/cltbld/LOCALS~1/Temp
  TEMPVC9DIR=d:\msvs9\VC\
  TERM=msys
  TMP=C:/DOCUME~1/cltbld/LOCALS~1/Temp
  USERDOMAIN=WIN32-SLAVE03
  USERNAME=cltbld
  USERPROFILE=C:\Documents and Settings\cltbld
  USESDK=1
  VC8DIR=D:\msvs8\VC\
  VC8EXPRESSDIR=C:\Program Files\Microsoft SDKs\Windows\v6.0A\VC\
  VC9DIR=d:\msvs9\VC\
  VCINSTALLDIR=D:\msvs8\VC
  VS80COMNTOOLS=D:\msvs8\Common7\Tools\
  VS90COMNTOOLS=d:\msvs9\Common7\Tools\
  VSINSTALLDIR=D:\msvs8
  WIN64=0
  WINCURVERKEY=HKLM\SOFTWARE\Microsoft\Windows\CurrentVersion
  WINDIR=C:\WINDOWS
  WINDOWID=167839024
  _=d:/mozilla-build/python25/scripts/buildbot
 closing stdin
 using PTY: False
(cd /e/builds/slave/w32mob-trunk-l10n-nightly/mozilla-central/dist && wget -nv -N  http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-trunk/fennec-1.0b4pre.en-US.win32.zip)
Downloaded http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-trunk/fennec-1.0b4pre.en-US.win32.zip to /e/builds/slave/w32mob-trunk-l10n-nightly/mozilla-central/dist/fennec-1.0b4pre.en-US.win32.zip
e:/builds/slave/w32mob-trunk-l10n-nightly/mozilla-central/config/nsinstall -D /e/builds/slave/w32mob-trunk-l10n-nightly/mozilla-central/dist/install/sea/
(cd /e/builds/slave/w32mob-trunk-l10n-nightly/mozilla-central/dist/install/sea/ && wget -nv -N "http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-trunk/fennec-1.0b4pre.en-US.win32.installer.exe")
http://staging-stage.build.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-trunk/fennec-1.0b4pre.en-US.win32.installer.exe:
00:50:55 ERROR 404: Not Found.
make: *** [wget-en-US] Error 1
program finished with exit code 2
elapsedTime=0.297000
If someone wants to take the baton, or give me pointers.
Definitely not ready yet though.  Part 1 of 2.
I imagine I need to study the ffx desktop win32/osx repack factories a bit more.
It's looking for both zip and exe depending on platform.

This might be something we need to unfactor back into fx, or just wallpaper. Not that we couldn't end up with an exe at some point for fennec on windows mobile, too.
Assignee: ccooper → armenzg
Priority: P3 → P2
Looking into this
(In reply to comment #3)
> I'll be attaching my patches shortly.
> On Win32, the slave died mid-nightly so I haven't see it try to repack yet.
> On OSX, during the make ident in mobile/locales, I hit this:
> 
> make ident
>  in dir
> /builds/slave/macosx-fennec-trunk-l10n-nightly/l10n/mozilla-central/mobile/locales
> -n gecko_revision 
> Section [Build] not found.
> make: *** [ident] Error 1
> program finished with exit code 2
> elapsedTime=0.271784
> 
>
The code failing is this http://mxr.mozilla.org/mobile-browser/source/locales/Makefile.in#129 
It is trying to get information from platform.ini from an incorrect place.

NOTE: $(STAGEDIST)=../../dist/l10n-stage/fennec/Fennec.app/Contents/MacOS

It is trying to get it from here:
$(STAGEDIST)/xulrunner/platform.ini
when it really is in here:
$(STAGEDIST)/../Frameworks/XUL.framework/Versions/1.9.2a2pre/platform.ini

I looked at how comm-central do this by looking in here:
http://mxr.mozilla.org/comm-central/source/mail/locales/Makefile.in#316
and they pretty much expect it in here:
$(STAGEDIST)/platform.ini
which is pretty much platform and branch independent.

Please any tips on how to fix this.
Status: NEW → ASSIGNED
comm-central has nothing to do with xulrunner builds, which is what you're tripping over here.

No idea if there's any existing variable that knows where to find the xulrunner bin in the mac package, Ted?
I don't like having to add a special case for Mac but I guess this might be the way; correct me if I am wrong.

nthomas mentioned to me on IRC that Thunderbird does not build as XULRunner + XULApp as Fennec. Is this why I can't expect things to be as easy as in the comm-central scenario where it is as simple as $(STAGEDIST)/platform.ini?
Attachment #402186 - Attachment is obsolete: true
Attachment #402830 - Flags: review?(l10n)
Comment on attachment 402830 [details] [diff] [review]
mobile-browser/locales/Makefile.in - fixes the "make ident" step for MacOSX

This might be technically correct, but I'm not sure that putting those paths into mobile-browser helps us not breaking this accidentally.

Ted, do you have a better idea?
Attachment #402830 - Flags: review?(ted.mielczarek)
Moved the WinMo bits of this bug to bug 518886
Summary: fennec l10n nightly repacks -- winmo, win32/osx desktop → fennec l10n nightly repacks -- win32/osx desktop
This is for mozilla2-staging
Attachment #400702 - Attachment is obsolete: true
Attachment #402887 - Flags: review?(aki)
Comment on attachment 400703 [details] [diff] [review]
[buildbotcustom] allow the MobileNightlyFactory to deal with more platforms than just "linux"

I should just give myself the r+ for asking you to review your own patch ;)
Attachment #400703 - Attachment description: configs patch. 2/2 → [buildbotcustom] allow the MobileNightlyFactory to deal with more platforms than just "linux"
Attachment #400703 - Flags: review?(aki)
As discussed on IRC, the buildbotcustom change could not go in without changes on the configuration files for production.

The patch has production disabled until the other attachments (402830 and 402837) land first.
Attachment #402887 - Attachment is obsolete: true
Attachment #402905 - Flags: review?(aki)
Attachment #402887 - Flags: review?(aki)
Comment on attachment 402905 [details] [diff] [review]
 [staging and production] enable Fennec's win32 and osx desktop builds just on staging and get ready for production

looks good.
Attachment #402905 - Flags: review?(aki) → review+
Comment on attachment 400703 [details] [diff] [review]
[buildbotcustom] allow the MobileNightlyFactory to deal with more platforms than just "linux"

I think this is a good patch, but I don't think I can review it =)
Attachment #400703 - Flags: review?(aki) → review?(ccooper)
Attachment #400703 - Flags: review?(ccooper) → review+
Comment on attachment 402830 [details] [diff] [review]
mobile-browser/locales/Makefile.in - fixes the "make ident" step for MacOSX

Sort of ugly, but I don't know of a better place to put this stuff.

While you're in there, though:
ident:
 	@echo -n "gecko_revision "

Don't use "echo -n", it's not cross-platform. Use "printf" instead.
Attachment #402830 - Flags: review?(ted.mielczarek) → review+
Attachment #402837 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 402837 [details] [diff] [review]
[mc/m192] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

This needs to land on mozilla-central and then on 1.9.2.

We don't need it to land it on 191 since mobile does not build of it but it might be worth keeping to keep in sync. Any thoughts?
Attachment #402837 - Attachment description: downloads the windows installers only if a product declares in their $PRODUCT/locales/Makefile.in → [mc/m192] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file
Attachment #402837 - Flags: checked-in?
Dealt with ted's last comment and carrying forward the patch

Checkin-needed to land in the mobile repo
Attachment #402830 - Attachment is obsolete: true
Attachment #404619 - Flags: review+
Attachment #404619 - Flags: checked-in?
Attachment #402830 - Flags: review?(l10n)
Attachment #400703 - Flags: checked-in?
Attachment #402905 - Flags: checked-in?
(In reply to comment #24)
> Created an attachment (id=404619) [details]
> [mobile-browser/locales/Makefile.in] - fixes "make ident" for MacOSX (v2)
> 
> Dealt with ted's last comment and carrying forward the patch
> 
> Checkin-needed to land in the mobile repo

pushed:
https://hg.mozilla.org/mobile-browser/rev/77b21210b0c7
Attachment #404619 - Flags: checked-in? → checked-in+
Attachment #402837 - Flags: checked-in? → checked-in+
Comment on attachment 402837 [details] [diff] [review]
[mc/m192] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

http://hg.mozilla.org/mozilla-central/rev/6f59af25b825

Still need check-in on 1.9.2.
Here's the updated patch for 1.9.2 with the line breaks fixed. Carrying forward the review from Ted.
Attachment #404683 - Flags: review+
Comment on attachment 404683 [details] [diff] [review]
[1.9.2] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

The patch has worked correctly from the x-testing nightly run I just did.

Requesting approval-1.9.2 - This patch fixes Win32's Fennec Desktop builds for L10n
Attachment #404683 - Flags: approval1.9.2?
Comment on attachment 400703 [details] [diff] [review]
[buildbotcustom] allow the MobileNightlyFactory to deal with more platforms than just "linux"

http://hg.mozilla.org/build/buildbotcustom/rev/5d14de459270
Attachment #400703 - Flags: checked-in? → checked-in+
Comment on attachment 402905 [details] [diff] [review]
 [staging and production] enable Fennec's win32 and osx desktop builds just on staging and get ready for production

http://hg.mozilla.org/build/buildbot-configs/rev/94f34b0b4c6e
Attachment #402905 - Flags: checked-in? → checked-in+
Comment on attachment 405133 [details] [diff] [review]
[buildbotconfigs] add missing "\" at the end of the line

http://hg.mozilla.org/build/buildbot-configs/rev/ca8d2bd0c4fe
Attachment #405133 - Flags: review+
Attachment #405133 - Flags: checked-in+
Masters reconfigured and force some builds
Another funniness of Mac and where things lay around on disk.

If I had done a run on staging since the moz-central landing and now I would have reached this latter step (http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4757) and have caught this failure and have not have enabled the OS X it.

This patch disables MacOS X Desktop L10n builds.

Win32 Desktop L10n builds worked fine
Attachment #405147 - Flags: review?(nthomas)
Comment on attachment 405147 [details] [diff] [review]
[production/mobile_config.py] disable mac L10n desktop builds

r+, http://hg.mozilla.org/build/buildbot-configs/rev/459c6a345d20

(In reply to comment #34)
> If I had done a run on staging since the moz-central landing and now I would
> have reached this latter step
> (http://mxr.mozilla.org/build/source/buildbotcustom/process/factory.py#4757)
> and have caught this failure and have not have enabled the OS X it.

I don't understand your comment here. If something landed on m-c as part of this bug and that broke mac, then your testing was incomplete and these builds should not have been turned on in production. If changes in m-c from other people rotted you in the meantime then that's bad luck.
Attachment #405147 - Flags: review?(nthomas)
Attachment #405147 - Flags: review+
Attachment #405147 - Flags: checked-in+
Reconfigured masters. I will continue tomorrow.
Attachment #405256 - Flags: review?(ccooper)
Attachment #405256 - Flags: checked-in?
Attachment #405256 - Flags: review?(ccooper) → review+
Comment on attachment 405256 [details] [diff] [review]
[mobile_master.py] missing space

http://hg.mozilla.org/build/buildbot-configs/rev/2da9857aaffa
Attachment #405256 - Flags: checked-in? → checked-in+
Master reconfigured and triggered a successful Linux Desktop L10n nightly build.

Status update:
- Linux Fennec Desktop L10n builds - we have just fixed the regression. They will run correctly tomorrow.
- Win32 Fennec Desktop L10n builds - enabled for mobile-trunk. I will test on staging to see if we can enable it for 1.9.2 as well. Find the builds on ftp [1]
- MacOSX Fennec Desktop L10n builds - disabled for both branches. It requires more coding and testing. 

[1] http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/latest-mobile-trunk-l10n/?C=M;O=D
Comment on attachment 404683 [details] [diff] [review]
[1.9.2] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

This patch might have to be one line or two longer to grab the buildid to fix the mac desktop builds. I will let you know next week.
Attachment #404683 - Flags: approval1.9.2?
Comment on attachment 404683 [details] [diff] [review]
[1.9.2] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

(In reply to comment #40)
> (From update of attachment 404683 [details] [diff] [review])
> This patch might have to be one line or two longer to grab the buildid to fix
> the mac desktop builds. I will let you know next week.

My bad. I canceled incorrectly. To fix win32 localized builds for Fennec on 1.9.2 we need this patch. This is the only piece left for Windows desktop builds.

Please gives us approval 1.9.2 for localizers to be able to test Fennec on their Windows desktop machines.

Mac is the only one that will require a new patch and that does not need to land on neither on m-c nor on m-1.9.2. The only work for the Mac builds is on the mobile and builds repos. I will work on this later next week.
Attachment #404683 - Flags: approval1.9.2?
Attachment #404683 - Flags: approval1.9.2? → approval1.9.2+
Added dependency to bug 520765 since without win32 desktop build we can't generate *Localized* win32 desktop builds.
Depends on: 520765
Comment on attachment 404683 [details] [diff] [review]
[1.9.2] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

AFAICT, this needs branch landing.
Attachment #404683 - Flags: checked-in?
Chris has volunteered to look into this bug. Here is a summary of where we are at:

For Win32 localized desktop builds:
* land attachment 404683 [details] [diff] [review] patch on 192
* enable it
#MOBILE_BRANCHES['mobile-1.9.2']['l10n_platforms']['win32-i686'] = 'win32' 

For OSX localized desktop builds:
* on the mobile repos add one more line to get the buildid on the "make ident" target (check out the path calculations I do on attachment 404619 [details] [diff] [review] to see that Mac paths are tricky)
* enable it
#MOBILE_BRANCHES['mobile-trunk']['l10n_platforms']['macosx-i686'] = 'macosx'
#MOBILE_BRANCHES['mobile-1.9.2']['l10n_platforms']['macosx-i686'] = 'macosx'
Assignee: armenzg → ccooper
Priority: P2 → --
Comment on attachment 404683 [details] [diff] [review]
[1.9.2] download the windows installers only if a product declares RETRIEVE_WINDOWS_INSTALLER=1 in their $PRODUCT/locales/Makefile.in file

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/404846c8ace1
Attachment #404683 - Flags: checked-in? → checked-in+
Priority: -- → P3
Priority: P3 → P2
(In reply to comment #44) 
> For OSX localized desktop builds:
> * on the mobile repos add one more line to get the buildid on the "make ident"
> target (check out the path calculations I do on attachment 404619 [details] [diff] [review]
> to see that Mac paths are tricky)

This patch addresses Armen's comment.
Attachment #413192 - Flags: review?(mark.finkle)
The necessary branch patch for Windows has already landed, so I've re-enabled the Windows desktop repack in staging for tonight.
Attachment #413192 - Flags: review?(mark.finkle) → review+
Comment on attachment 413192 [details] [diff] [review]
[mobile-browser] Add the build ID to the output from 'make ident'

http://hg.mozilla.org/mobile-browser/rev/63a61ac2eda8
Attachment #413192 - Flags: checked-in+
Comment on attachment 413503 [details] [diff] [review]
Re-enable Fennec desktop repacks on Mac and Win32

Carrying over r+ from IRC. :)

http://hg.mozilla.org/build/buildbot-configs/rev/ba327c90ea70
Attachment #413503 - Flags: checked-in+
production-master02 reconfig-ed. Builders are there, should have nightly repacks tomorrow morning.
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
The schedulers didn't get started up on reconfig last night. Investigating.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Attachment #413503 - Flags: review?(aki)
There are some weird scheduler issues on p-m02 right now (bug 530119). bhearsum is looking into it.
Depends on: 530119
The restart of pn02 picked up the missing schedulers. Desktop repacks are appearing again for Mac and Win32.
Status: REOPENED → RESOLVED
Closed: 10 years ago10 years ago
Resolution: --- → FIXED
I know little about l10n: I assume we want this, please double-check.
Attachment #428026 - Flags: review?(kairo)
Attachment #428026 - Flags: review?(kairo) → review+
Comment on attachment 428026 [details] [diff] [review]
(AAv1-CC) Copy it to comm-central
[Checkin: Comment 56]


http://hg.mozilla.org/comm-central/rev/2e7623a399c2
Attachment #428026 - Attachment description: (AAv1-CC) Copy it to comm-central → (AAv1-CC) Copy it to comm-central [Checkin: Comment 56]
Attachment #428026 - Flags: checked-in+
Product: mozilla.org → Release Engineering
You need to log in before you can comment on or make changes to this bug.