503246 - nsISound::playSystemSound("_moz_mailbeep"); is obsolete on Gecko1.9.2a1 and later

Status: RESOLVED FIXED

(Thunderbird :: OS Integration, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

|nsISound::playSystemSound("_moz_mailbeep");| is obsolete on Gecko1.9.2a1 and later. Use |nsISound::playEventSound(nsISound::EVENT_NEW_MAIL_RECIEVED);| instead.

This is not a bug for *current* thunderbird trunk build. But after Tb3, we should fix it.

http://mxr.mozilla.org/comm-central/source/mail/components/preferences/general.js#126
http://mxr.mozilla.org/comm-central/source/mailnews/base/src/nsStatusBarBiffManager.cpp#157

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Hey, the product is different with bug 503248.

Comment 3

[Phil Ringnalda (:philor)]

I've already got another bug I have to remember to fix (on the branch) after we branch for 3.0, with a little luck that'll remind me it's time to fix this on the trunk.

Comment 4

[Phil Ringnalda (:philor)]

Actually, since the API has become broken and worthless on OS X since 1.8, I guess I won't be the one to fix this after all.

Comment 5

[Ludovic Hirlimann [:Usul]]

(In reply to comment #4)
> Actually, since the API has become broken and worthless on OS X since 1.8, I
> guess I won't be the one to fix this after all.

So what should we do with this bug Phil ?

Comment 7

[Mark Banner (:standard8)]

I'm fixing this in bug 594355.

Comment 8

[Mark Banner (:standard8)]

This is now fixed with the checkin of bug 594355