503597 - configure.in silently disables necko wifi when header is missing (Linux only)

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P2)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

On Linux only, configure.in silently disables NECKO_WIFI when iwlib.h isn't found.  This is inconsistent with other platforms (where we give an error saying to --disable-necko-wifi) and with the good practice of not disabling things silently (especially major new features of the browser).  (It wouldn't surprise me if some Linux distros end up shipping Firefox with wifi geolocation broken as a result.)

The attached patch makes this an error, consistent with the unknown platform case, but also provides some advice on getting iwlib.h.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/6e11834d07c9

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Backed out because tinderboxes need updating (particularly Linux x86_64 Firefox, which is effectively tier 1):
http://hg.mozilla.org/mozilla-central/rev/c0d86da16888
http://hg.mozilla.org/mozilla-central/rev/f3b0f579af93

See newly-filed dependent bugs.

Comment 3

[(not currently active) Ted Mielczarek]

In the future, if adding a library dependency to configure.in, please get Build Config peer review.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Benjamin looks like a build config peer to me.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

http://hg.mozilla.org/mozilla-central/rev/caa4e6ca1dbd

Comment 6

[Fabien Tassin]

s/iwlib-dev/libiw-dev/ for the Ubuntu/Debian package name

Comment 7

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Yes, I've already been told, and I have a fix ready to land when the tree reopens.

Comment 8

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

typo fixed: http://hg.mozilla.org/mozilla-central/rev/35ecfeedac76

And sorry for being snappy above... thanks for letting me know.

Comment 9

[Alexander L. Slovesnik]

Can Bug 509060 be caused by this bugfix?