504020 - TB doesn't show watch/ignore thread indicators in menus

Status: RESOLVED WORKSFORME

(Thunderbird :: Mail Window Front End, defect)

Description

[Will Pittenger]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9.1) Gecko/20090624 Firefox/3.5 GTB5 (.NET CLR 2.0.50727; .NET CLR 3.0.30618; .NET CLR 3.5.30729)
Build Identifier: User Agent: Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.8.1.22) Gecko/20090605 Thunderbird/2.0.0.22 Build ID: 2009060502

When TB shows a new thread in a newsgroup, I generally want to either watch or ignore that thread right there and then.  But even if a thread is watched or ignored, TB won't place an icon next to the thread telling me that until the thread has a reply.  So I don't know if it is or isn't being watched/ignored until then.  And yes, if you go into the Messages menu, TB never shows check marks next to the Watch or Ignore menu items.

Reproducible: Always

Steps to Reproduce:
1. Attempt to watch or ignore a thread with no replies
2. Even if you succeed, you can't tell that.  There is no way to know if the thread is watched, ignored, or neither until the thread has a reply.

(Exception: If you ignore a thread, leave the group, and return with Ignored Threads hidden, threads will be hidden if they are ignored even if they have no replies.)
Actual Results:  
Users have a tough time verifying that they marked the thread as ignored or watched until a reply comes in for that thread.

Expected Results:  
TB should provide user feedback for all actions.

Comment 1

[Will Pittenger]

Attachment: Screenshot showing no feedback for watched threads

Each of the threads in this screenshot are all watched (I think).  However, you will note that two of those threads don't have replies or a watched indicator icon.

Comment 2

[Joshua Cranmer [:jcranmer]]

It seems that you are using a theme... if you use the default theme, does the problem still occur?

Comment 3

[Will Pittenger]

Well, it looks like problem shown in the screen shot is caused by the Walnut theme.  However, the Watch and Ignore message items still don't get checkmarks when the selected message is being watched or ignored.

Comment 4

[Joshua Cranmer [:jcranmer]]

(In reply to comment #3)
> Well, it looks like problem shown in the screen shot is caused by the Walnut
> theme.  However, the Watch and Ignore message items still don't get checkmarks
> when the selected message is being watched or ignored.

The icons are only displayed at the root of the thread, since ignore and watch is a thread-level issue, not one at the message level. Ignoring subthreads was implemented as bug 11054; watching subthreads is some bug somewhere that's nearly impossible to find.

Do the icons correctly appear at the thread root when watched and/or ignored? They should replace the little tree thing:

|
+--+
   |
   +---
   |
   +---

Comment 5

[Will Pittenger]

My screen shot showed only the root of threads, not subthreads.

Comment 6

[Joshua Cranmer [:jcranmer]]

That was with the theme, though; the second problem you saw was without the theme and what was I asking about.

Comment 7

[Will Pittenger]

(In reply to comment #6)
> That was with the theme, though; the second problem you saw was without the
> theme and what was I asking about.
Now you lost me.

Comment 8

[Joshua Cranmer [:jcranmer]]

Can you post a screenshot of what the apparent condition is using only the default TB theme?

Comment 9

[Will Pittenger]

Attachment: Watched thread doesn't have Message/Watched checked

I selected a message that was watched.  The watched item isn't checked.

Comment 10

[Will Pittenger]

Please note that new attachment is with default skin as requested.  However, at that point, the problem is no longer with the list, but the menus.

Comment 11

[Joshua Cranmer [:jcranmer]]

So the toggles in the menu aren't checked...

clarkbw, your thoughts?

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

it does seem like the toggles in the menu should be checked.  minor bug since you should have the icon

Comment 13

[Wayne Mery (:wsmwk)]

bug 1176688 a duplicate?

Comment 14

[WaltS48 [:walts48]]

I'm seeing icons in the Thread pane for Watched and Ignored Threads with matching check marks in the Message menu item, and an Ignored Threads menu item under View > Threads I can use to find Ignored Threads after they get hidden in the 91.5.1 release candidate on Windows 10.

If I go to the Message > Ignore Thread menu item after ignoring a thread and click it again, it unignores the thread. Also, can right-click on the thread if visible using View > Threads > Ignored Threads and remove the check mark there.

Comment 15

[Wayne Mery (:wsmwk)]

Thanks Walt, I agree this is now WFM, both context menu and menu bar.