508221 - Favicons in search bar dropdown not shown if menus_have_icons=false

Status: VERIFIED FIXED

(Firefox :: Search, defect)

Description

[Andreas Nilsson (:andreasn)]

Attachment: screenshot

Related to bug 504275, GNOME recently set menus_have_icons to false by default. [1] What this means is that menus will no longer show icons.
However, bookmarks (and favicons) are exceptions that should use icons according to the guidelines [2] and those can be set to "always-show-icons" property (GtkImageMenuItem).

This also affects the tab dropdown, but I'll file another bug about that.

1. http://bugzilla.gnome.org/show_bug.cgi?id=557469
2. http://bugzilla.gnome.org/show_bug.cgi?id=588668

Comment 1

[Martin McNickle]

Attachment: patch

Adds the search icons again.

Comment 2

[Martin McNickle]

Attachment: combined rules

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Martin, you should ask a specific person for review. Dao could be the right one.

Comment 4

[Dão Gottwald [:dao]]

I think this belongs in searchbarBindings.css, since the menuitems are anonymous...

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I don't really have a strong opinion. Assuming it works, that patch seems fine to me.

Comment 6

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c08baee44cf4

Comment 7

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.3a1pre) Gecko/20091009 Minefield/3.7a1pre ID:20091009030724

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

It will probably not block, but bringing attention to drivers so we could get at least an approval for 1.9.2.

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Henrik; the better way to bring it to drivers' attention is to email me a list of bugs that you think are safe for approval, along with quick rationale.

Comment 11

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.2/rev/4637996a8752

Comment 12

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.2 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2b3pre) Gecko/20091111 Namoroka/3.6b3pre ID:20091111033750

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+1]]

We see a couple of complains from users who run Firefox 3.5.x on a current Ubuntu release where those icons are not displayed. Can we get this fix into 1.9.1 to show all of the search engine icons again?

Comment 16

[Micah Gersten]

Comment on attachment 397085 [details] [diff] [review]
combined rules

Requesting landing on 1.9.1 branch

Comment 17

[Samuel Sidler (old account; do not CC)]

Comment on attachment 397085 [details] [diff] [review]
combined rules

We're not going to take polish fixes on 1.9.1.

Comment 18

[Mike Hommey [:glandium]]

(In reply to comment #17)
> (From update of attachment 397085 [details] [diff] [review])
> We're not going to take polish fixes on 1.9.1.

FYI, the fix for bookmarks, which this fix depends on, has been pushed in 1.9.1.2...

Comment 19

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 397085 [details] [diff] [review]
combined rules

Yeah, I think we should take this.

Comment 20

[Daniel Veditz [:dveditz]]

Comment on attachment 397085 [details] [diff] [review]
combined rules

Approved for 1.9.1.8, a=dveditz for release-drivers

Comment 21

[Dão Gottwald [:dao]]

http://hg.mozilla.org/releases/mozilla-1.9.1/rev/fe03d187faa9

Comment 22

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Verified fixed on 1.9.1 with Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1.8pre) Gecko/20100128 Shiretoko/3.5.8pre

Comment 23

[Henrik Skupin [:whimboo][⌚️UTC+1]]

If this bug would ever regress, it will be highly visible. I don't think that it qualifies for a Litmus test.