504339 - Enhance compare-locales could use some xml-parsing error heuristics for entity values

Status: RESOLVED FIXED

(Mozilla Localizations :: Infrastructure, defect)

Description

[Axel Hecht [:Pike]]

Bug filed, there are some trivial things to catch inside entity values in DTDs to catch common XML parsing errors.

Comment 1

[cmtalbert]

Axel and Tim, it is quite possible that I missed some discussion in email or bugs since I'm still shoveling through the backlog from my vacation.  What's going on here and how can I help?

Comment 2

[Tim Riley [:timr]]

Clint-  this came up as some fall-out of a 3.5 locale issue that was seen right around release.  There was one error to an Entity reference that could have been caught by a simple string checker test tool.  There is an example in: 

http://mxr.mozilla.org/l10n-mozilla1.9.1/source/sr/toolkit/chrome/mozapps/update/updates.dtd#10

brandShortName is spelled wrong causing an XML parser error during the update.  A very bad thing to happen!  It was introduced several months go, but not seen until the manual update after 3.5 release.

There are probably other simple assertions about entities that should be tested.  We should sit down with Axel discuss options for solutions and resources to work on this.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+1]]

See bug 501596 and bug 498753.

Comment 5

[Axel Hecht [:Pike]]

Taking, I have a patch in the works.

Comment 6

[Axel Hecht [:Pike]]

Possible follow up bug, bug 570680 removed the check for the installer vars from the Makefile, if it's not obsoleted by MSIs, a similar check would be good.

Comment 7

[Robert Strong (they/them - no direct email)]

It won't be obsoleted by MSIs anytime soon and since there was the l10n requirement that NSIS had to use either properties or dtd files I think it is just as reasonable that compare-locales should be made to work with the NSIS properties files.

Comment 8

[Axel Hecht [:Pike]]

I'll need to move the installer vars stuff into a separate patch and get some help from :rs on those. I don't really know which of the things a trivial patch finds are errors and which just work.

Comment 9

[Axel Hecht [:Pike]]

I released compare-locales 0.9, marking this FIXED.

Using it on the dashboard is covered by bug 601942. Plan is to roll this in to production as part of the 2.0 branch downtime.

Coop, for getting this up on releng, how much public bake-time would you want? Also, what'd be a good time to do this? Shortly after branch?