Closed Bug 505120 Opened 17 years ago Closed 17 years ago

updater doesn't retain file permissions correctly

Categories

(Toolkit :: Application Update, defect)

Product:
Toolkit
Component:
Application Update
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
critical

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1
Tracking Flags:
Tracking Status
status1.9.2 --- beta1-fixed

People

(Reporter: mossop, Assigned: blassey)

References

Details

(Keywords: crash, regression)

Attachments

(2 files, 1 obsolete file)

apple crash report
16.48 KB, text/plain
Details
patch v.2
1.23 KB, patch
robert.strong.bugs
: review+
Details | Diff | Splinter Review
I had the nightly from 20090717 installed, it detected the update to 20090719 and downloaded and prompted to install it. When it did the updater crashed and subsequent attempts to launch Minefield stopped immediately. For some reason firefox-bin had lost the executable permissions on it. Console log shows the following messages: 19/07/2009 18:06:27 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Checker:getUpdateURL - update URL: https://aus2.mozilla.org/update/3/Firefox/3.6a1pre/20090717031446/Darwin_Universal-gcc3/en-US/nightly/Darwin%209.7.0/default/default/update.xml 19/07/2009 18:06:27 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Checker:checkForUpdates - sending request to: https://aus2.mozilla.org/update/3/Firefox/3.6a1pre/20090717031446/Darwin_Universal-gcc3/en-US/nightly/Darwin%209.7.0/default/default/update.xml 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Checker:onLoad - request completed downloading document 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Checker:getUpdateURL - update URL: https://aus2.mozilla.org/update/3/Firefox/3.6a1pre/20090717031446/Darwin_Universal-gcc3/en-US/nightly/Darwin%209.7.0/default/default/update.xml 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Checker:onLoad - number of updates available: 1 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC UpdateService:_selectAndInstallUpdate - no need to show prompt, just download the update 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC General:readStringFromFile - file doesn't exist: /Users/dave/Browsers/Minefield.app/Contents/MacOS/updates/0/update.status 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC General:readStatusFile - status: null, path: /Users/dave/Browsers/Minefield.app/Contents/MacOS/updates/0/update.status 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader:downloadUpdate - downloading from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/07/2009-07-17-03-mozilla-central/firefox-3.6a1pre.en-US.mac.partial.20090717031446-20090719031543.mar to /Users/dave/Browsers/Minefield.app/Contents/MacOS/updates/0/update.mar 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader:onStartRequest - spec: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/07/2009-07-17-03-mozilla-central/firefox-3.6a1pre.en-US.mac.partial.20090717031446-20090719031543.mar 19/07/2009 18:06:28 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 1046/852480 19/07/2009 18:06:29 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 13358/852480 19/07/2009 18:06:29 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 65342/852480 19/07/2009 18:06:30 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 147422/852480 19/07/2009 18:06:30 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 236342/852480 19/07/2009 18:06:31 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 300000/852480 19/07/2009 18:07:31 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 301041/852480 19/07/2009 18:07:31 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 320193/852480 19/07/2009 18:07:32 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 381753/852480 19/07/2009 18:07:32 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 452889/852480 19/07/2009 18:07:33 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 539073/852480 19/07/2009 18:07:33 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 600000/852480 19/07/2009 18:08:34 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 601041/852480 19/07/2009 18:08:35 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 620193/852480 19/07/2009 18:08:35 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 677649/852480 19/07/2009 18:08:36 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 781617/852480 19/07/2009 18:08:37 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 791193/852480 19/07/2009 18:08:38 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 837705/852480 19/07/2009 18:08:38 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader.onProgress:onProgress - progress: 852480/852480 19/07/2009 18:08:38 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader:onStopRequest - spec: http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/2009/07/2009-07-17-03-mozilla-central/firefox-3.6a1pre.en-US.mac.partial.20090717031446-20090719031543.mar, status: 0 19/07/2009 18:08:38 [0x0-0x7c87c8].org.mozilla.firefox *** AUS:SVC Downloader:onStopRequest - setting state to: pending 19/07/2009 18:08:50 [0x0-0x7c87c8].org.mozilla.firefox *** gUpdates 19/07/2009 18:08:50 [0x0-0x7c87c8].org.mozilla.firefox *** General 19/07/2009 18:08:52 [0x0-0x7c87c8].org.mozilla.firefox *** gFinishedPage 19/07/2009 18:09:02 updater[63519] An uncaught exception was raised 19/07/2009 18:09:02 updater[63519] launch path not accessible 19/07/2009 18:09:02 updater[63519] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible' 19/07/2009 18:09:02 updater[63519] Stack: ( 2494775467, 2415971899, 2494774923, 2494774986, 2534976826, 2534974329, 25569, 12312, 9858, 9641 ) 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2009-07-19 18:09:02.208 updater[63519:10b] An uncaught exception was raised 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2009-07-19 18:09:02.209 updater[63519:10b] launch path not accessible 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2009-07-19 18:09:02.209 updater[63519:10b] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible' 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2009-07-19 18:09:02.210 updater[63519:10b] Stack: ( 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2494775467, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2415971899, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2494774923, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2494774986, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2534976826, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 2534974329, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 25569, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 12312, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 9858, 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox 9641 19/07/2009 18:09:02 [0x0-0x7c87c8].org.mozilla.firefox ) 19/07/2009 18:09:27 [0x0-0x9fe9fe].org.mozilla.updater[63530] Usage: updater <dir-path> [parent-pid [working-dir callback args...]] 19/07/2009 18:09:27 com.apple.launchd[153] ([0x0-0x9fe9fe].org.mozilla.updater[63530]) Exited with exit code: 1 19/07/2009 18:09:37 com.apple.launchd[153] ([0x0-0xa02a02].org.mozilla.firefox[63537]) posix_spawnp("/Users/dave/Browsers/Minefield.app/Contents/MacOS/firefox-bin", ...): Permission denied
Severity: normal → critical
Whiteboard: crash
All dynlib files are missing the executable flag. For a list of files see bug 505166 comment 0. When I wanna start Minefield I get the following error: run-mozilla.sh: Cannot execute /Applications/Minefield.app/Contents/MacOS/firefox-bin.
Flags: blocking1.9.2?
Keywords: crash
Whiteboard: crash
Flags: blocking1.9.2? → blocking1.9.2+
I'll look into pulling Mac 20090717 and newer updates.
Attached file apple crash report —
Updating from 20090719 to 20090720 failed in the same way. Here is the apple crash report for the updater.
My best guess from the stack is that the real bug here is the stripping of executable permissions from firefox-bin. Updater just crashes because it attempts to launch it and doesn't catch the resulting exception. Most recent patch to updater code was July 16th which seems like a good place to start, bug 458950
I've pulled the mozilla-central nightly updates. They'll get regenerated tomorrow, so if we haven't fixed this by then I'll have to do it again.
(In reply to comment #6) > My best guess from the stack is that the real bug here is the stripping of > executable permissions from firefox-bin. Updater just crashes because it > attempts to launch it and doesn't catch the resulting exception. > > Most recent patch to updater code was July 16th which seems like a good place > to start, bug 458950 Unsure if this is related, but from a 07/19->07/20 update I lost execute permissions on firefox-bin Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090720 Minefield/3.6a1pre
Attached patch patch v.1 (obsolete) — — Splinter Review
I believe this patch will fix the problem. I'm working on a new test to verify that the updater sets permissions correctly. It passes all existing tests. A note about the patch, I'm not sure we *need* to use stat to check that permissions are set correctly. It might be overkill.
Assignee: nobody → bugmail
Attachment #389510 - Flags: review?(robert.bugzilla)
Attached patch patch v.2 — — Splinter Review
sorry, attached a broken patch. This the right one.
Attachment #389510 - Attachment is obsolete: true
Attachment #389521 - Flags: review?(robert.bugzilla)
Attachment #389510 - Flags: review?(robert.bugzilla)
Attachment #389521 - Flags: review?(robert.bugzilla) → review+
Comment on attachment 389521 [details] [diff] [review] patch v.2 >diff -r 2af1e35f36a1 toolkit/mozapps/update/src/updater/updater.cpp >--- a/toolkit/mozapps/update/src/updater/updater.cpp Mon Jul 20 12:45:12 2009 -0400 >+++ b/toolkit/mozapps/update/src/updater/updater.cpp Mon Jul 20 14:27:15 2009 -0400 >@@ -409,10 +409,20 @@ > return rv; > } > >-static FILE* ensure_open(const char *path, char* flags) >+static FILE* ensure_open(const char *path, char* flags, int options) > { > ensure_write_permissions(path); >- return fopen(path, flags); >+ FILE* f = fopen(path, flags); >+ if (chmod(path, options) !=0) { nit: space between != and 0
(In reply to comment #6) > Most recent patch to updater code was July 16th which seems like a good place > to start, bug 458950 It would be a candidate but I discovered the same problem on 1.9.1 with my upcoming Software test for Mozmill. It also crashes with the same stack. As far as I can see the patch on bug 458950 hasn't been checked into 1.9.1 yet, right? So there is another patch which breaks the update functionality. Thread 0 Crashed: 0 com.apple.CoreFoundation 0x935a2f54 ___TERMINATING_DUE_TO_UNCAUGHT_EXCEPTION___ + 4 1 libobjc.A.dylib 0x95b76e3b objc_exception_throw + 40 2 com.apple.CoreFoundation 0x935a2e8b +[NSException raise:format:arguments:] + 155 3 com.apple.CoreFoundation 0x935a2eca +[NSException raise:format:] + 58 4 com.apple.Foundation 0x92a05d3a -[NSConcreteTask launchWithDictionary:] + 2490 5 com.apple.Foundation 0x92a05379 -[NSConcreteTask launch] + 41 6 updater 0x000053f1 start + 13057 7 updater 0x00002f48 start + 3672 8 updater 0x000021f2 start + 258 9 updater 0x00002119 start + 41 2009-07-20 23:42:26.214 updater[73066:10b] Can't open input server /Library/InputManagers/MultiClutchInputManager.bundle 2009-07-20 23:42:27.159 updater[73066:10b] An uncaught exception was raised 2009-07-20 23:42:27.159 updater[73066:10b] launch path not accessible 2009-07-20 23:42:27.160 updater[73066:10b] *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible' 2009-07-20 23:42:27.160 updater[73066:10b] Stack: ( 2472161451, 2511826491, 2472160907, 2472160970, 2459983162, 2459980665, 21489, 12104, 8690, 8473 )
Status: NEW → ASSIGNED
Summary: Update from trunk nightly 20090717 to 20090719 crashed and broke Firefox → Update from trunk nightly 20090717 to 20090719 crashed and broke Firefox - 'NSInvalidArgumentException', reason: 'launch path not accessible'
pushed http://hg.mozilla.org/mozilla-central/rev/a568cdcd510d I've been able to reproduce the issue of the updater not copying permissions correctly and this patch does fix that bug. I'm still working on a unit test to cover this issue though.
Status: ASSIGNED → RESOLVED
Closed: 17 years ago
Resolution: --- → FIXED
Process: updater [2083] Path: /Applications/Minefield.app/Contents/MacOS/updates/0/updater.app/Contents/MacOS/updater Identifier: org.mozilla.updater Version: ??? (1.0) Code Type: X86 (Native) Parent Process: launchd [1] Interval Since Last Report: 2772733 sec Crashes Since Last Report: 11 Per-App Interval Since Last Report: 402 sec Per-App Crashes Since Last Report: 3 Date/Time: 2009-07-22 00:00:44.660 +0200 OS Version: Mac OS X 10.5.7 (9J61) Report Version: 6 Anonymous UUID: F4360E89-BB0B-4A7B-99B8-CB6CFD76D362 Exception Type: EXC_BREAKPOINT (SIGTRAP) Exception Codes: 0x0000000000000002, 0x0000000000000000 Crashed Thread: 0 Application Specific Information: *** Terminating app due to uncaught exception 'NSInvalidArgumentException', reason: 'launch path not accessible' Thread 0 Crashed: 0 com.apple.CoreFoundation 0x95235f54 ___TERMINATING_DUE_TO_UNCAUGHT_EXCEPTION___ + 4 1 libobjc.A.dylib 0x941cee3b objc_exception_throw + 40 2 com.apple.CoreFoundation 0x95235e8b +[NSException raise:format:arguments:] + 155 3 com.apple.CoreFoundation 0x95235eca +[NSException raise:format:] + 58 4 com.apple.Foundation 0x93582d3a -[NSConcreteTask launchWithDictionary:] + 2490 5 com.apple.Foundation 0x93582379 -[NSConcreteTask launch] + 41 6 org.mozilla.updater 0x000063e1 start + 15969 7 org.mozilla.updater 0x00003018 start + 2712 8 org.mozilla.updater 0x00002682 start + 258 9 org.mozilla.updater 0x000025a9 start + 41 Thread 1: 0 libSystem.B.dylib 0x93d282e6 semaphore_timedwait_signal_trap + 10 1 libSystem.B.dylib 0x93d5a2af _pthread_cond_wait + 1244 2 libSystem.B.dylib 0x93d5bb33 pthread_cond_timedwait_relative_np + 47 3 com.apple.Foundation 0x935abdcc -[NSCondition waitUntilDate:] + 236 4 com.apple.Foundation 0x935abbe0 -[NSConditionLock lockWhenCondition:beforeDate:] + 144 5 com.apple.Foundation 0x935abb45 -[NSConditionLock lockWhenCondition:] + 69 6 com.apple.AppKit 0x95341d20 -[NSUIHeartBeat _heartBeatThread:] + 753 7 com.apple.Foundation 0x93565e0d -[NSThread main] + 45 8 com.apple.Foundation 0x935659b4 __NSThread__main__ + 308 9 libSystem.B.dylib 0x93d59155 _pthread_start + 321 10 libSystem.B.dylib 0x93d59012 thread_start + 34 Thread 0 crashed with X86 Thread State (32-bit): eax: 0xa06360f0 ebx: 0x941cee1c ecx: 0xa06351a0 edx: 0x0000c000 edi: 0x00166f40 esi: 0xa0466928 ebp: 0xbfffede8 esp: 0xbfffede8 ss: 0x0000001f efl: 0x00000282 eip: 0x95235f54 cs: 0x00000017 ds: 0x0000001f es: 0x0000001f fs: 0x00000000 gs: 0x00000037 cr2: 0x55a21000 Binary Images: 0x1000 - 0x6ff2 +org.mozilla.updater ??? (1.0) <e4593dc276e7d40a3c820115a96495cf> /Applications/Minefield.app/Contents/MacOS/updates/0/updater.app/Contents/MacOS/updater 0x146f8000 - 0x148fffef com.apple.RawCamera.bundle 2.0.15 (471) <557c94fbd7c15219746393464a79cf87> /System/Library/CoreServices/RawCamera.bundle/Contents/MacOS/RawCamera 0x8fe00000 - 0x8fe2db43 dyld 97.1 (???) <100d362e03410f181a34e04e94189ae5> /usr/lib/dyld 0x9003e000 - 0x900f0ffb libcrypto.0.9.7.dylib ??? (???) <9d714c92872a93dd127ea8556b2c8945> /usr/lib/libcrypto.0.9.7.dylib 0x900f1000 - 0x9048efef com.apple.QuartzCore 1.5.8 (1.5.8) <a28fa54346a9f9d5b3bef076a1ee0fcf> /System/Library/Frameworks/QuartzCore.framework/Versions/A/QuartzCore 0x9062b000 - 0x90632ff7 libCGATS.A.dylib ??? (???) <211348279493364e9920adc86484cedd> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCGATS.A.dylib 0x90633000 - 0x9093bfff com.apple.HIToolbox 1.5.5 (???) <b17766e3d8800a73f534c41f624f5ac4> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/HIToolbox.framework/Versions/A/HIToolbox 0x9093c000 - 0x90985fef com.apple.Metadata 10.5.2 (398.25) <e0572f20350523116f23000676122a8d> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/Metadata.framework/Versions/A/Metadata 0x90a72000 - 0x90b5aff3 com.apple.CoreData 100.2 (186.1) <8fb61e1714a4b8d587ce97605ad32547> /System/Library/Frameworks/CoreData.framework/Versions/A/CoreData 0x91b3a000 - 0x91b67feb libvDSP.dylib ??? (???) <2ee4eb005babc90eaa352b33eb09226e> /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvDSP.dylib 0x91bdb000 - 0x91be5feb com.apple.audio.SoundManager 3.9.2 (3.9.2) <caa41909dcb5a18a94bc68cd13999bd5> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/CarbonSound.framework/Versions/A/CarbonSound 0x91bfa000 - 0x91c22ff7 com.apple.shortcut 1.0.1 (1.0) <131202e7766e327d02d55c0f5fc44ad7> /System/Library/PrivateFrameworks/Shortcut.framework/Versions/A/Shortcut 0x91c80000 - 0x91c90ffc com.apple.LangAnalysis 1.6.4 (1.6.4) <8b7831b5f74a950a56cf2d22a2d436f6> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/LangAnalysis.framework/Versions/A/LangAnalysis 0x91c94000 - 0x91cb2fff libresolv.9.dylib ??? (???) <a8018c42930596593ddf27f7c20fe7af> /usr/lib/libresolv.9.dylib 0x91cea000 - 0x91cf1fe9 libgcc_s.1.dylib ??? (???) <28a7cbc3a5ca2982d124668306f422d9> /usr/lib/libgcc_s.1.dylib 0x91cf2000 - 0x91ec3ffb com.apple.security 5.0.5 (36371) <c13e0bb1acfdcf94be4d3ee118ef190e> /System/Library/Frameworks/Security.framework/Versions/A/Security 0x91ec5000 - 0x91fa6ff7 libxml2.2.dylib ??? (???) <2f6b294896866822330a8888b7f53b75> /usr/lib/libxml2.2.dylib 0x91fa7000 - 0x92004ffb libstdc++.6.dylib ??? (???) <6106b1f2b0b303b06ae476253dbb5f3f> /usr/lib/libstdc++.6.dylib 0x9213e000 - 0x92197ff7 libGLU.dylib ??? (???) <a3b9be30100a25a6cd3ad109892f52b7> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLU.dylib 0x92198000 - 0x921cffff com.apple.SystemConfiguration 1.9.2 (1.9.2) <8b26ebf26a009a098484f1ed01ec499c> /System/Library/Frameworks/SystemConfiguration.framework/Versions/A/SystemConfiguration 0x921d0000 - 0x921fffe3 com.apple.AE 402.3 (402.3) <b13bfda0ad9314922ee37c0d018d7de9> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/AE.framework/Versions/A/AE 0x92200000 - 0x9227dfef libvMisc.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libvMisc.dylib 0x9227e000 - 0x92308fe3 com.apple.DesktopServices 1.4.8 (1.4.8) <3065de6531ce839c7cb5b6dd70e03f4f> /System/Library/PrivateFrameworks/DesktopServicesPriv.framework/Versions/A/DesktopServicesPriv 0x92309000 - 0x929a9fe3 com.apple.CoreGraphics 1.409.3 (???) <25dceb14af3455b768f56e8765ecf3ca> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/CoreGraphics 0x929aa000 - 0x92c84ff3 com.apple.CoreServices.CarbonCore 786.11 (786.13) <9e2d85d52e5e2951aa4dd53c48ccc52f> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CarbonCore.framework/Versions/A/CarbonCore 0x92c88000 - 0x92cc9fe7 libRIP.A.dylib ??? (???) <69bd09fcd8d8b235cee7a405290d6818> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libRIP.A.dylib 0x932a9000 - 0x932a9ffa com.apple.CoreServices 32 (32) <2760719f7a81e8c2bdfd15b0939abc29> /System/Library/Frameworks/CoreServices.framework/Versions/A/CoreServices 0x932aa000 - 0x93336ff7 com.apple.framework.IOKit 1.5.2 (???) <97b9f9d584f48891377f0481b9104434> /System/Library/Frameworks/IOKit.framework/Versions/A/IOKit 0x93419000 - 0x934acff3 com.apple.ApplicationServices.ATS 3.7 (???) <a535fc4982d3acff6530ec25c402e679> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ATS.framework/Versions/A/ATS 0x9351b000 - 0x9355afef libTIFF.dylib ??? (???) <3589442575ac77746ae99ecf724f5f87> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libTIFF.dylib 0x9355b000 - 0x937d7fe7 com.apple.Foundation 6.5.8 (677.24) <aa84b0383891378c348ffa4a94853082> /System/Library/Frameworks/Foundation.framework/Versions/C/Foundation 0x937d8000 - 0x937d8ff8 com.apple.Cocoa 6.5 (???) <e9318c93615b27231498bbe585b8da98> /System/Library/Frameworks/Cocoa.framework/Versions/A/Cocoa 0x93897000 - 0x938a7fff com.apple.speech.synthesis.framework 3.7.1 (3.7.1) <06d8fc0307314f8ffc16f206ad3dbf44> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/SpeechSynthesis.framework/Versions/A/SpeechSynthesis 0x93c64000 - 0x93c68fff libmathCommon.A.dylib ??? (???) /usr/lib/system/libmathCommon.A.dylib 0x93c69000 - 0x93c72fff com.apple.speech.recognition.framework 3.7.24 (3.7.24) <6a6518b392d3d41ace3dcea69d6809d9> /System/Library/Frameworks/Carbon.framework/Versions/A/Frameworks/SpeechRecognition.framework/Versions/A/SpeechRecognition 0x93c73000 - 0x93cf2ff5 com.apple.SearchKit 1.2.1 (1.2.1) <3140a605db2abf56b237fa156a08b28b> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/SearchKit.framework/Versions/A/SearchKit 0x93cf3000 - 0x93cfaffe libbsm.dylib ??? (???) <5582985a86ea36504cca31788bccf963> /usr/lib/libbsm.dylib 0x93cfb000 - 0x93d26fe7 libauto.dylib ??? (???) <2072d673706bbe463ed2426af57a28d7> /usr/lib/libauto.dylib 0x93d27000 - 0x93e8eff3 libSystem.B.dylib ??? (???) <b47c8e6e45aef620730710a732bf1930> /usr/lib/libSystem.B.dylib 0x93e90000 - 0x93e90ff8 com.apple.ApplicationServices 34 (34) <e9cd7c823062c4382d89e3c9997f4739> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/ApplicationServices 0x93e91000 - 0x93f4bfe3 com.apple.CoreServices.OSServices 227 (227) <30cebcb68b1b571df7d77474e0c31556> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/OSServices.framework/Versions/A/OSServices 0x93f58000 - 0x93ffffeb com.apple.QD 3.11.56 (???) <a94d0f5438b730e88e5efdb233295c52> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/QD.framework/Versions/A/QD 0x94000000 - 0x9401fffa libJPEG.dylib ??? (???) <e7eb56555109e23144924cd64aa8daec> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libJPEG.dylib 0x94020000 - 0x9402bfe7 libCSync.A.dylib ??? (???) <9e3544fe087bb4dc760b7afe0850dd6c> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreGraphics.framework/Versions/A/Resources/libCSync.A.dylib 0x9402c000 - 0x94172ff7 com.apple.ImageIO.framework 2.0.4 (2.0.4) <6a6623d3d1a7292b5c3763dcd108b55f> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/ImageIO 0x941c5000 - 0x942a5fff libobjc.A.dylib ??? (???) <7b92613fdf804fd9a0a3733a0674c30b> /usr/lib/libobjc.A.dylib 0x942a6000 - 0x94320ff8 com.apple.print.framework.PrintCore 5.5.4 (245.6) <03d0585059c20cb0bde5e000438c49e1> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/PrintCore.framework/Versions/A/PrintCore 0x94326000 - 0x943cafec com.apple.CFNetwork 438.10 (438.12) <fde64bbb20532794396fb21911ccaa98> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/CFNetwork.framework/Versions/A/CFNetwork 0x943cb000 - 0x94448feb com.apple.audio.CoreAudio 3.1.2 (3.1.2) <5a4e6329f8dbca5dcd70924525afd24a> /System/Library/Frameworks/CoreAudio.framework/Versions/A/CoreAudio 0x9444f000 - 0x9445bffe libGL.dylib ??? (???) /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGL.dylib 0x94471000 - 0x944cbff7 com.apple.CoreText 2.0.4 (???) <f0b6c1d4f40bd21505097f0255abfead> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/CoreText.framework/Versions/A/CoreText 0x944cc000 - 0x948dcfef libBLAS.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libBLAS.dylib 0x948dd000 - 0x948e5fff com.apple.DiskArbitration 2.2.1 (2.2.1) <42908e7ecc17a83cec4afef2850ec79e> /System/Library/Frameworks/DiskArbitration.framework/Versions/A/DiskArbitration 0x94929000 - 0x94935fff libbz2.1.0.dylib ??? (???) <e266a580d35c4518eee864dc064e4b98> /usr/lib/libbz2.1.0.dylib 0x94936000 - 0x94937ffc libffi.dylib ??? (???) <596e0dbf626b211741cecaa9698f271b> /usr/lib/libffi.dylib 0x949e9000 - 0x94da7fea libLAPACK.dylib ??? (???) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/libLAPACK.dylib 0x94da8000 - 0x94da8ffc com.apple.audio.units.AudioUnit 1.5 (1.5) /System/Library/Frameworks/AudioUnit.framework/Versions/A/AudioUnit 0x94da9000 - 0x94dc4ffb libPng.dylib ??? (???) <4780e979d35aa5ec2cea22678836cea5> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libPng.dylib 0x94dc5000 - 0x94efeff7 libicucore.A.dylib ??? (???) <cac059ebdac7d9a63ee0f7a648c9f6cf> /usr/lib/libicucore.A.dylib 0x94ff4000 - 0x9500afff com.apple.DictionaryServices 1.0.0 (1.0.0) <7e9ff586b5c9d02b09e2a5527d98524f> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/DictionaryServices.framework/Versions/A/DictionaryServices 0x9500b000 - 0x95097ff7 com.apple.LaunchServices 290.3 (290.6) <bdba267184df88bd5b8e2116ea903872> /System/Library/Frameworks/CoreServices.framework/Versions/A/Frameworks/LaunchServices.framework/Versions/A/LaunchServices 0x950e6000 - 0x950f2ff9 com.apple.helpdata 1.0.1 (14.2) /System/Library/PrivateFrameworks/HelpData.framework/Versions/A/HelpData 0x950f3000 - 0x9510bff7 com.apple.CoreVideo 1.6.0 (20.0) <dd60118bac9aefaf88d9ab44558f05c4> /System/Library/Frameworks/CoreVideo.framework/Versions/A/CoreVideo 0x9510c000 - 0x95146fe7 com.apple.coreui 1.2 (62) /System/Library/PrivateFrameworks/CoreUI.framework/Versions/A/CoreUI 0x95147000 - 0x95147ffd com.apple.Accelerate 1.4.2 (Accelerate 1.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Accelerate 0x95148000 - 0x95148ffd com.apple.Accelerate.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vecLib.framework/Versions/A/vecLib 0x95149000 - 0x9527cfef com.apple.CoreFoundation 6.5.6 (476.18) <2d52bab73660117571bd6486dc318f8e> /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation 0x9529b000 - 0x95a99fef com.apple.AppKit 6.5.7 (949.46) <a80f8cb62f6bdcb3bed3c8675d55881d> /System/Library/Frameworks/AppKit.framework/Versions/C/AppKit 0x95a9a000 - 0x95a9cff5 libRadiance.dylib ??? (???) <8a844202fcd65662bb9ab25f08c45a62> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libRadiance.dylib 0x95abc000 - 0x95b43ff7 libsqlite3.0.dylib ??? (???) <3334ea5af7a911637413334154bb4100> /usr/lib/libsqlite3.0.dylib 0x95c80000 - 0x95cbefff libGLImage.dylib ??? (???) <a6425aeb77f4da13212ac75df57b056d> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLImage.dylib 0x95cc9000 - 0x95cedfff libxslt.1.dylib ??? (???) <0a9778d6368ae668826f446878deb99b> /usr/lib/libxslt.1.dylib 0x95d69000 - 0x95e30ff2 com.apple.vImage 3.0 (3.0) /System/Library/Frameworks/Accelerate.framework/Versions/A/Frameworks/vImage.framework/Versions/A/vImage 0x95e31000 - 0x95ee1fff edu.mit.Kerberos 6.0.13 (6.0.13) <804bd1b3f08fb57396781f012006367c> /System/Library/Frameworks/Kerberos.framework/Versions/A/Kerberos 0x95f1f000 - 0x95f1fffd com.apple.vecLib 3.4.2 (vecLib 3.4.2) /System/Library/Frameworks/vecLib.framework/Versions/A/vecLib 0x960bf000 - 0x960cdffd libz.1.dylib ??? (???) <545ca09467025f77131cfac09d8b9375> /usr/lib/libz.1.dylib 0x96101000 - 0x9610efe7 com.apple.opengl 1.5.10 (1.5.10) <5a2813f80c9441170cc1ab8a3dac5038> /System/Library/Frameworks/OpenGL.framework/Versions/A/OpenGL 0x9610f000 - 0x96160ff7 com.apple.HIServices 1.7.0 (???) <01b690d1f376e400ac873105533e39eb> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/HIServices.framework/Versions/A/HIServices 0x96167000 - 0x96190fff libcups.2.dylib ??? (???) <1b0435164b9dc6c773d0b1f24701e554> /usr/lib/libcups.2.dylib 0x96191000 - 0x962e3ff3 com.apple.audio.toolbox.AudioToolbox 1.5.2 (1.5.2) /System/Library/Frameworks/AudioToolbox.framework/Versions/A/AudioToolbox 0x96b76000 - 0x97047fbe libGLProgrammability.dylib ??? (???) <7f18294a7bd0b6afe4319f29187fc70d> /System/Library/Frameworks/OpenGL.framework/Versions/A/Libraries/libGLProgrammability.dylib 0x9736f000 - 0x9736fffb com.apple.installserver.framework 1.0 (8) /System/Library/PrivateFrameworks/InstallServer.framework/Versions/A/InstallServer 0x973c0000 - 0x9748bfff com.apple.ColorSync 4.5.1 (4.5.1) /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ColorSync.framework/Versions/A/ColorSync 0x97493000 - 0x97497fff libGIF.dylib ??? (???) <572a32e46e33be1ec041c5ef5b0341ae> /System/Library/Frameworks/ApplicationServices.framework/Versions/A/Frameworks/ImageIO.framework/Versions/A/Resources/libGIF.dylib 0xfffe8000 - 0xfffebfff libobjc.A.dylib ??? (???) /usr/lib/libobjc.A.dylib 0xffff0000 - 0xffff1780 libSystem.B.dylib ??? (???) /usr/lib/libSystem.B.dylib
Verified fixed with the todays update to Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2a1pre) Gecko/20090720 Minefield/3.6a1pre ID:20090720031604
Status: RESOLVED → VERIFIED
Keywords: regressionwindow-wanted
I just tried. Now it's ok. Thank you
Also verified to be fixed on Linux, updating from 20090723 to 20090724
Flags: in-testsuite?
Summary: Update from trunk nightly 20090717 to 20090719 crashed and broke Firefox - 'NSInvalidArgumentException', reason: 'launch path not accessible' → updater doesn't retain file permissions correctly
Brad, I have a couple of ideas on how this could be tested in xpcshell. Would you like me to write the test or are you already writing one?
my approach thus far has been to try to patch an executable and test executing it. Its become clear now that this won't work because we'd have to build the two executables in order to produce a mar patch and we'd have to build with --enable-update-packaging in order for this to work. If you have other ideas feel to either post them here or write the test.
I was thinking of just adding a binary file to the test data dir and a modified version of the same file to the mar, copying the one from the data dir into the location where it would be updated, set the permissions, run the update, and verify that it still has the correct permissions. Can you think of any reason this wouldn't work?
That should do the trick. I think I was overly concerned with checking the executable bit based on the nature of this bug and confirming it will actually execute. But writable and readable should be sufficient for test coverage.
I'm going to be adding a couple of more files to the mar's for the tests and will take care of the test for this bug in bug 507339
Tests added for this bug in bug 507339 so marking in-testsuite+
Flags: in-testsuite? → in-testsuite+
Target Milestone: --- → mozilla1.9.2a1
Mass change: adding fixed1.9.2 keyword (This bug was identified as a mozilla1.9.2 blocker which was fixed before the mozilla-1.9.2 repository was branched (August 13th, 2009) as per this query: http://is.gd/2ydcb - if this bug is not actually fixed on mozilla1.9.2, please remove the keyword. Apologies for the bugspam)
Keywords: fixed1.9.2
Depends on: 789958
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: