If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Hook up mozmill tests to make package-tests and support running packaged test style

RESOLVED FIXED in Thunderbird 3.3a1

Status

Thunderbird
Testing Infrastructure
RESOLVED FIXED
8 years ago
6 years ago

People

(Reporter: standard8, Assigned: standard8)

Tracking

Trunk
Thunderbird 3.3a1
Dependency tree / graph
Bug Flags:
in-testsuite +

Thunderbird Tracking Flags

(thunderbird3.1 .7-fixed)

Details

(Whiteboard: [test-only change])

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

8 years ago
Created attachment 390425 [details] [diff] [review]
WIP

Bug 500142 added the "make mozmill" and "make mozmill-one" targets to the build system. It would be useful to extend the make structures so that the mozmill test files can be integrated into "make package". This would mean that testers (or other tinderboxes) could download a package and run the mozmill tests against a build. It would also mean testers could extend our tests and have the harness to make it easy to do so.

The general idea is this:

- Hook into the make package target, copy our test files to the dist/stage-package directory.
- Ensure that all tests reference support files relatively so that they can be run from within the package.

I had an initial attempt at this (see attached patch), I got a bit stuck when the tests started referencing the xpcshell support tests. As we didn't need this to get make mozmill & mozmill-one working, I left it.

I'm not planning on working on this in the near future - just filing it here so the patch doesn't get lost.
(Assignee)

Comment 1

8 years ago
Created attachment 390426 [details] [diff] [review]
Core WIP

I almost forgot, this patch would be needed for core. I'm not sure it is the best way of doing it, but it worked ;-)
(Assignee)

Updated

8 years ago
Component: Build Config → Testing Infrastructure
QA Contact: build-config → testing-infrastructure
(Assignee)

Updated

8 years ago
Summary: Hook up mozmill tests to make package. → Hook up mozmill tests to make package-tests and support running packaged test style
(Assignee)

Updated

7 years ago
Keywords: helpwanted
(Assignee)

Comment 2

7 years ago
Created attachment 464039 [details] [diff] [review]
Get just mozmill packaging working

Slightly different approach for now - until we get some form of libxul, the MozMill tests are the only ones that we can run in packaged form - xpcshell-tests need libxul and make check run on the same machine anyway.

Therefore this patch ignores the fact that we possibly need to sort out hooks for the mozilla-central stuff, and just enables package-tests for our mozmill tests. This way we can get try server + MozMill up and running quickly, and sort out xpcshell etc later once we've done libxul.

Andrew: I'll get gozer to review the build config bits, but can you review the mozmill changes please?

The basic idea of the mozmill changes is:

- Package tests really need a different structure and to package all the resource files.
- I didn't want to switch MozMill to running from objdir as Windows developers don't have symlinks, and this would be required for ojbdir. We could probably work around this with make mozill etc, but that seems slow and complicated.
- Therefore the tests attempt to load the files from a pre-set list of directories, if they don't find it, then they will report an error so that developers can easily fix it.
Assignee: nobody → bugzilla
Attachment #390425 - Attachment is obsolete: true
Attachment #390426 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #464039 - Flags: review?(bugmail)
(Assignee)

Updated

7 years ago
Blocks: 497353
(Assignee)

Comment 3

7 years ago
Comment on attachment 464039 [details] [diff] [review]
Get just mozmill packaging working

This seems to be working on try, so also requesting gozer's review.
Attachment #464039 - Flags: review?(gozer)
Comment on attachment 464039 [details] [diff] [review]
Get just mozmill packaging working

windows users can use symlinks, they just need to escalate privileges and maybe use hardlinks...

in any event, looks good.
Attachment #464039 - Flags: review?(bugmail) → review+
Attachment #464039 - Flags: review?(gozer) → review+
(Assignee)

Comment 5

7 years ago
I checked this in yesterday and it is working fine:

http://hg.mozilla.org/comm-central/rev/6bf5559f73a7
Status: ASSIGNED → RESOLVED
Last Resolved: 7 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.2a1
(Assignee)

Comment 6

7 years ago
Comment on attachment 464039 [details] [diff] [review]
Get just mozmill packaging working

a=Standard8 as I want to take onto comm-1.9.2 to support running MozMill tests on try server there.
Attachment #464039 - Flags: approval-thunderbird3.1.6+
(Assignee)

Comment 7

7 years ago
Checked into 1.9.2: http://hg.mozilla.org/releases/comm-1.9.2/rev/2684b4411b03

Tinderbox still passes.
status-thunderbird3.1: --- → .6-fixed
Keywords: verified-thunderbird3.1
Whiteboard: [test-only change]
Blocks: 721357
You need to log in before you can comment on or make changes to this bug.