All users were logged out of Bugzilla on October 13th, 2018

Not use thread summary view for newsgroups which aren't offline

RESOLVED FIXED in Thunderbird 3.0b4

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: Dolske, Assigned: standard8)

Tracking

(Blocks: 1 bug)

Trunk
Thunderbird 3.0b4
Dependency tree / graph
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [no l10n impact])

Attachments

(2 attachments)

(Reporter)

Description

9 years ago
Created attachment 392819 [details]
Screenshot

This seems to have be a new feature that arrived with TB3 beta 3.

This really interferes with reading newsgroups, because when I press "n" to go to the next unread message, first have to deal with a useless summary view (see screenshot). I can skip past it with another "n", but it really just shouldn't be there. It provides no useful information, and even if it did it's not what I'm expecting to see.
Flags: blocking-thunderbird3?

Comment 1

9 years ago
Possible dup of bug 498415
Marked fix on 2009-07-26

Using "n" opens the next thread correctly for me using:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090804 Lightning/1.0pre Shredder/3.0b4pre ID:20090804034606

Comment 2

9 years ago
Oh, and I disagree that the feature is not useful to summarize posts, without actually expanding the thread.
That only should happen when you click on a collapsed thread, however.
Note: for offline news folders, bug 478167 would help make the summaries useful.
Depends on: 478167
First pass would be to not do summaries for news folders at all.
Flags: blocking-thunderbird3? → blocking-thunderbird3+
Summary: thread summary view isn't very useful with newsgroups → Not use thread summary view for newsgroups which aren't offline
OS: Mac OS X → All
Hardware: x86 → All

Updated

9 years ago
Whiteboard: [no l10n impact]
Created attachment 396292 [details] [diff] [review]
Proposed fix

This does David's suggestion and disables summarizing the selection for newsgroups completely. When we fix bug 478167 we can re-enable it for offline newsgroups.

Note that I've created a summarizeSelectionInFolder attribute to make it clearer what we're checking and save copy/pasting the pref everywhere.

I have also fixed a bug whereby if mail.operate_on_msgs_in_collapsed_threads was false then we wouldn't display the first message in a thread with the thread collapsed.

The only thing that this changes that may or may not be desirable is that actions on collapsed threads in newsgroups will no longer apply to the whole thread. As we don't have the summary page that may be acceptable though. Hence requesting ui-review.
Assignee: nobody → bugzilla
Status: NEW → ASSIGNED
Attachment #396292 - Flags: ui-review?(clarkbw)
Attachment #396292 - Flags: review?(bugmail)

Updated

9 years ago
Target Milestone: --- → Thunderbird 3.0b4
Comment on attachment 396292 [details] [diff] [review]
Proposed fix

sounds good
Attachment #396292 - Flags: ui-review?(clarkbw) → ui-review+

Updated

9 years ago
Whiteboard: [no l10n impact] → [no l10n impact][has patch, needs review asuth]
Comment on attachment 396292 [details] [diff] [review]
Proposed fix

Good improvements all around, especially the bug fix :)
Attachment #396292 - Flags: review?(bugmail) → review+
Whiteboard: [no l10n impact][has patch, needs review asuth] → [no l10n impact][can land]
Checked in: http://hg.mozilla.org/comm-central/rev/da09a490e33b
Blocks: 478167
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
No longer depends on: 478167
Resolution: --- → FIXED
Whiteboard: [no l10n impact][can land] → [no l10n impact]
Depends on: 528780
You need to log in before you can comment on or make changes to this bug.