Port Bug 301048 - Copying a single bookmark should not append a new line to the end of the URL

RESOLVED FIXED in seamonkey2.0b2

Status

RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

Tracking

Trunk
seamonkey2.0b2
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 393179 [details] [diff] [review]
proposed patch
Attachment #393179 - Flags: superreview?(neil)
Attachment #393179 - Flags: review?(neil)

Comment 1

9 years ago
Comment on attachment 393179 [details] [diff] [review]
proposed patch

>+    sTextUnicode = sTextUnicode.replace(/\n$/,"");
Nit: space after comma

Do you know what happened to bug 301048 comment #7?
Attachment #393179 - Flags: superreview?(neil)
Attachment #393179 - Flags: superreview+
Attachment #393179 - Flags: review?(neil)
Attachment #393179 - Flags: review+
(Assignee)

Comment 2

9 years ago
Created attachment 393221 [details] [diff] [review]
patch
[Checkin: Comment 3]

(In reply to comment #1)
> Do you know what happened to bug 301048 comment #7?

No (I just found the bug via CVS Blame) but I can tell you what Firefox 3.5 is doing: bookmarks separated by \r\n\r\n and a final \r\n (at least on Windows). The empty line seems a bit excessive since whitespace is combined in HTML. I'd say just always add a single line break after each bookmark for copy as HTML. Shall I add a patch for that or file a new bug?
Attachment #393179 - Attachment is obsolete: true
Attachment #393221 - Flags: superreview+
Attachment #393221 - Flags: review+
(Assignee)

Updated

9 years ago
Keywords: checkin-needed
(Assignee)

Updated

9 years ago
Blocks: 509094
Comment on attachment 393221 [details] [diff] [review]
patch
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/e9d9f6b514ac
Attachment #393221 - Attachment description: patch for checkin, r+sr=neil → patch [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
You need to log in before you can comment on or make changes to this bug.