Closed Bug 509029 Opened 15 years ago Closed 15 years ago

Port Bug 301048 - Copying a single bookmark should not append a new line to the end of the URL

Categories

(SeaMonkey :: Bookmarks & History, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
seamonkey2.0b2

People

(Reporter: InvisibleSmiley, Assigned: InvisibleSmiley)

References

Details

Attachments

(1 file, 1 obsolete file)

Attached patch proposed patch (obsolete) — Splinter Review
      No description provided.
Attachment #393179 - Flags: superreview?(neil)
Attachment #393179 - Flags: review?(neil)
Comment on attachment 393179 [details] [diff] [review]
proposed patch

>+    sTextUnicode = sTextUnicode.replace(/\n$/,"");
Nit: space after comma

Do you know what happened to bug 301048 comment #7?
Attachment #393179 - Flags: superreview?(neil)
Attachment #393179 - Flags: superreview+
Attachment #393179 - Flags: review?(neil)
Attachment #393179 - Flags: review+
(In reply to comment #1)
> Do you know what happened to bug 301048 comment #7?

No (I just found the bug via CVS Blame) but I can tell you what Firefox 3.5 is doing: bookmarks separated by \r\n\r\n and a final \r\n (at least on Windows). The empty line seems a bit excessive since whitespace is combined in HTML. I'd say just always add a single line break after each bookmark for copy as HTML. Shall I add a patch for that or file a new bug?
Attachment #393179 - Attachment is obsolete: true
Attachment #393221 - Flags: superreview+
Attachment #393221 - Flags: review+
Keywords: checkin-needed
Blocks: 509094
Comment on attachment 393221 [details] [diff] [review]
patch
[Checkin: Comment 3]


http://hg.mozilla.org/comm-central/rev/e9d9f6b514ac
Attachment #393221 - Attachment description: patch for checkin, r+sr=neil → patch [Checkin: Comment 3]
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0b2
You need to log in before you can comment on or make changes to this bug.