509053 - Individual scripts, subroutines, and modules should not all have to have code to check if PatchReader is installed

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement)

Description

[Max Kanat-Alexander]

Right now we have code that tries to load PatchReader to see if it's enabled, all over the place. Instead, we should just have a feature_enabled function that tells us if a particular feature is enabled.

Comment 1

[Max Kanat-Alexander]

The patch I'm about to attach will be built on top of bug 509045.

Comment 2

[Max Kanat-Alexander]

Attachment: v1

Comment 3

[Frédéric Buclin]

Comment on attachment 393233 [details] [diff] [review]
v1

It looks good, but it conflicts with your checkin from bug 509108 in Template.pm. Could you unbitrot it?

Comment 4

[Max Kanat-Alexander]

Attachment: v2

Okay, here you go. :-) I also added POD in Bugzilla.pm for feature().

Comment 5

[Frédéric Buclin]

Comment on attachment 403706 [details] [diff] [review]
v2

Seems to work fine. r=LpSolit

Please commit it asap as it bitrots one of my own patches waiting for review.

Comment 6

[Max Kanat-Alexander]

Okay, here we go! :-)

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.77; previous revision: 1.76
done
Checking in attachment.cgi;
/cvsroot/mozilla/webtools/bugzilla/attachment.cgi,v  <--  attachment.cgi
new revision: 1.162; previous revision: 1.161
done
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.203; previous revision: 1.202
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.423; previous revision: 1.422
done
Checking in show_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/show_bug.cgi,v  <--  show_bug.cgi
new revision: 1.61; previous revision: 1.60
done
Checking in Bugzilla/Template.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Template.pm,v  <--  Template.pm
new revision: 1.109; previous revision: 1.108
done
Checking in template/en/default/attachment/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/edit.html.tmpl,v  <--  edit.html.tmpl
new revision: 1.62; previous revision: 1.61
done
Checking in template/en/default/attachment/list.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/attachment/list.html.tmpl,v  <--  list.html.tmpl
new revision: 1.42; previous revision: 1.41
done
Checking in template/en/default/global/code-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/code-error.html.tmpl,v  <--  code-error.html.tmpl
new revision: 1.118; previous revision: 1.117
done

Comment 7

[Max Kanat-Alexander]

Added to the release notes in bug 547466.