510643 - Thread pane is cleared after rebuild-index of local mail folder

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[WADA:World Anti-bad-Duping Agency]

Attachment: NSPR log (all-5) for STR

Thread pane is cleared after rebuild-index of local mail folder.
Thread pane display is recovered by "click of other folder, then click folder again". 

This bug doesn't occur on IMAP folder.
If IMAP folder, thread pane is cleared after rebuild-index, but thread pane is automatically refreshed just after the clear of thread pane.

[ Build ID ]
> Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3pre) Gecko/20090813 Shredder/3.0b4pre

[ Steps to reproduce ]
1. Click(open) Inbox (local mail folder)
2. Folder Properties/Rebuild Index => Thread pane is cleared
3. Close Folder Properties panel.
4. Click other local mail folder(Drafts), then click Inbox again.
    => Thread pane is refreshed

Comment 1

[WADA:World Anti-bad-Duping Agency]

XBL bindings related issue like Bug 506199?
Or simply issue of "no thread pane refresh" after "thread pane clear"?

Comment 2

[WADA:World Anti-bad-Duping Agency]

Bug 505044 is relevant?(root cause?).
> Bug 505044 Selection lost when leaving a folder and coming back into it
>             (mailnews.remember_selected_message doesn't work)

Comment 3

[David :Bienvenu]

I really think this is a blocker - to the user, it looks like they lost all their mail.

Comment 4

[David :Bienvenu]

I believe the way this used to work is that someone (the folder pane?) listened for the folderLoaded notification and rebuilt the view - the folder loaded notification is the only notification I see getting sent in this case, so it seems like that must be how it worked.

Comment 5

[David :Bienvenu]

in SM (and prev versions of TB), the 3 pane ui listened for the folder loaded notification and did the reload. Now it looks like its up to the dbViewWrapper, though it may not be quite ready for this situation.

Comment 6

[David :Bienvenu]

Attachment: possible fix

this fixes it for me - it's a bit hacky trying to convince the folderDisplay widget and the folder tree that selection really needs to do something, but it does work.

Comment 7

[David :Bienvenu]

Attachment: get specific about the errors we expect from update folder

Comment 8

[David :Bienvenu]

Attachment: messed up braces playing with the mercurial queue...

Comment 9

[Rain [:rain1] (inactive)]

Comment on attachment 409941 [details] [diff] [review]
messed up braces playing with the mercurial queue...

>diff --git a/mail/base/content/folderPane.js b/mail/base/content/folderPane.js
>       }
>-      folder.updateFolder(msgWindow);
>+      // We expect these errors, so swallow them but re-throw any others.
>+      try {
>+        folder.updateFolder(msgWindow);
>+      } catch (e) { if (e.result != Cr.NS_ERROR_NOT_INITIALIZED &&

Could you please move the catch to the next line? Unfortunately, the whole file is a mish-mash of styles, but I think it's worthwhile to make an attempt to maintain consistency within a function.

>+                       e.result != NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE) {
>+                     throw(e);
>+                  }
>+      }

A more convenient syntax is:

catch (e if e.result == Cr.NS_ERROR_NOT_INITIALIZED ||
            e.result == NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE)

(from <https://developer.mozilla.org/en/core_javascript_1.5_guide/exception_handling_statements/try...catch_statement#The_catch_Block>, the section on conditional catch blocks)

I can't find where NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE is defined.

>+      gFolderTreeView.selection.clearSelection();
>+      gFolderDisplay.show(null);
>+      gFolderTreeView.selectFolder(folder);

gFolderDisplay.select(folder) seems to work here instead of these three lines, and avoids the momentary display of account central.

Comment 10

[Rain [:rain1] (inactive)]

(In reply to comment #9)
> I can't find where NS_MSG_ERROR_FOLDER_SUMMARY_OUT_OF_DATE is defined.

In fact, I can't find where Cr is defined, either.

Comment 11

[David :Bienvenu]

Attachment: much simpler fix

thx, yeah, that's much nicer.

Comment 12

[David :Bienvenu]

fix checked into 3.0 branch and trunk.