510849 - web storage (localStorage/sessionStorage) empty string as key not supported

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Andrea Giammarchi]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2

Accordingly with W3 draft:
Each Storage object provides access to a list of key/value pairs, which are sometimes called items. Keys are strings. Any string (including the empty string) is a valid key.
but this is not true in Firefox

Reproducible: Always

Steps to Reproduce:
1.sessionStorage.setItem("", "test");
2.alert(sessionStorage.getItem(""));
Actual Results:  
null

Expected Results:  
the string "test"

associate the empty string with the data "string" as other browsers do

Comment 1

[Juriy "kangax" Zaytsev]

I can confirm this on 3.5.2 (Mac OS X). Dupes not found, marking as new.

Comment 3

[Ernst de Haan]

I can confirm this with Firefox 3.6.3 on Mac OS X 10.6.3.

Comment 4

[Honza Bambas (:mayhemer)]

Not time to work on this right now.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch v1

AFAICT, this works.

Comment 6

[Honza Bambas (:mayhemer)]

Comment on attachment 623404 [details] [diff] [review]
Patch v1

Review of attachment 623404 [details] [diff] [review]:
-----------------------------------------------------------------

Can you please add a test for this to test_localStorageBase.html, test_sessionStorageBase.html and all storageevent/ tests?

::: dom/imptests/webapps.json
@@ -23,5 @@
> -    "All 3 items should be added.": true,
> -    "array access should be correct": true,
> -    "getItem should be correct": true
> -  },
> -

Not sure why you are removing these tests...

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I'm not removing the tests, just the annotations that they failed.

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/6d219f7754f0