Closed Bug 511320 Opened 12 years ago Closed 11 years ago
Security Device Manager: When FIPS mode change fails, inform the user
Sometimes, because of bugs, or because of user environment, it's impossible to switch into FIPS mode, or to switch out of FIPS mode. As seen in bug 509319, the only clue to the user is an exception shown in error console. Not very helpful. So, this bug proposes: When a device goes to Security Device Manager, clicks on disable/enable FIPS, and the operation fails, then: Show an error message.
because PSM does not handle the exception, PSM will crash after the user has tried to enable FIPS and is unsuccessful.
Status: NEW → ASSIGNED
catch exception and display error message.
Attachment #408141 - Flags: review?(kaie)
catch exception and display error message. not sure which version you would prefer kaie but if neither pass review, please state which one I should continue with.
Comment on attachment 408180 [details] [diff] [review] Patch v2 This patch has localization issues, in many languages your trick will not work.
Comment on attachment 408141 [details] [diff] [review] Patch v1 looks good to me, r=kaie
Attachment #408141 - Flags: review?(kaie) → review+
if you're happy with this patch as is, and can't checkin yourself, then please add checkin-needed to keywords
Whiteboard: [good first bug]
If the operation fails to change the FIPS mode the process should be restarted. changing message: unable_to_toggle_fips=Unable to change the FIPS mode for the security device. It is recommended that you exit and restart this application.
Comment on attachment 411344 [details] [diff] [review] patch v3 r=kaie
Attachment #411344 - Flags: review?(kaie) → review+
security/manager/locales/en-US/chrome/pippki/pippki.properties security/manager/pki/resources/content/device_manager.js committed changeset 34941:293c5dfbe6ff
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Can't see the changeset, did you commit, but forget to push?
I will push when the tinderbox is green.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Alerts suck, is there no other way of doing this? (Larry bar drop-down comes to mind). Also, if you must use an alert, the global window.alert should be avoided (although it may not be an issue in this specific scenario), grab the alert service by contract and directly call the alert method...
http://hg.mozilla.org/mozilla-central/rev/c13b8d0a066c I replaced "alert" with "doPrompt" from bug 527713.
Status: REOPENED → RESOLVED
Closed: 12 years ago → 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla2.0b2
You need to log in before you can comment on or make changes to this bug.