511320 - Security Device Manager: When FIPS mode change fails, inform the user

Status: RESOLVED FIXED

(Core :: Security: PSM, defect)

Description

[Kai Engert (:KaiE:)]

Sometimes, because of bugs, or because of user environment, it's impossible to switch into FIPS mode, or to switch out of FIPS mode.

As seen in bug 509319, the only clue to the user is an exception shown in error console. Not very helpful.

So, this bug proposes:

When a device goes to Security Device Manager, clicks on disable/enable FIPS, and the operation fails, then:

  Show an error message.

Comment 1

[glen beasley]

because PSM does not handle the exception, PSM will crash after the user has tried to enable FIPS and is unsuccessful.

Comment 2

[glen beasley]

Attachment: Patch v1

catch exception and display error message.

Comment 3

[glen beasley]

Attachment: Patch v2

catch exception and display error message. not sure which version you would prefer kaie but if neither pass review, please state which one I should continue with.

Comment 4

[Kai Engert (:KaiE:)]

Comment on attachment 408180 [details] [diff] [review]
Patch v2

This patch has localization issues, in many languages your trick will not work.

Comment 5

[Kai Engert (:KaiE:)]

Comment on attachment 408141 [details] [diff] [review]
Patch v1

looks good to me, r=kaie

Comment 6

[Kai Engert (:KaiE:)]

if you're happy with this patch as is, and can't checkin yourself, then please add
  checkin-needed
to keywords

Comment 7

[glen beasley]

Attachment: patch v3

If the operation fails to change the FIPS mode the process should be restarted. changing message:
unable_to_toggle_fips=Unable to change the FIPS mode for the security device. It is recommended that you exit and restart this application.

Comment 8

[Kai Engert (:KaiE:)]

Comment on attachment 411344 [details] [diff] [review]
patch v3

r=kaie

Comment 9

[glen beasley]

security/manager/locales/en-US/chrome/pippki/pippki.properties
security/manager/pki/resources/content/device_manager.js
committed changeset 34941:293c5dfbe6ff

Comment 10

[Kai Engert (:KaiE:)]

Can't see the changeset, did you commit, but forget to push?

Comment 11

[glen beasley]

I will push when the tinderbox is green.

Comment 12

[Nochum Sossonko [:Natch]]

Alerts suck, is there no other way of doing this? (Larry bar drop-down comes to mind). Also, if you must use an alert, the global window.alert should be avoided (although it may not be an issue in this specific scenario), grab the alert service by contract and directly call the alert method...

Comment 15

[Dão Gottwald [:dao]]

http://hg.mozilla.org/mozilla-central/rev/c13b8d0a066c

I replaced "alert" with "doPrompt" from bug 527713.