Closed
Bug 512773
Opened 15 years ago
Closed 15 years ago
[1.1] Developer Hub Homepage
Categories
(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)
addons.mozilla.org Graveyard
Developer Pages
Tracking
(Not tracked)
VERIFIED
FIXED
5.1
People
(Reporter: fligtar, Assigned: rdoherty)
References
()
Details
Attachments
(2 files, 2 obsolete files)
375.76 KB,
image/png
|
Details | |
72.32 KB,
patch
|
clouserw
:
review+
|
Details | Diff | Splinter Review |
Please see section 1.1 of the spec linked above for details.
This bug is for implementation of the homepage at addons.mozilla.org/developers, in accordance with the spec and mock-up attached with the following details:
* The title of the site will be Add-on Developer Hub, although that should be taken care of in the global header/nav bug.
* The promo box (large box with the fox) changes based on whether the user is logged into AMO with at least one add-on submitted. This bug is for implementing the logged-out/no-addons state, which has the "Are you ready to make browsing better?" text.
* The promo box copy is not ready yet. Please include some placeholder text that I will update later.
* The Start Making Add-ons button should link to the Getting Started page.
* The Ready to Share? box's button should link to the developer tools add-on submission form.
* The Developer Blog section should be called Developer News and pull the 5 latest blog entries from http://blog.mozilla.com/addons/category/developers/feed/
* The Upcoming Events box should be created, but I will file a separate bug for implementation of the dynamic events.
* The links at the bottom have changed from the mock-up placeholders. They will be:
-> Learn & Explore
** How-to Library
** API & Language Reference
** Case Studies
-> Create & Connect
** Developer Forums
** Add-on Builder
** Add-on Validator
The copy for under these links will be forthcoming. Please use placeholders for now.
I think it will probably be easiest for l10n if we make strings localizable but don't add them to the .pos until the final copy is in place.
Reporter | ||
Updated•15 years ago
|
Assignee: nobody → rdoherty
Reporter | ||
Comment 1•15 years ago
|
||
Any assets needed for the Developer Hub should be here: http://people.mozilla.org/~chowse/drop/developer_amo/v4/assets/common/ If you find something missing or have any questions on style, please ask.
Assignee | ||
Comment 2•15 years ago
|
||
Can I get the psds/ai files for this?
Comment 3•15 years ago
|
||
Assignee | ||
Comment 4•15 years ago
|
||
partial patch for quick review to make sure I'm not doing anything terribly wrong.
Attachment #399357 -
Flags: review?(clouserw)
Updated•15 years ago
|
Attachment #399357 -
Flags: review?(clouserw) → review+
Assignee | ||
Comment 5•15 years ago
|
||
Full patch.
Notes:
* The main promo module at the top shrinks as the browser window narrows. Tried to get it to work as best I could without the bg image going under the text or the text becoming too narrow.
* Most links have no urls yet.
* Didn't implement calendar code as that's another bug.
* Created a migration, but no rev # yet as code hasn't been committed
* run `bin/maintenance.php blog` to fetch blog posts
* Not sure if more error checking is needed when fetching blog posts
* No detection for if the user has add-ons, will address that in bug 512778
Attachment #399357 -
Attachment is obsolete: true
Attachment #399670 -
Flags: review?(clouserw)
Assignee | ||
Comment 6•15 years ago
|
||
RTL fixes that I forgot.
Attachment #399670 -
Attachment is obsolete: true
Attachment #399805 -
Flags: review?(clouserw)
Attachment #399670 -
Flags: review?(clouserw)
Updated•15 years ago
|
Attachment #399805 -
Flags: review?(clouserw) → review+
Comment 7•15 years ago
|
||
Comment on attachment 399805 [details] [diff] [review]
v2
Looking great. Two things before committing:
1) Please add 'true' as a second parameter to: debug('Could not fetch blog feed');
2) in addons_html.php you have some strings like "Posted %d days ago". Any string with a plural needs to use n___() even if it doesn't make sense in English, some locales have 5 or 6 plural forms and they'll need to differentiate them.
Assignee | ||
Comment 8•15 years ago
|
||
really messed up my tree with git, committed v2 patch, will add fixes on monday.
r51335
Reporter | ||
Comment 9•15 years ago
|
||
Thanks Ryan. I added the copy and links in r51371.
A couple comments:
* In the directory links section, there's a featured class that you have on case studies that gives it a blue background. I know this in the mockup, and at the time I assumed it was an on-hover thing, but I think we can remove it completely.
* The RSS icon should link to the feed.
* I think I put this in the Upcoming Events box bug, but since you ended up implementing it, we should remove the calendar icon.
Thanks!
Assignee | ||
Comment 10•15 years ago
|
||
r51430 fixes issues in comments 7 & 9
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
I went through this line by line and think I got them all covered as I was testing https://preview.addons.mozilla.org/en-US/firefox/developers.
Verified FIXED -- hub is looking great!
Status: RESOLVED → VERIFIED
Updated•9 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•