512778 - [1.1.2] Developer Hub homepage for developers

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect, P1)

Description

[Justin Scott [:fligtar]]

Attachment: mockup

Please see section 1.1.2 of the spec linked above for details.

The developer homepage implemented in bug 512773 is for visitors, meaning any user (logged-in or -out) that has no add-ons hosted on AMO. For developers, meaning any user logged in with at least one add-on hosted on AMO, the following changes should happen, as shown in the mock-up attached.

* The fox promo box (FPB) should change to be a 2-paneled display with the user's hosted add-ons on the left side in alphabetical order.
* If there are more add-ons than will fit in the display (5 or so), there should be a "More add-ons" link that goes to the full listing of the user's add-ons, currently called the dashboard.
* Clicking on an add-on should change the right panel to be the newsfeed and links for that add-on. If there are more newsfeed stories than will fit, the "Older activity" link should appear and link to the full newsfeed page for that add-on.
* If the user has more than 1 add-on, the top item should be "All Add-ons". When this is selected, the newsfeed should show the most recent stories for all the user's add-ons, with no add-on links at the bottom. The "Older activity" link should still appear.
* When the page is loaded, the top item (whether an add-on or All Add-ons) should be selected.
* The newsfeed panel's heading should link to the add-on's listing page. To the right of this heading should be an RSS icon for subscribing to the newsfeed for that add-on.
* The "Ready to share?" sidebar box should not appear for developers.
* The rest of the homepage remains the same as for visitors.

Comment 1

[Ryan Doherty (:rdoherty)]

Quick questions before I start:

* Where do the 4 links at the bottom of the feed link to?
* Instead of limiting # of add-ons or feed items, let's limit based on a #. 6 add-ons, 4 feed items?
* When feed items are loading, I'll put an ajax spinner over the list.

Comment 2

[Justin Scott [:fligtar]]

They're the same links currently used on the developer homepage:
* Edit Add-on: https://addons.mozilla.org/en-US/developers/addon/edit/11950
* Statistics: https://addons.mozilla.org/en-US/statistics/addon/11950
* Status: https://addons.mozilla.org/en-US/developers/addon/status/11950
* Versions & Files: https://addons.mozilla.org/en-US/developers/versions/11950

And sure, we can limit based on a set number. I just don't know what that number is based on the size of the implementation. 6 add-ons, 4 feed items sounds fine, and if it seems like we can fit more to make the box look right, bump it up.

Comment 3

[Ryan Doherty (:rdoherty)]

Do we have icons for all the types of stories? Looked through Chowse's files and AMO's icons, couldn't find icons for all the stories in https://bug513140.bugzilla.mozilla.org/attachment.cgi?id=397762

Comment 4

[Justin Scott [:fligtar]]

Attachment: icons

These are the icons to use. I've tried to label them appropriately, but let me know if you have any questions. Some are duplicates of others and many of these are already in AMO, but I assume you're making a sprite.

Comment 5

[Ryan Doherty (:rdoherty)]

Attachment: v1

first round. has everything bug the news feed stuff, which is in 513140

Comment 6

[Ryan Doherty (:rdoherty)]

Attachment: v1

Forgot 1 image.

Comment 7

[Wil Clouser [:clouserw]]

Comment on attachment 400796 [details] [diff] [review]
v1

I don't think inactive add-ons should show up in the main list on /developers/.  Otherwise it looks great.

Comment 8

[Wil Clouser [:clouserw]]

nice spriting too, btw

Comment 9

[Ryan Doherty (:rdoherty)]

(In reply to comment #8)
> nice spriting too, btw

:)

r51586

No real data yet until bug 513140 is done. Leaving open.

Comment 10

[Justin Scott [:fligtar]]

Talked to Ryan -- clicking on an add-on's name here should change the right panel dynamically, without page refresh. I should have been more explicit about that, and he forgot after implementing the no-JS version. He'll try to do this today and is out the rest of the week, so if he can't finish someone else will need to pick it up.

Comment 11

[Justin Scott [:fligtar]]

Attachment: screenshot

A couple more tweaks:
* The extension puzzle pieces should actually be the extension's icon. (This wasn't obvious from the mockup, sorry)
* Can we reduce the My Add-ons heading a bit, maybe to ~1.5em
* I have 5 add-ons + the All Add-ons link and the bottom add-on is really close to the bottom of the box, as shown in screenshot.

Comment 12

[Ryan Doherty (:rdoherty)]

working on changes now, odds are I won't get them in by eod.

Comment 13

[Ryan Doherty (:rdoherty)]

Realized that I need internet access to access the amo stage db, which I may not have during the next few days. Better to give this to Scott who implemented the feed.

Comment 14

[Scott McCammon [:mccammos]]

Attachment: Ajax + Addon Icons + Tweaks

Hooray!

Comment 15

[Scott McCammon [:mccammos]]

Attachment: Ajax + Addon Icons + Tweaks v2

Oops - left out rtl styling of add-on icons.

Comment 16

[Scott McCammon [:mccammos]]

Ajax + Addon Icons + Tweaks in r51814. Fixed.

Comment 17

[Milos Dinic [:Milos]]

1 question before verifying this:

> The newsfeed panel's heading should link to the add-on's listing page.

Here's the link to newsfeed panel:
https://preview.addons.mozilla.org/en-US/developers/feed/all

"News Feed for My Add-ons" is not linked. In case you are referring to a "Add-ons developer hub", everything is good.

Comment 18

[Scott McCammon [:mccammos]]

(In reply to comment #17)
> Here's the link to newsfeed panel:
> https://preview.addons.mozilla.org/en-US/developers/feed/all

That is the link to the main newsfeed. (see bug 513140)

The panel refers to the primary hub homepage element. (see attachment 396830 [details])

Comment 19

[Milos Dinic [:Milos]]

Than we have more problems:

> The newsfeed panel's heading should link to the add-on's listing page.

Then the newsfeed's panel heading is ie. "Recent Activity for All Add-ons" and it takes you to a news feed page rather than add-on's listing.

> To the right of this heading should be an RSS icon for subscribing to the
> newsfeed for that add-on.

Again, there is no RSS icon right to the "Recent Activity for All Add-ons". The only RSS icon I can see there is the one beside Developer's blog on the right hand side.

Comment 20

[Scott McCammon [:mccammos]]

Attachment: Rss icon, heading link, ajax login message

This patch adds an RSS icon/link to the newsfeed panel, adds a login message to ajax requested content in case session is gone, and links the newsfeed heading to the add-on's public page.

I left the heading for "all add-ons" linking to the user's main newsfeed page.

Comment 21

[Scott McCammon [:mccammos]]

RSS icon, heading link, and ajax login message committed in r52421.

Comment 22

[Milos Dinic [:Milos]]

Verified on https://preview.addons.mozilla.org/en-US/developers/

Thanks.