Closed
Bug 513707
Opened 15 years ago
Closed 15 years ago
Create a method to wait for load and focus events
Categories
(Testing :: Mochitest, defect)
Testing
Mochitest
Tracking
(status1.9.2 beta1-fixed)
RESOLVED
FIXED
mozilla1.9.3a1
Tracking | Status | |
---|---|---|
status1.9.2 | --- | beta1-fixed |
People
(Reporter: enndeakin, Assigned: enndeakin)
References
Details
Attachments
(1 file)
27.43 KB,
patch
|
sayrer
:
review+
|
Details | Diff | Splinter Review |
Allow the fix for bug 487817 to be used for other tests as well. This patch adds a method to wait for both a load and focus method before calling a callback:
SimpleTest.waitForFocus(callback, targetWindow)
targetWindow defaults to 'window'.
Attachment #397644 -
Flags: review?(sayrer)
Updated•15 years ago
|
Attachment #397644 -
Flags: review?(sayrer) → review+
Assignee | ||
Comment 1•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Comment 2•15 years ago
|
||
Did this regress Bug 513707?
Assignee | ||
Comment 3•15 years ago
|
||
A couple of days ago I checked in an improvement to this function which handles the case where the window is already focused and/or loaded, as well as added some logging information. I haven't seen any focus related failures on these tests since.
Updated•15 years ago
|
Assignee: nobody → enndeakin
Blocks: 451482
Whiteboard: [c-n: m-1.9.2 and m-1.9.1]
Target Milestone: --- → mozilla1.9.3a1
Version: unspecified → Trunk
Updated•15 years ago
|
Keywords: checkin-needed
Comment 4•15 years ago
|
||
Neil, could you land all that is needed on the branches?
Comment 5•15 years ago
|
||
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/9f66d32950bf
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7915c3bcf85d
notice i also had to push:
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/838b26c49605
http://hg.mozilla.org/releases/mozilla-1.9.2/rev/44800e329810
that brought improvements to the method. I think all of these are needed on 1.9.1, but i'm not sure if 1.9.1 can take all of this (focus rewrite went after 1.9.1 iirc)
Whiteboard: [c-n: m-1.9.2 and m-1.9.1] → [c-n: m-1.9.1?]
Updated•15 years ago
|
Keywords: checkin-needed
Updated•13 years ago
|
Comment 6•13 years ago
|
||
(In reply to Marco Bonardo [:mak] from comment #5)
> http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7915c3bcf85d
Ftr, this changeset was part of bug 554873.
status1.9.2:
--- → beta1-fixed
Whiteboard: [c-n: m-1.9.1?]
Comment 7•13 years ago
|
||
(In reply to Serge Gautherie (:sgautherie) from comment #6)
> (In reply to Marco Bonardo [:mak] from comment #5)
> > http://hg.mozilla.org/releases/mozilla-1.9.2/rev/7915c3bcf85d
>
> Ftr, this changeset was part of bug 554873.
Wrong.
This m-1.9.2 changeset had landed as
http://hg.mozilla.org/mozilla-central/rev/bad2d2351f7f
in "m-1.9.3/m-2.0".
You need to log in
before you can comment on or make changes to this bug.
Description
•