cannot bookmark pages using drag&drop

RESOLVED FIXED in seamonkey2.0

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
8 years ago
7 years ago

People

(Reporter: Rolf Bode-Meyer, Assigned: neil@parkwaycc.co.uk)

Tracking

({fixed-seamonkey2.0})

Trunk
seamonkey2.0
x86
Windows XP
fixed-seamonkey2.0
Bug Flags:
blocking-seamonkey2.0 +
blocking-seamonkey2.0b2 -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

8 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.4pre) Gecko/20090903 SeaMonkey/2.0b2pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; de; rv:1.9.1.4pre) Gecko/20090903 SeaMonkey/2.0b2pre

In nightly 20090831 it worked, in 20090903 it doesn't anymore.


Reproducible: Always

Steps to Reproduce:
1. Load a page.
2. Drag its icon in the address bar into the personal toolbar or the bookmark manager window.
Actual Results:  
During drag I get an insertion cursor but after drop nothing happens.

Expected Results:  
Bookmark for site should get inserted into bookmark list.

Comment 1

8 years ago
Error: Component returned failure code: 0x80004003 (NS_ERROR_INVALID_POINTER) [nsIRDFContainer.Init]
Source file: chrome://communicator/content/bookmarks/bookmarks.js
Line: 1393

I think this is a regression caused by Bug 342296
Blocks: 342296
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: blocking-seamonkey2.0?
Version: unspecified → Trunk
(Assignee)

Comment 2

8 years ago
Created attachment 398687 [details] [diff] [review]
Detect insertions

This just checks that the whole selection is movable, and if not, inserts it.
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #398687 - Flags: review?(iann_bugzilla)
(Assignee)

Comment 3

8 years ago
Created attachment 398689 [details] [diff] [review]
Emulate old behaviour
[Checkin: See comment 12]

The old behaviour was to try and delete as much of the selection as possible.

Thus the effect was to move where possible, and insert otherwise.
Attachment #398689 - Flags: review?(iann_bugzilla)

Updated

8 years ago
Attachment #398687 - Flags: review?(iann_bugzilla) → review+

Comment 4

8 years ago
Comment on attachment 398689 [details] [diff] [review]
Emulate old behaviour
[Checkin: See comment 12]

Could you stick a var before the i in line 1240 whilst you're at it?
Attachment #398689 - Flags: review?(iann_bugzilla) → review+
(Reporter)

Comment 5

8 years ago
Requesting blocker for b2, this is a really annoying bug.
Flags: blocking-seamonkey2.0b2?

Comment 6

8 years ago
Not blocking a beta on this, bookmarks still can be added via the menus. Blocking final sounds reasonable though, marking that.
Flags: blocking-seamonkey2.0b2?
Flags: blocking-seamonkey2.0b2-
Flags: blocking-seamonkey2.0?
Flags: blocking-seamonkey2.0+

Comment 7

8 years ago
Don't know if this is related, but using the menu bar > bookmarks > bookmark this page, and/or right click page > bookmark this page does not work correctly. No options are given as to where to place the bookmark. It is placed generically and not in personal toolbar as previously.  It can only be found by clicking menu bar > bookmarks dropdown. 

See image here: http://i27.tinypic.com/2whgspx.jpg

Comment 8

8 years ago
Ooops. forgot build ID for above..

Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.4pre) Gecko/20090905 SeaMonkey/2.0pre - Build ID: 20090905005746

Comment 9

8 years ago
(In reply to comment #7)
> Don't know if this is related, but using the menu bar > bookmarks > bookmark
> this page, and/or right click page > bookmark this page does not work
> correctly. No options are given as to where to place the bookmark. It is placed
> generically and not in personal toolbar as previously.  It can only be found by
> clicking menu bar > bookmarks dropdown.

That's intended functionality. Only drag&drop or "File Bookmark..." can place items in the personal toolbar.

Comment 10

8 years ago
OK. Thanks for the clarification, Robert.
(Assignee)

Comment 11

8 years ago
(In reply to comment #7)
> No options are given as to where to place the bookmark.
Open the Bookmarks Manager, then choose the desired folder and select
View - Set as New Bookmark Folder.
(Assignee)

Comment 12

8 years ago
Pushed changeset 5cd46484def2 to comm-central.
Status: ASSIGNED → RESOLVED
Last Resolved: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.0
Attachment #398689 - Attachment description: Emulate old behaviour → Emulate old behaviour [Checkin: See comment 12]
Keywords: fixed-seamonkey2.0

Updated

8 years ago
Duplicate of this bug: 518640

Comment 14

8 years ago
I still have this problem in Build identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090903 SeaMonkey/2.0b2

I do not see a plain 2.0 for download that says it's fixed. so I'm confused where is 2.0  not the beta version that has this problem fixed?

Comment 15

8 years ago
roman, it's fixed in current nightly versions that are on the way to 2.0 final, and so it will be fixed in the real 2.0 when it actually appears.

Updated

8 years ago
Duplicate of this bug: 521226
You need to log in before you can comment on or make changes to this bug.