Closed Bug 51507 Opened 20 years ago Closed 19 years ago

"Netscape" appears warning dialog for invalid prefs.js

Categories

(Core :: Preferences: Backend, defect, P3)

defect

Tracking

()

VERIFIED FIXED
mozilla0.9.2

People

(Reporter: bugzilla, Assigned: bnesse)

References

Details

(Whiteboard: [r] [sr] [a] trunk only)

Attachments

(2 files)

If you have a prefs.js with errors, like this one:

# Mozilla User Preferences
// This is a generated file!
[c:\]moz -CreateProfile "gemal c:\temp"

you're presented with an error when you startup Mozilla:
"Netscape -- JS Preference Warning
bla bla bla..."

the name "Netscape" should be replace with ProductName so that it will be 
Mozilla in Mozilla and Netscape in Netscape...

http://lxr.mozilla.org/mozilla/search?string=%22netscape+-
Blocks: 14532
Summary: "Netscape" appear in Mozilla warning text → "Netscape" appears warning dialog for invalid prefs.js
Status: NEW → ASSIGNED
Keywords: mozilla1.0
I think Brian owns prefs now. I know I don't
Assignee: dveditz → bnesse
Status: ASSIGNED → NEW
This could potentially come up in two places:
http://lxr.mozilla.org/mozilla/source/modules/libhook/src/hk_file.c#139
or
http://lxr.mozilla.org/mozilla/source/modules/libpref/src/prefapi.c#1971

The first case is Windows only, the second case would be on all platforms. In
either case it is a hard coded string in the title of a platform specific dialog.
Keywords: patch, review
OS: Windows 2000 → All
Hardware: PC → All
So, after a little investigation, it seems that the culprit is:
http://lxr.mozilla.org/mozilla/source/modules/libpref/src/prefapi.c#1971

The suggested patch ends up patching code which is #ifdefed out of Mozilla.

I propose the following patch instead which only touches the offending code and 
also fixes control characters on the Mac which get printed as blocks in the 
dialog.

Eventually this dialog should go away entirely (as per alecf), but this seems to 
be an easy stop gap measure.
r=timeless get rid of it. [I should probably find out why i hit this code 
block, but ...]
Keywords: reviewapproval
argh! this accursed box. sr=alecf.
Is there a bug about getting rid of this?
There is bug 76564 which refers to the autoconfig module, but is really
applicable to all preferences.
Setting target to 0.9.2 as I seriously doubt this will be considered a 0.9.1
blocker.
Target Milestone: --- → mozilla0.9.2
Whiteboard: [r] [sr] [need drivers approval]
Blocks: 83989
a=dbaron for trunk checkin (on behalf of drivers)
Whiteboard: [r] [sr] [need drivers approval] → [r] [sr] [a]
Fix checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [r] [sr] [a] → [r] [sr] [a] trunk only
tested with a linux debug from 6/14: no longer see specific product reference [i
used henrik's erroneous -CreateProfile line].

vrfy fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.