"Netscape" appears warning dialog for invalid prefs.js

VERIFIED FIXED in mozilla0.9.2

Status

()

Core
Preferences: Backend
P3
normal
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Henrik Gemal, Assigned: Brian Nesse (gone))

Tracking

Trunk
mozilla0.9.2
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [r] [sr] [a] trunk only)

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
If you have a prefs.js with errors, like this one:

# Mozilla User Preferences
// This is a generated file!
[c:\]moz -CreateProfile "gemal c:\temp"

you're presented with an error when you startup Mozilla:
"Netscape -- JS Preference Warning
bla bla bla..."

the name "Netscape" should be replace with ProductName so that it will be 
Mozilla in Mozilla and Netscape in Netscape...

http://lxr.mozilla.org/mozilla/search?string=%22netscape+-

Updated

18 years ago
Blocks: 14532

Updated

18 years ago
Summary: "Netscape" appear in Mozilla warning text → "Netscape" appears warning dialog for invalid prefs.js
Status: NEW → ASSIGNED
Keywords: mozilla1.0
I think Brian owns prefs now. I know I don't
Assignee: dveditz → bnesse
Status: ASSIGNED → NEW
(Assignee)

Comment 2

17 years ago
This could potentially come up in two places:
http://lxr.mozilla.org/mozilla/source/modules/libhook/src/hk_file.c#139
or
http://lxr.mozilla.org/mozilla/source/modules/libpref/src/prefapi.c#1971

The first case is Windows only, the second case would be on all platforms. In
either case it is a hard coded string in the title of a platform specific dialog.
(Reporter)

Comment 3

17 years ago
Created attachment 33498 [details] [diff] [review]
diff to remove "Netscape" brandname. The easy fix... (untested)
(Reporter)

Updated

17 years ago
Keywords: patch, review
OS: Windows 2000 → All
Hardware: PC → All
(Assignee)

Comment 4

17 years ago
So, after a little investigation, it seems that the culprit is:
http://lxr.mozilla.org/mozilla/source/modules/libpref/src/prefapi.c#1971

The suggested patch ends up patching code which is #ifdefed out of Mozilla.

I propose the following patch instead which only touches the offending code and 
also fixes control characters on the Mac which get printed as blocks in the 
dialog.

Eventually this dialog should go away entirely (as per alecf), but this seems to 
be an easy stop gap measure.
(Assignee)

Comment 5

17 years ago
Created attachment 33544 [details] [diff] [review]
New proposed patch.

Comment 6

17 years ago
r=timeless get rid of it. [I should probably find out why i hit this code 
block, but ...]
Keywords: review → approval

Comment 7

17 years ago
argh! this accursed box. sr=alecf.
Is there a bug about getting rid of this?
(Assignee)

Comment 8

17 years ago
There is bug 76564 which refers to the autoconfig module, but is really
applicable to all preferences.
(Assignee)

Comment 9

17 years ago
Setting target to 0.9.2 as I seriously doubt this will be considered a 0.9.1
blocker.
Target Milestone: --- → mozilla0.9.2
(Assignee)

Updated

17 years ago
Whiteboard: [r] [sr] [need drivers approval]

Updated

17 years ago
Blocks: 83989
a=dbaron for trunk checkin (on behalf of drivers)
Whiteboard: [r] [sr] [need drivers approval] → [r] [sr] [a]
(Assignee)

Comment 11

17 years ago
Fix checked in.
Status: NEW → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED
Whiteboard: [r] [sr] [a] → [r] [sr] [a] trunk only
tested with a linux debug from 6/14: no longer see specific product reference [i
used henrik's erroneous -CreateProfile line].

vrfy fixed.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.