Closed
Bug 514310
Opened 15 years ago
Closed 15 years ago
browserDOMWindow.openURI should always pass the referrer to loadOneTab and avoid loading about:blank if possible
Categories
(Firefox :: General, defect, P1)
Firefox
General
Tracking
()
VERIFIED
FIXED
Firefox 3.7a1
| Tracking | Status | |
|---|---|---|
| status1.9.2 | --- | beta1-fixed |
People
(Reporter: dao, Assigned: dao)
References
Details
(Keywords: verified1.9.2)
Attachments
(1 file)
|
4.81 KB,
patch
|
asaf
:
review+
|
Details | Diff | Splinter Review |
Also, it needs some serious cleanup.
Attachment #398266 -
Flags: review?(gavin.sharp)
|
Assignee | |
Updated•15 years ago
|
Attachment #398266 -
Flags: review?(mconnor)
|
||
Comment 3•15 years ago
|
||
This patch works well for me. Produces expected behaviour with window.open and target="_blank". Weird that the referrer wasn't passed in the new window case.
|
||
Updated•15 years ago
|
Flags: in-testsuite?
|
||
Comment 4•15 years ago
|
||
Comment on attachment 398266 [details] [diff] [review]
patch
r=mano
Attachment #398266 -
Flags: review?(mconnor)
Attachment #398266 -
Flags: review?(gavin.sharp)
Attachment #398266 -
Flags: review+
|
|
Assignee | |
Comment 5•15 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
|
|
Assignee | |
Updated•15 years ago
|
Attachment #398266 -
Flags: approval1.9.2?
|
||
Comment 6•15 years ago
|
||
Could this bug have caused bug 515420 ?
|
|
Assignee | |
Comment 7•15 years ago
|
||
I don't think so, but I also don't know what YASS is doing.
|
||
Updated•15 years ago
|
Flags: wanted-firefox3.6?
Flags: blocking-firefox3.6?
|
||
Comment 8•15 years ago
|
||
We're changing the tab behaviour in 3.6 and we want beta feedback on it - having the tab behaviour inconsistent depending on the link type will hurt our ability to gather that feedback. This needs to land for the beta.
Flags: blocking-firefox3.6? → blocking-firefox3.6+
Priority: -- → P1
Whiteboard: [needs-192-landing]
|
|
Assignee | |
Updated•15 years ago
|
Attachment #398266 -
Flags: approval1.9.2?
|
|
Assignee | |
Updated•15 years ago
|
Flags: wanted-firefox3.6?
|
||
Comment 9•15 years ago
|
||
status1.9.2:
--- → beta1-fixed
Whiteboard: [needs-192-landing]
|
|
||
Comment 10•15 years ago
|
||
A referrer is getting sent correctly for links but not for selected text (like with Search Google for...).
Verified fixed on trunk and 1.9.2 with:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091221 Minefield/3.7a1pre ID:20091221034526
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b6pre) Gecko/20091217 Namoroka/3.6b6pre ID:20091217033725
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
You need to log in
before you can comment on or make changes to this bug.
Description
•