browserDOMWindow.openURI should always pass the referrer to loadOneTab and avoid loading about:blank if possible

VERIFIED FIXED in Firefox 3.7a1

Status

()

defect
P1
normal
VERIFIED FIXED
10 years ago
9 years ago

People

(Reporter: dao, Assigned: dao)

Tracking

({verified1.9.2})

Trunk
Firefox 3.7a1
Points:
---
Dependency tree / graph
Bug Flags:
blocking-firefox3.6 +
in-testsuite ?

Firefox Tracking Flags

(status1.9.2 beta1-fixed)

Details

Attachments

(1 attachment)

Posted patch patchSplinter Review
Also, it needs some serious cleanup.
Attachment #398266 - Flags: review?(gavin.sharp)
Duplicate of this bug: 514794
Duplicate of this bug: 514836
Attachment #398266 - Flags: review?(mconnor)
This patch works well for me. Produces expected behaviour with window.open and target="_blank". Weird that the referrer wasn't passed in the new window case.
Comment on attachment 398266 [details] [diff] [review]
patch

r=mano
Attachment #398266 - Flags: review?(mconnor)
Attachment #398266 - Flags: review?(gavin.sharp)
Attachment #398266 - Flags: review+
http://hg.mozilla.org/mozilla-central/rev/d05dc3d31c75
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3.7a1
Attachment #398266 - Flags: approval1.9.2?
Could this bug have caused bug 515420 ?
I don't think so, but I also don't know what YASS is doing.
No longer depends on: 515420
Flags: wanted-firefox3.6?
Flags: blocking-firefox3.6?
We're changing the tab behaviour in 3.6 and we want beta feedback on it - having the tab behaviour inconsistent depending on the link type will hurt our ability to gather that feedback. This needs to land for the beta.
Flags: blocking-firefox3.6? → blocking-firefox3.6+
Priority: -- → P1
Whiteboard: [needs-192-landing]
Attachment #398266 - Flags: approval1.9.2?
Flags: wanted-firefox3.6?
A referrer is getting sent correctly for links but not for selected text (like with Search Google for...).

Verified fixed on trunk and 1.9.2 with:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.3a1pre) Gecko/20091221 Minefield/3.7a1pre ID:20091221034526

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9.2b6pre) Gecko/20091217 Namoroka/3.6b6pre ID:20091217033725
Status: RESOLVED → VERIFIED
Keywords: verified1.9.2
Depends on: 537474
You need to log in before you can comment on or make changes to this bug.