If you do a search that returns a set with facets w/ more than 8 values, we display a clickable link that says "List all N" (where N is some number). It looks ugly, should be styled.
possibly somewhat outside the scope of this bug, but what about not showing a button as all, but instead just showing more content automatically? http://humanized.com/weblog/2006/04/25/no_more_more_pages/ "Don’t force the user to ask for more content: just give it to them."
I think it could be a good idea to style it as a native button, will cook up a patch.
As a temporary measure just for b4, we're going to push out minimal changes as described in the first patch of bug 515801 (discussion which should have happened here, sorry)
more to come soonish, but this can land in the mean time
you gotta move quickly in these days running up to code freeze :)
Attachment #400104 - Attachment is obsolete: true
makes "Show all" and relevance/date hover effects work properly as well.
and here is yet another update
I've made some slight updates to the patch. The patch as was submitted looked good but I made a few changes to it. I'm going to ask David for review since he's the only other one who knows this area well.
The patch didn't apply cleanly on my tree. I did a manual tweak, and it mostly works for me. On the mac, though, the bold text for .facet-more classes is too bold, too hard to read. Does it look ok w/ a normal weight?
Assignee: nobody → nisses.mail
One other comment: the blue subject text on grey background when hovering over a message actually decreases the contrast, which feels off. Maybe a darker shade of blue? Maybe a lighter background? Maybe a more sophisticated border with a very light background?
(In reply to comment #11) > The patch didn't apply cleanly on my tree. Strange I pulled the latest source before making that patch > I did a manual tweak, and it mostly works for me. On the mac, though, the bold > text for .facet-more classes is too bold, too hard to read. Does it look ok w/ > a normal weight? we could tone that down to a normal font weight.
(In reply to comment #12) > One other comment: the blue subject text on grey background when hovering over > a message actually decreases the contrast, which feels off. Maybe a darker > shade of blue? Maybe a lighter background? Maybe a more sophisticated border > with a very light background? Agreed. Maybe we can address the results list in a separate bug though. Easily arguable that the result list is more important but this bug seemed more overall to me.
with a non-bold .facet-more, a new bug for the results list, and a patch that applies cleanly on the real tree (mine doesn't matter ;-) r=davida.
and opened Bug 516261 about further improving the search results
Whiteboard: [no l10n impact] → [no l10n impact][ready for checkin]
Attachment #400365 - Flags: approval-thunderbird3?
Attachment #400365 - Flags: approval-thunderbird3? → approval-thunderbird3+
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
Whiteboard: [no l10n impact][ready for checkin] → [no l10n impact]
Target Milestone: --- → Thunderbird 3.0b4
Component: Mail Window Front End → Search
QA Contact: front-end → search
You need to log in before you can comment on or make changes to this bug.