515653 - [faceted search]: styling needed for "List all N"

Status: RESOLVED FIXED

(Thunderbird :: Search, defect)

Description

[David Ascher (:davida)]

If you do a search that returns a set with facets w/ more than 8 values, we display a clickable link that says "List all N" (where N is some number).

It looks ugly, should be styled.

Comment 1

[Andreas Nilsson (:andreasn)]

possibly somewhat outside the scope of this bug, but what about not showing a button as all, but instead just showing more content automatically?
http://humanized.com/weblog/2006/04/25/no_more_more_pages/

"Don’t force the user to ask for more content: just give it to them."

Comment 2

[Andreas Nilsson (:andreasn)]

I think it could be a good idea to style it as a native button, will cook up a patch.

Comment 3

[Andreas Nilsson (:andreasn)]

Attachment: mockup of button

The other option we could do is this kind of flat-button appearance.
Gray on regular, blue on hover (with hand pointer), slightly rounded.
I think we should use these kind of buttons in other places of the facets interface too (like the show-more-people, show all as list, sort order etc.)

Comment 4

[Andreas Nilsson (:andreasn)]

Attachment: some examples of other widgets

Trying to look at this on a wider scale, here is what we could do for the other widgets.

Comment 5

[David Ascher (:davida)]

As a temporary measure just for b4, we're going to push out minimal changes as described in the first patch of bug 515801 (discussion which should have happened here, sorry)

Comment 6

[Andreas Nilsson (:andreasn)]

Attachment: some buttons fixes

more to come soonish, but this can land in the mean time

Comment 7

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: caught by some bitrot

you gotta move quickly in these days running up to code freeze :)

Comment 8

[Andreas Nilsson (:andreasn)]

Attachment: updated patch with some more stuff

makes "Show all" and relevance/date hover effects work properly as well.

Comment 9

[Andreas Nilsson (:andreasn)]

Attachment: and some even more changes

and here is yet another update

Comment 10

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: slight updates to andreas' patch

I've made some slight updates to the patch.  The patch as was submitted looked good but I made a few changes to it.  I'm going to ask David for review since he's the only other one who knows this area well.

Comment 11

[David Ascher (:davida)]

The patch didn't apply cleanly on my tree.

I did a manual tweak, and it mostly works for me.  On the mac, though, the bold text for .facet-more classes is too bold, too hard to read.  Does it look ok w/ a normal weight?

Comment 12

[David Ascher (:davida)]

One other comment: the blue subject text on grey background when hovering over a message actually decreases the contrast, which feels off.   Maybe a darker shade of blue?  Maybe a lighter background? Maybe a more sophisticated border with a very light background?

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #11)
> The patch didn't apply cleanly on my tree.

Strange I pulled the latest source before making that patch
 
> I did a manual tweak, and it mostly works for me.  On the mac, though, the bold
> text for .facet-more classes is too bold, too hard to read.  Does it look ok w/
> a normal weight?

we could tone that down to a normal font weight.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #12)
> One other comment: the blue subject text on grey background when hovering over
> a message actually decreases the contrast, which feels off.   Maybe a darker
> shade of blue?  Maybe a lighter background? Maybe a more sophisticated border
> with a very light background?

Agreed. Maybe we can address the results list in a separate bug though. Easily arguable that the result list is more important but this bug seemed more overall to me.

Comment 15

[David Ascher (:davida)]

with a non-bold .facet-more, a new bug for the results list, and a patch that applies cleanly on the real tree (mine doesn't matter ;-) r=davida.

Comment 16

[Andreas Nilsson (:andreasn)]

Attachment: patch with normal font-weight

Comment 17

[Andreas Nilsson (:andreasn)]

and opened Bug 516261 about further improving the search results

Comment 18

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/346b3de0d125