[faceted search]: styling needed for "List all N"

RESOLVED FIXED in Thunderbird 3.0b4

Status

RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: davida, Assigned: andreasn)

Tracking

Trunk
Thunderbird 3.0b4
Bug Flags:
blocking-thunderbird3 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [no l10n impact])

Attachments

(3 attachments, 5 obsolete attachments)

(Reporter)

Description

10 years ago
If you do a search that returns a set with facets w/ more than 8 values, we display a clickable link that says "List all N" (where N is some number).

It looks ugly, should be styled.
Flags: blocking-thunderbird3+
Whiteboard: [no l10n impact]
(Assignee)

Comment 1

10 years ago
possibly somewhat outside the scope of this bug, but what about not showing a button as all, but instead just showing more content automatically?
http://humanized.com/weblog/2006/04/25/no_more_more_pages/

"Don’t force the user to ask for more content: just give it to them."
(Assignee)

Comment 2

10 years ago
I think it could be a good idea to style it as a native button, will cook up a patch.
(Assignee)

Comment 3

10 years ago
Posted image mockup of button
The other option we could do is this kind of flat-button appearance.
Gray on regular, blue on hover (with hand pointer), slightly rounded.
I think we should use these kind of buttons in other places of the facets interface too (like the show-more-people, show all as list, sort order etc.)
(Assignee)

Comment 4

10 years ago
Trying to look at this on a wider scale, here is what we could do for the other widgets.
(Reporter)

Comment 5

10 years ago
As a temporary measure just for b4, we're going to push out minimal changes as described in the first patch of bug 515801 (discussion which should have happened here, sorry)
(Assignee)

Comment 6

10 years ago
Posted patch some buttons fixes (obsolete) — Splinter Review
more to come soonish, but this can land in the mean time
Posted patch caught by some bitrot (obsolete) — Splinter Review
you gotta move quickly in these days running up to code freeze :)
Attachment #400104 - Attachment is obsolete: true
(Assignee)

Comment 8

10 years ago
makes "Show all" and relevance/date hover effects work properly as well.
(Assignee)

Updated

10 years ago
Attachment #400152 - Flags: ui-review?(clarkbw)
Attachment #400152 - Flags: review?(clarkbw)
(Assignee)

Comment 9

10 years ago
Posted patch and some even more changes (obsolete) — Splinter Review
and here is yet another update
Attachment #400134 - Attachment is obsolete: true
Attachment #400152 - Attachment is obsolete: true
Attachment #400183 - Flags: ui-review?(clarkbw)
Attachment #400183 - Flags: review?(clarkbw)
Attachment #400152 - Flags: ui-review?(clarkbw)
Attachment #400152 - Flags: review?(clarkbw)
I've made some slight updates to the patch.  The patch as was submitted looked good but I made a few changes to it.  I'm going to ask David for review since he's the only other one who knows this area well.
Attachment #400183 - Attachment is obsolete: true
Attachment #400214 - Flags: review?(david.ascher)
Attachment #400183 - Flags: ui-review?(clarkbw)
Attachment #400183 - Flags: review?(clarkbw)
(Reporter)

Comment 11

10 years ago
The patch didn't apply cleanly on my tree.

I did a manual tweak, and it mostly works for me.  On the mac, though, the bold text for .facet-more classes is too bold, too hard to read.  Does it look ok w/ a normal weight?
Assignee: nobody → nisses.mail
(Reporter)

Comment 12

10 years ago
One other comment: the blue subject text on grey background when hovering over a message actually decreases the contrast, which feels off.   Maybe a darker shade of blue?  Maybe a lighter background? Maybe a more sophisticated border with a very light background?
(In reply to comment #11)
> The patch didn't apply cleanly on my tree.

Strange I pulled the latest source before making that patch
 
> I did a manual tweak, and it mostly works for me.  On the mac, though, the bold
> text for .facet-more classes is too bold, too hard to read.  Does it look ok w/
> a normal weight?

we could tone that down to a normal font weight.
(In reply to comment #12)
> One other comment: the blue subject text on grey background when hovering over
> a message actually decreases the contrast, which feels off.   Maybe a darker
> shade of blue?  Maybe a lighter background? Maybe a more sophisticated border
> with a very light background?

Agreed. Maybe we can address the results list in a separate bug though. Easily arguable that the result list is more important but this bug seemed more overall to me.
(Reporter)

Comment 15

10 years ago
with a non-bold .facet-more, a new bug for the results list, and a patch that applies cleanly on the real tree (mine doesn't matter ;-) r=davida.
(Assignee)

Comment 16

10 years ago
Attachment #400214 - Attachment is obsolete: true
Attachment #400365 - Flags: ui-review+
Attachment #400365 - Flags: review+
Attachment #400214 - Flags: review?(david.ascher)
(Assignee)

Comment 17

10 years ago
and opened Bug 516261 about further improving the search results
(Reporter)

Updated

10 years ago
Keywords: checkin-needed
Whiteboard: [no l10n impact] → [no l10n impact][ready for checkin]
(Reporter)

Updated

10 years ago
Attachment #400365 - Flags: approval-thunderbird3?
Attachment #400365 - Flags: approval-thunderbird3? → approval-thunderbird3+
Checked in: http://hg.mozilla.org/comm-central/rev/346b3de0d125
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Whiteboard: [no l10n impact][ready for checkin] → [no l10n impact]
Target Milestone: --- → Thunderbird 3.0b4

Updated

10 years ago
Component: Mail Window Front End → Search
QA Contact: front-end → search
Depends on: 519116
You need to log in before you can comment on or make changes to this bug.