515729 - Message Header View needs vertical space saving Digital Signing indicator

Status: RESOLVED FIXED

(Thunderbird :: Message Reader UI, defect)

Description

[Ronald Killmer]

On Stating the shredder Beta4pre build (Gecko/20090910 Shredder/3.0b4pre) and viewing a test message that was digitaly signed I did not see the Digitaly Signed notifier at the reight side of the Message Header View.

Rather I saw a twisted gray and red ribbon button running the full width of the message view. This was appeared to be inserted between the Header and Message views and was discovered to be a click able button. Onclick it did the same function as the old notifier.

The issue is this new notifier is consuming valuable vertical view space and a more space conserving alternate is prefered.

Comment 1

[Mark Banner (:standard8)]

Please can you attach a screenshot. If it is different to what it was before, a screenshot showing before would be useful as well.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

I had worked on bug 464106 which sounds similar, see screenshot in attachment 375727 [details]

Comment 3

[Richard Marti (:Paenglab)]

Attachment: Image showing the difference between 0909 and 0910 builds

Comment 4

[Ludovic Hirlimann [:Usul]]

This is also present on the mac.

Comment 5

[Mark Banner (:standard8)]

I bet this is a regression from Dan's changes in bug 499410

Comment 6

[David Ascher (:davida)]

we're not using the severity field to track blockers, but granting blocking flag.

Comment 7

[Ronald Killmer]

The screen shots in Comment #3 show the change well, tho old icons are a bit different with Windows.

While addressing this, if the old location is restored, I suggest removal of the spacers above and below the icons so they will float upward. With cases of Headers All the Icon is not shown till headers are scrolled. The new thing dealt with that case but with an expense Netbook users will have more problems with.

Comment 8

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: WIP smime header patch

this moves the SMIME header over next to the date.  (as of now the date is just under the header buttons, see bug 514452)

I don't have an encypted email or an encrypted + signed email to test with so all I've seen this working with is signed messages... on windows Vista.

screenshot to follow

Comment 9

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of the smime header on Vista

here's the screenshot of the change. Note that I'm using the small icon because the large icon makes the entire header increase in size dramatically.

I think this might be a good interum fix for the b4 time frame.  Post b4 I'd actually suggest using the small icon + text to describe the security status.  Perhaps on it's own header row.

e.g.
    from : me
 subject : security
      to : you
security : (s) signed  (e) encrypted

Comment 10

[Ronald Killmer]

I see an advantage from this solution. The method using a collapsed Col to contain the signed status icon caused flex of the header containing Col. Placement of the icon display field within the header col stabilizes the display.

Comment 11

[IU]

This bug also affects the Display Mail User Agent extension in the same manner as the second set of screenshots in the first attachment (i.e. super stretched images).  Will the patch fix that too?

Here's a link to the extension: https://addons.mozilla.org/en-US/thunderbird/addon/562

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Looking at the screenshots of that extension it seems as though height usage is not a concern.  That extension will need to be updated to use the "otherActionsBox" as it's id but otherwise could work just like it already does.

The current patch here likely won't fix that extension though it could use the code to try a similar route.

Comment 13

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: screenshot of the large icon smime (on linux)

just for comparison here's what the large icon smime looks like.  As you can see in the top screenshot it causes a blank vertical line in the header which in the bottom screenshot gets used by the cc line.

Comment 14

[Bryan Clark (DevTools PM) [:clarkbw]]

Attachment: updated smime header patch

Here's a patch that continues to use the large icon.  The removes the need for theme changes and as you can see from the attachment 400599 [details] it only adds a single line in the smallest header case.

The align="top" is what gets rid of the icon stretch as you see in the last screenshot and keeps the icon aligned correctly with the date.

I still haven't been able to test this with a message that is signed and encrypted so hopefully this works for those people.

Comment 15

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 400606 [details] [diff] [review]
updated smime header patch

r=dmose, but the align="top" should go on the master copy of dateValueBox rather than overlay (as written, it's likely to be confusing to folks noticing the difference between the master copy and what DOMi shows).

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

Attachment: patch, v3

updated version of the updated patch

Comment 17

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/77d79dc4ef45

Comment 18

[Robert Kaiser]

This change broke SeaMonkey's header view completely, see bug 516679 - the file in mailnews/ is shared code. That's why it is in mailnews/ after all.

Comment 20

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 400612 [details] [diff] [review]
patch, v3

>           <!-- perhaps this should be a customizable toolbar too -->
>           <vbox id="otherActionsBox" align="end">
>-            <hbox id="dateValueBox" flex="1">  <!--For extensions-->
>+            <hbox id="dateValueBox" align="top" flex="1">  <!--For extensions-->

This is my fault for introducing a mix up between css vertical align and the XUL align attribute.  There is no align="top" but instead align="start" which I believe is the default.  The current align="top" works because it simply destroys the inheritance of align="end" it was receiving.  We should fix this to be align="start" in a follow up patch.

https://developer.mozilla.org/en/XUL%3aAttribute%3aalign