[mozmill] Test for installing an extension

RESOLVED FIXED

Status

RESOLVED FIXED
9 years ago
8 years ago

People

(Reporter: whimboo, Assigned: whimboo)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

9 years ago
This bug will cover the work to create a Mozmill test to check add-on installation.

https://litmus.mozilla.org/show_test.cgi?id=5929
(Assignee)

Updated

9 years ago
Depends on: 500987
(Assignee)

Comment 1

9 years ago
Created attachment 385663 [details] [diff] [review]
Patch v1

Complete test to install an extension in Firefox. The uninstall part will be completed later. Clint, can you please review so we can get the test checked-in as soon as possible? Thanks.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #385663 - Flags: review?(ctalbert)
(Assignee)

Comment 2

9 years ago
Created attachment 385664 [details] [diff] [review]
Patch v1.1

This time with qrefreshed content.
Attachment #385663 - Attachment is obsolete: true
Attachment #385664 - Flags: review?(ctalbert)
Attachment #385663 - Flags: review?(ctalbert)
(Assignee)

Updated

9 years ago
Depends on: 501027

Updated

9 years ago
Attachment #385664 - Flags: review?(ctalbert) → review+

Comment 3

9 years ago
Comment on attachment 385664 [details] [diff] [review]
Patch v1.1

r=ctalbert on the approach.  I do have a couple of questions though: Is it necessary to go through the add-ons manager for this test?  Because if the rank of Noscript changes, then your test will break.  Also, you are doing several waitForEval's using an object called "subject" but subject is never defined anywhere.  Is that defined in the utils class or something?  Where does that value come from?
(Assignee)

Comment 4

9 years ago
Yes, we should route through the Add-ons Manager. It is the only way to test the first steps of the Litmus test. But afterward we can go another sequence and open the NoScript page directly. All my following tests don't rely on NoScript, that means it will also work if another extension is installed. I made some deep thoughts over the weekend therefor.

To the waitForEval call is not really much to say. This is a function of Mozmill and subject is the last parameter of this function. That means:

controller.waitForEval("subject.length == 2", 5000, 100, controller.tabs);

is translated into controller.tabs.length into the function itself and will wait until we have two tabs open or it will fail after 5s. That's all.

Thanks for the review. I'll implement the direct open of the NoScript web page.
(Assignee)

Comment 5

9 years ago
Created attachment 385782 [details] [diff] [review]
Patch v2

This is an updated test which installs the Adblock extension and checks for its existence in the second run.
Attachment #385664 - Attachment is obsolete: true
Attachment #385782 - Flags: review+
(Assignee)

Comment 6

9 years ago
Checked in as http://hg.mozilla.org/qa/mozmill-tests/rev/df0fde87ea90
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED

Comment 7

9 years ago
(In reply to comment #4)
> 
> To the waitForEval call is not really much to say. This is a function of
> Mozmill and subject is the last parameter of this function. That means:
> 
> controller.waitForEval("subject.length == 2", 5000, 100, controller.tabs);
> 
> is translated into controller.tabs.length into the function itself and will
> wait until we have two tabs open or it will fail after 5s. That's all.
Ah yes, I remember that functionality now.  I think you might be the first person to use it. :)
(Assignee)

Comment 8

9 years ago
No, I've already used it in on of my first test too (Adding a bookmark to the Bookmarks menu):
http://hg.mozilla.org/qa/mozmill-tests/rev/e583d3079dad
(Assignee)

Updated

9 years ago
Depends on: 516729
(Assignee)

Comment 9

8 years ago
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Add-ons Manager → Mozmill Tests
Product: Toolkit → Mozilla QA
QA Contact: add-ons.manager → mozmill-tests
Version: 1.9.1 Branch → unspecified
You need to log in before you can comment on or make changes to this bug.