Closed Bug 500419 Opened 14 years ago Closed 14 years ago

[mozmill] Test for installing an extension

Categories

(Mozilla QA Graveyard :: Mozmill Tests, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: whimboo, Assigned: whimboo)

References

()

Details

Attachments

(1 file, 2 obsolete files)

This bug will cover the work to create a Mozmill test to check add-on installation.

https://litmus.mozilla.org/show_test.cgi?id=5929
Depends on: 500987
Attached patch Patch v1 (obsolete) — Splinter Review
Complete test to install an extension in Firefox. The uninstall part will be completed later. Clint, can you please review so we can get the test checked-in as soon as possible? Thanks.
Assignee: nobody → hskupin
Status: NEW → ASSIGNED
Attachment #385663 - Flags: review?(ctalbert)
Attached patch Patch v1.1 (obsolete) — Splinter Review
This time with qrefreshed content.
Attachment #385663 - Attachment is obsolete: true
Attachment #385664 - Flags: review?(ctalbert)
Attachment #385663 - Flags: review?(ctalbert)
Depends on: 501027
Attachment #385664 - Flags: review?(ctalbert) → review+
Comment on attachment 385664 [details] [diff] [review]
Patch v1.1

r=ctalbert on the approach.  I do have a couple of questions though: Is it necessary to go through the add-ons manager for this test?  Because if the rank of Noscript changes, then your test will break.  Also, you are doing several waitForEval's using an object called "subject" but subject is never defined anywhere.  Is that defined in the utils class or something?  Where does that value come from?
Yes, we should route through the Add-ons Manager. It is the only way to test the first steps of the Litmus test. But afterward we can go another sequence and open the NoScript page directly. All my following tests don't rely on NoScript, that means it will also work if another extension is installed. I made some deep thoughts over the weekend therefor.

To the waitForEval call is not really much to say. This is a function of Mozmill and subject is the last parameter of this function. That means:

controller.waitForEval("subject.length == 2", 5000, 100, controller.tabs);

is translated into controller.tabs.length into the function itself and will wait until we have two tabs open or it will fail after 5s. That's all.

Thanks for the review. I'll implement the direct open of the NoScript web page.
Attached patch Patch v2Splinter Review
This is an updated test which installs the Adblock extension and checks for its existence in the second run.
Attachment #385664 - Attachment is obsolete: true
Attachment #385782 - Flags: review+
Checked in as http://hg.mozilla.org/qa/mozmill-tests/rev/df0fde87ea90
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
(In reply to comment #4)
> 
> To the waitForEval call is not really much to say. This is a function of
> Mozmill and subject is the last parameter of this function. That means:
> 
> controller.waitForEval("subject.length == 2", 5000, 100, controller.tabs);
> 
> is translated into controller.tabs.length into the function itself and will
> wait until we have two tabs open or it will fail after 5s. That's all.
Ah yes, I remember that functionality now.  I think you might be the first person to use it. :)
No, I've already used it in on of my first test too (Adding a bookmark to the Bookmarks menu):
http://hg.mozilla.org/qa/mozmill-tests/rev/e583d3079dad
Depends on: 516729
Mass move of Mozmill Test related project bugs to newly created components. You can filter out those emails by using "Mozmill-Tests-to-MozillaQA" as criteria.
Component: Add-ons Manager → Mozmill Tests
Product: Toolkit → Mozilla QA
QA Contact: add-ons.manager → mozmill-tests
Version: 1.9.1 Branch → unspecified
Product: Mozilla QA → Mozilla QA Graveyard
You need to log in before you can comment on or make changes to this bug.