Closed
Bug 517087
Opened 15 years ago
Closed 15 years ago
Message tabs/windows without a backing view shouldn't depend on the message's folder to provide the view
Categories
(Thunderbird :: Mail Window Front End, defect)
Thunderbird
Mail Window Front End
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 3.0rc1
People
(Reporter: rain1, Assigned: rain1)
Details
Attachments
(1 file)
18.45 KB,
patch
|
asuth
:
review+
standard8
:
approval-thunderbird3+
|
Details | Diff | Splinter Review |
If you set a filter on a particular folder, then try opening a message tab with a message not in the filtered view (say from an OS search integration result), stuff breaks.
Attachment #401123 -
Flags: review?(bugmail)
Assignee | ||
Updated•15 years ago
|
Summary: Message tabs/windows without a backing view shouldn't depend on their folder → Message tabs/windows without a backing view shouldn't depend on the message's folder to provide the view
Comment 1•15 years ago
|
||
Comment on attachment 401123 [details] [diff] [review] patch Thank you for the extensive tests. You are in a bit-rot race with Standard8 with bug 512916. He seemed to think that he was definitely going to beat any competitors, saying something about approval... Please make the following typo fix: diff --git a/mail/base/modules/MsgHdrSyntheticView.js b/mail/base/modules/MsgHdrSyntheticView.js --- a/mail/base/modules/MsgHdrSyntheticView.js +++ b/mail/base/modules/MsgHdrSyntheticView.js @@ -88,14 +88,14 @@ MsgHdrSyntheticView.prototype = { this.completionCallback = null; }, /** * Helper function used by |DBViewWrapper.getMsgHdrForMessageID|. */ getMsgHdrForMessageID: function MsgHdrSyntheticView_getMsgHdrForMessageID( aMessageId) { - if (this.msgHdr.messageId == aMsgHdr) + if (this.msgHdr.messageId == aMessageId) return this.msgHdr; return null; } };
Attachment #401123 -
Flags: review?(bugmail) → review+
Assignee | ||
Updated•15 years ago
|
Attachment #401123 -
Flags: approval-thunderbird3?
Updated•15 years ago
|
Assignee: nobody → sid.bugzilla
Assignee | ||
Updated•15 years ago
|
OS: Windows NT → All
Hardware: x86 → All
Comment 2•15 years ago
|
||
Comment on attachment 401123 [details] [diff] [review] patch a=Standard8 Though you'll have to fix the bitrot as well as I checked in the patch to move mailTabType this morning.
Attachment #401123 -
Flags: approval-thunderbird3? → approval-thunderbird3+
Assignee | ||
Comment 3•15 years ago
|
||
Yeah, bitrot fixed and pushed: http://hg.mozilla.org/comm-central/rev/26f35d27ff2f
Status: NEW → RESOLVED
Closed: 15 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0rc1
You need to log in
before you can comment on or make changes to this bug.
Description
•