517087 - Message tabs/windows without a backing view shouldn't depend on the message's folder to provide the view

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Rain [:rain1] (inactive)]

Attachment: patch

If you set a filter on a particular folder, then try opening a message tab with a message not in the filtered view (say from an OS search integration result), stuff breaks.

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 401123 [details] [diff] [review]
patch

Thank you for the extensive tests.

You are in a bit-rot race with Standard8 with bug 512916.  He seemed to think that he was definitely going to beat any competitors, saying something about approval...

Please make the following typo fix:

diff --git a/mail/base/modules/MsgHdrSyntheticView.js b/mail/base/modules/MsgHdrSyntheticView.js
--- a/mail/base/modules/MsgHdrSyntheticView.js
+++ b/mail/base/modules/MsgHdrSyntheticView.js
@@ -88,14 +88,14 @@ MsgHdrSyntheticView.prototype = {
     this.completionCallback = null;
   },
 
   /**
    * Helper function used by |DBViewWrapper.getMsgHdrForMessageID|.
    */
   getMsgHdrForMessageID: function MsgHdrSyntheticView_getMsgHdrForMessageID(
       aMessageId) {
-    if (this.msgHdr.messageId == aMsgHdr)
+    if (this.msgHdr.messageId == aMessageId)
       return this.msgHdr;
 
     return null;
   }
 };

Comment 2

[Mark Banner (:standard8) (afk until 21st July)]

Comment on attachment 401123 [details] [diff] [review]
patch

a=Standard8

Though you'll have to fix the bitrot as well as I checked in the patch to move mailTabType this morning.

Comment 3

[Rain [:rain1] (inactive)]

Yeah, bitrot fixed and pushed: http://hg.mozilla.org/comm-central/rev/26f35d27ff2f