517244 - collapsing folder pane doesn't persist tab switches

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[David Ascher (:davida)]

STR:

create two 3-pane tabs
in first tab, collapse folder pane (by dragging it shut)
switch to tab 2
switch to tab 1

-> folder pane is back.

It's annoying for people who use the folder picking widget instead of the folder pane.

I suspect it's not truly a regression as it requires tabs.  It may be a regression if the lack of persistence also happens on restart.

Comment 1

[David Ascher (:davida)]

Sid, interested in taking this one?

Comment 2

[Rain [:rain1] (inactive)]

Attachment: implement folder pane visibility persistence

This basically does for folder tabs what was done for message tabs.

I'm not too happy with the way we store _folderPaneVisible in folderDisplay, but it seems to be better than using _tabInfo for this. I'd gladly implement something better.

Not sure if asuth can review the messenger.xul bits. Phil -- the logic behind removing those is that we're now doing so explicitly.

The test is basically an adaptation of most of test-message-pane-visibility.js.

Comment 3

[Phil Ringnalda (:philor)]

Comment on attachment 401637 [details] [diff] [review]
implement folder pane visibility persistence

He can, absolutely.

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 401637 [details] [diff] [review]
implement folder pane visibility persistence

Heh, for some reason I was thinking this would be less work than it was... :)

One unfortunate situation that happens on linux is that because there is no single-click-to-collapse behavior on the splitter, I have to drag the folder pane closed.  Because the splitter's position is updated as I drag it, dragging the folder pane closed actually has 2 results:

1) The folder pane gets collapsed on the current tab.
2) The folder pane gets shrunk to its minimum size.  This affects all tabs where the pane is still visible.

#2 is obviously undesirable.  However, I think that's another bug.

Please fix the minor bit-rot on messenger.xul and land this.

Comment 6

[Rain [:rain1] (inactive)]

http://hg.mozilla.org/comm-central/rev/21d89cf4c6c0

Comment 7

[Rain [:rain1] (inactive)]

(In reply to comment #5)
> 
> 1) The folder pane gets collapsed on the current tab.
> 2) The folder pane gets shrunk to its minimum size.  This affects all tabs
> where the pane is still visible.
> 
> #2 is obviously undesirable.  However, I think that's another bug.
> 

Bug 517848 filed.