476343 - Hiding folder pane then switching to message tab and back shows folder pane

Status: RESOLVED DUPLICATE of bug 517244

(Thunderbird :: Mail Window Front End, defect)

Description

[Jeff Beckley]

Using Thunderbird 3.0b1

STR:
1. Select a folder in the folder pane
2. Drag the folder pane splitter all the way to the left so that the folder pane is hidden
3. Right-click on a message and select "Open Message in New Tab"
4. Click on the first tab

Expected results:
Folder pane remains hidden as it was after step #2

Actual results:
Folder pane is exposed with a small width

Comment 1

[Jeff Beckley]

Attachment: Suggested fix

Here's a fix for the problem.  There are two scenarios to worry about.  One is when the splitter (either folder pane or thread pane) is moved all the way to the side, and the other is when the splitter is hidden entirely (which Thunderbird doesn't do, but Penelope does).  The new code looks at the previous state of the splitter and pane, and restores is when switching between mailbox and message tabs.

This also addresses Karsten's concerns in comment 20 of bug 429440 about notifications not being sent when the message pane changes visibility.

Comment 2

[Andrew Sutherland [:asuth] (he/him)]

I'm having to straighten out a bunch of the horrible issues raised by the tab implementation in bug 474701.  I believe my most recent patch deals with this specific problem in a reasonable fashion.  Namely, we track the state of folder and message pane collapse for each tab.  When opening a new tab, we propagate the state of the 'current' tab (assuming it is a "folder" tab), or failing that, the first "folder" tab.  It makes a lot of the logic more explicit, so I think it feels like the right way to go.

That bug and patch are targeted for beta 2, so I'd just assume we make this bug depend on that one, but if you want to land this in the interim and are fine with it being clobbered, that's good too.

Comment 3

[Jeff Beckley]

(In reply to comment #2)
> but if you want to land this in the interim and are fine
> with it being clobbered, that's good too.

Yes, I'd like to see this get in, and I'm fine with it being obsoleted with your new code.

Mark, what say ye?

Comment 4

[Mark Banner (:standard8)]

Comment on attachment 360018 [details] [diff] [review]
Suggested fix

Sorry for the delay in reviewing this.

>+      tpSplitter.collapsed = (tpSplitter.getAttribute("substate")? false : true);

nit: the brackets aren't necessary, and insert a space before the ? please.

r=me with that fixed.

Comment 5

[Jeff Beckley]

Attachment: Final patch

Fixed the formatting of the conditional assignment.

Thanks for the review, Mark.

Continuing r=Standard8

Comment 6

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/a22d1919abc0

Thanks for fixing this Jeff.

Comment 7

[Pawel Pohl]

Hi guys I found this bug after encountering the exact same problem in Thunderbird 3 beta 3. If I move the folders panel all the way to the left, it will reappear after switching tabs. Does this mean this bug should be re-opened?

Comment 8

[Andrew Sutherland [:asuth] (he/him)]

Yeah, since I clobbered this bug's fix and the fix never saw an actual beta release and the STR are the same, might as well re-open this bug.

Comment 9

[Rain [:rain1] (inactive)]

OK, bug 517244 fixes this along with other issues, so I'm going to dup this to that.