Closed
Bug 517369
Opened 15 years ago
Closed 12 years ago
Is it possible to slimwrapper DOMEvent objects?
Categories
(Core :: DOM: Events, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 776864
People
(Reporter: bzbarsky, Unassigned)
References
Details
Attachments
(1 file)
20.35 KB,
patch
|
Details | Diff | Splinter Review |
This would help make event object creation faster.
Comment 1•15 years ago
|
||
We need a parent for the wrappers to be able to use slim wrappers, an object that's easily reachable from the event object and that remains the same for the lifetime of that object. As for the init methods, which did you have in mind? There's a bunch and I'm not sure all are that important to quickstub.
Comment 2•15 years ago
|
||
Does the patch work with those events which are implemented using an inner
nsDOMEvent object and forwarding most of the calls to that.
For example nsXMLHttpProgressEvent. There are also others which use the same
structure, and I believe some extensions do that too.
Reporter | ||
Comment 3•15 years ago
|
||
Yeah, the parent thin was what was worrying me. I don't have good candidates offhand. :(
AS for quickstubs, the testcase I saw was using initMouseEvent. In all seriousness, it was a somewhat silly testcases, but most of these microbenchmarks are. :(
Comment 4•15 years ago
|
||
(In reply to comment #2)
> Does the patch work with those events which are implemented using an inner
> nsDOMEvent object and forwarding most of the calls to that.
As long as they don't forward QI it should just work, yes. They won't get the benefits. If they do forward QI they might get the benefits, if they forward QI and but deal with nsISupports themselves the offset tables could be wrong I think.
Comment 5•15 years ago
|
||
Could we split this to slimwrapper and quickstub bugs?
Comment 6•15 years ago
|
||
Filed Bug 519932
Summary: Is it possible to slimwrapper DOMEvent objects and quickstub their init methods? → Is it possible to slimwrapper DOMEvent objects?
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → DUPLICATE
You need to log in
before you can comment on or make changes to this bug.
Description
•