517617 - Message filters: folder flyout selector fails to open

Status: VERIFIED FIXED

(Thunderbird :: General, defect)

Description

[MrC]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3 (.NET CLR 3.5.30729)
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090918 Shredder/3.0pre

The message filter folder selector is not expanding.  Normally, when you pull down the "Run selected filters on..." pulldown flyout, and hover over any item, the folder flyout would expand into a sub-menu (such as Inbox).  However, this is not happening on my system.  Instead, a very small square appears in the upper right corner of the highlighted selection. The square is only a few pixels wide.  It is impossible to select a folder.  I'll attach an image.

There are also other problems with the message filter dialog of late:

1) Run Now seems to have no affect.
2) the Enabled column does not position properly when the dialog is made wide, and then width decreased.  To repeat, the dialog must be longer than the number of items, so that no scrollbar appears.  Any scrollbar repainting prevents the problem from being exhibited.

Reproducible: Always

Steps to Reproduce:
1.Open Message Filters
2.Select a folder from the "Run selected filter(s) on" 
3.
Actual Results:  
Tiny square box appears, no folders to select from.

Expected Results:  
Folder list should fly out.

Comment 1

[MrC]

Attachment: Flyout failure

Run selected filter(s) on flyout problem

Comment 2

[Kent James (:rkent)]

This is the same regression as bug 517134, though probably needs another fix. More serious though. Same error console message.

Comment 3

[MrC]

Ah, yes, it appears so.  Same error:

Error: GetMsgFolderFromUri is not defined
Source File: chrome://messenger/content/folderWidgets.xml
Line: 315

I checked the filters log, but failed to check the error log.  Good catch.

Comment 4

[Ludovic Hirlimann [:Usul]]

(In reply to comment #2)
> This is the same regression as bug 517134, though probably needs another fix.
> More serious though. Same error console message.

Shall we dup them then ?

Comment 5

[MrC]

If it "needs another fix; more serious though", are they not considered different bugs?

Comment 6

[Mark Banner (:standard8)]

Obvious failure in UI elements isn't good, so blocking+.

Comment 7

[Blake Winton (:bwinton) (:☕️)]

The latest patch for Bug 516353 removes the call to GetMsgFolderFromUri, and fixes a similar problem.  It also seems to be fixed on my local copy, so if someone would like to test again after that lands, that would be awesome.

Comment 8

[Blake Winton (:bwinton) (:☕️)]

This seems fixed as of http://hg.mozilla.org/comm-central/rev/2aea95c35322 .

Comment 9

[MrC]

I changed the platform to All, since I later discovered it occured on both Win and Mac OS X.

In any event, this seems resolved now on both platforms in the 20090922 build.

And Run Now -- the #2 problem above -- also works again.  The #3 problem still fails.

Marking as Verified.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090922 Shredder/3.0pre