519133 - Newsgroup list in Message Filters Dialog has blank entry and extra separator

Status: RESOLVED WORKSFORME

(Thunderbird :: Folder and Message Lists, defect)

Description

[Ian Neal]

Steps to reproduce:
1) Configure TB with a news server and subscribe to a number of newsgroups.
2) Open Message Filters dialog from the Tools menu
3) Click on the drop down by "Filters For:"
4) Navigate to the news server configured in 1)

Expected result:
1) List of newsgroups with "choose this news server" followed by a separator at the top.

Actual result:
1) List of newsgroups with "choose this news server" followed by a separator, a blank entry and another separator at the top.

Comment 1

[Ian Neal]

The bit of code adding the blank entry and extra separator starts at http://mxr.mozilla.org/comm-central/source/mailnews/base/content/folderWidgets.xml#383
this.getAttribute("showFileHereLabel") = ""
!mode = true
this._parentFolder.noSelect = false
this._parentFolder.canFileMessages = false
mode = ""
this.hasAttribute("fileHereLabel") = true
this.getAttribute("fileHereLabel") = ""
Reading the comment at the beginning the code does not seem to quite match it, I think the brackets are wrong, it should be:
(this._parentFolder && (!mode || (this.getAttribute("showFileHereLabel") == "true")) && (this._parentFolder.noSelect || this._parentFolder.canFileMessages || mode == "newFolder"))

Comment 2

[Ian Neal]

Attachment: Change brackets patch v0.1

This patch:
* Changes the brackets in the code to match the comment (also seems to fix the issue which is good).

Comment 3

[David :Bienvenu]

Comment on attachment 403298 [details] [diff] [review]
Change brackets patch v0.1

I'll look at this.

Comment 4

[David :Bienvenu]

Comment on attachment 403298 [details] [diff] [review]
Change brackets patch v0.1

this fixes it for me as well, thx, Ian.

Comment 5

[[e-mail]]

Comment on attachment 403298 [details] [diff] [review]
Change brackets patch v0.1

So much for kill-RDF. At least templates were easy to understand; this code is a nightmare.

The "parent" folder reference and separator get added in two places. The first is if you use "expandFolders" which allows you to specify server types whose folders should be expanded; the filter list dialog uses this to expand only news servers. The second is if you use "showFileHereLabel" although the idea is that if you want to de-RDF SeaMonkey's Go menu (I don't know whether Thunderbird has an equivalent; SeaMonkey's search dialog uses the tree-based widget) then you will get the "parent" references anyway, but as their name rather than as a static label.

Unfortunately nobody bothers to propagate the "mode" attribute to nested popups, so they then think they're in the Go menu, but there's a second bug because the fileHereLabel was copied via setAttribute so they then think that they need to be blank instead of defaulting to the folder's pretty name.

Comment 6

[David :Bienvenu]

I've changed the summary to "needs new patch" based on Neil's last comment.

Comment 7

[Dan Mosedale (:dmosedale, :dmose)]

As non-pretty as this is, it's pretty obscure UI.  We wouldn't hold for it if it were the last bug standing.

Comment 9

[:aceman]

Ian, will you finish the patch? Is it still needed in current builds?

Comment 10

[Ian Neal]

(In reply to :aceman from comment #9)
> Ian, will you finish the patch? Is it still needed in current builds?

Not present in TB14 so I presume this was fixed by one of your various patches to the filter dialog -> WFM (unless you know the bug that fixed it).