519429 - Customize toolbar is broken

Status: VERIFIED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[[:Aureliano Buendía]]

Attachment: screenshot

With today build

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1.4pre) Gecko/20090929 Lightning/1.0pre Shredder/3.0pre ID:20090929031525

opening "custumize toolbar" window, no additional button is present.

When closing window clicking "done" button, main menu in TB is disable.

It is possible that this issue is related to landing of bug #509044: i have all text beside icons, but I don't have select this (see screenshot)

Comment 1

[Ludovic Hirlimann [:Usul]]

WFM on the mac. I supose the error console is empty ?

Comment 2

[[:Aureliano Buendía]]

It seems none related to this (all are related to gloda).

Here it happens also in safe-mode.

Comment 3

[Thomas Stache]

No, Error console has:
Error: document.getElementById("labelAlignToolbar") is null
Source File: chrome://messenger/content/mailCore.js
Line: 190
Error: document.getElementById("labelAlign") is null
Source File: chrome://messenger/content/mailCore.js
Line: 191
Error: window.frameElement is null
Source File: chrome://messenger/content/mailCore.js
Line: 40
Error: gToolbox is null
Source File: chrome://global/content/customizeToolbar.js
Line: 55

Comment 4

[[:Aureliano Buendía]]

(In reply to comment #3)
> No, Error console has:
> Error: document.getElementById("labelAlignToolbar") is null
> Source File: chrome://messenger/content/mailCore.js
> Line: 190
> Error: document.getElementById("labelAlign") is null
> Source File: chrome://messenger/content/mailCore.js
> Line: 191
> Error: window.frameElement is null
> Source File: chrome://messenger/content/mailCore.js
> Line: 40
> Error: gToolbox is null
> Source File: chrome://global/content/customizeToolbar.js
> Line: 55

Here no (I don't know why), but yours listed errors they seems related to this issue.

Also for you Thomas, after clicking "done" button in custumize toolbar window, main menu is disable (unusable) until restart TB?

Comment 5

[Thomas Stache]

> Also for you Thomas, after clicking "done" button in custumize toolbar window,
> main menu is disable (unusable) until restart TB?

Yes, but a workaround is to open a new 3-pane-window by invoking "Open" from a folder's context menu, e.g. the Inbox.

Comment 6

[Blake Winton (:bwinton) (:☕️)]

(In reply to comment #3)
> Error: document.getElementById("labelAlignToolbar") is null
> Error: document.getElementById("labelAlign") is null

I've fixed these.

> Error: window.frameElement is null
> Error: gToolbox is null

Which OS are you getting these on?

Thanks,
Blake.

Comment 7

[Thomas Stache]

(In reply to comment #6)
> > Error: window.frameElement is null
> > Error: gToolbox is null
> 
> Which OS are you getting these on?

Windows Vista. Am I alone in seeing these? ;)

Comment 8

[Blake Winton (:bwinton) (:☕️)]

I don't see them on OS X this morning, but I did see them at 1:00am last night, so no, you're not alone.

Until now, I didn't know what caused them.  But now I think it's OS X vs. Windows, so I've written a patch, and will test it under both, and then post it.

Thanks,
Blake.

Comment 9

[Andreas Nilsson (:andreasn)]

I see this on both Linux and Vista.

Comment 10

[Blake Winton (:bwinton) (:☕️)]

Attachment: Fix the customization of toolbars on non-OSX platforms.

And here we go.  It would be really cool to get this into tonight's build so that the localizers can see the results of translating the new "Icons beside Text" string.

I didn't make the duplicated bit of code into a function, because we only use it twice, and the occurrences are right beside each other.

Thanks,
Blake.

Comment 11

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 403496 [details] [diff] [review]
Fix the customization of toolbars on non-OSX platforms.

Stealing review from philor.  r=dmose.

Comment 12

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/7fae8af6c3b3

Comment 15

[Ronald Killmer]

My evaluation of the 09/30/2009 Windows build indicates the patch works and the Customize function is restored. I think we can mark this one Verified.