519505 - default mac to small icons in toolbar

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect, P4)

Description

[Bryan Clark (DevTools PM) [:clarkbw]]

Mac toolbar buttons have used 32x32 since the dawn of Thunderbird time and that makes the icons seem very large compared to the text.  We should change the default for Mac to use the small icons in the toolbar as it gives a cleaner look, similar size to Mail.app, where the icons are similar size to the text.

Because we're now defaulting to text beside icons in the toolbar our click target continues to be large horizontally but does shrink vertically to roughly the size of the text entry.

Comment 1

[Phil Ringnalda (:philor)]

I presume you mean "default Mac to small icons in the compose and addressbook toolbars" since we're already defaulting the 3pane to small cross-platform.

Comment 2

[Bryan Clark (DevTools PM) [:clarkbw]]

(In reply to comment #1)
> I presume you mean "default Mac to small icons in the compose and addressbook
> toolbars" since we're already defaulting the 3pane to small cross-platform.

What?  Is it seriously just my eyes or are you messing with me?

Comment 3

[Bryan Clark (DevTools PM) [:clarkbw]]

I just tried a couple different brand new profiles and did get small icons as the default.  Strangely though when I went to the customize palette the small icons option is not checked.  Once I check it and then uncheck it I get the regular size icons.  I've never seen this before though I haven't done much testing on new profiles in a while.

Comment 4

[Phil Ringnalda (:philor)]

Yeah, we're screwing up the undocumented customization API - that initially unchecked thing should be another aspect of bug 519607.

Comment 5

[Andreas Nilsson (:andreasn)]

should we make big size 24x24 and small size 16x16 on mac too perhaps?
(this requires a lot of new graphics to be drawn, but it's doable)

Comment 6

[Bryan Clark (DevTools PM) [:clarkbw]]

Tried a new profile today and had this same problem :(

Comment 7

[Blake Winton (:bwinton) (:☕️)]

Attachment: The first cut at the patch.

Okay, Bryan, I think this should make the behaviour closer to what you thought it would be.  (I didn't add new icons, cause that would have been horrible.  Really, really horrible.  ;)

I look forward to seeing what philor has to say about this patch.

Thanks,
Blake.

Comment 8

[Phil Ringnalda (:philor)]

Isn't that the patch for a different bug, "default all platforms to small icons with text-beside in all windows, even platforms where large icons are 24x24 instead of 32x32 and even windows where we aren't trying desperately to get back vertical space"?

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Attachment: A patch to just fix the Mac, and only for the main toolbar.

(In reply to comment #8)
> Isn't that the patch for a different bug, "default all platforms to small icons
> with text-beside in all windows, even platforms where large icons are 24x24
> instead of 32x32 and even windows where we aren't trying desperately to get
> back vertical space"?

Yeah, what is the bug number for that bug, anyways?  :)

Here's a patch that only changes the main toolbar, and only for OS X.

Bryan, how wide-sweeping would you like this change?  The variables, as I see them, are platform (OS X, Linux, and Windows (XP and Vista/7)), and toolbox (Main, Address Book, and Compose).

Thanks,
Blake.

Comment 10

[Phil Ringnalda (:philor)]

Whatever sizes we decide to default to in whichever windows on whatever platforms, we absolutely need to set iconsize on the toolbox rather than on one toolbar anywhere that we are going small for any platform: the different defaults and unchecked checkbox are just too confusing. Other than that, I'm going to step back until Bryan has looked at large and small in all three windows on all three platforms and decided what we really want for each.

Comment 11

[Blake Winton (:bwinton) (:☕️)]

Attachment: The latest version of the patch.

Here's a patch which implements "Icons small on Mac, large on everything else, and text-beside on all platforms, in all the windows", as per clarkbw on irc.  (Tested on Mac and Linux.)

(In reply to comment #10)
> we absolutely need to set iconsize on the toolbox rather than on one
> toolbar anywhere that we are going small for any platform:

As I understand the code, we need to set iconsize on both the toolbox and the toolbars, unless we want to change _a_lot_ of css.

> Other than that, I'm
> going to step back until Bryan has looked at large and small in all three
> windows on all three platforms and decided what we really want for each.

I don't know if he's looked at all three, so if I were you, I'ld wait for his ui-r on this patch before reviewing it.

Thanks,
Blake.

Comment 12

[Bryan Clark (DevTools PM) [:clarkbw]]

Comment on attachment 405574 [details] [diff] [review]
The latest version of the patch.

This looks good, only tested on the mac so far but everything worked as expected.

Comment 13

[Phil Ringnalda (:philor)]

Right, guess that means that Blake and I will decide what we want on other platforms :)

Comment 14

[Lint Hasenpfeffer]

As an aside here, I dropped a bug over to the adblock guy(s) regarding an icon size issue, and they said there was no way to determine the size that is used on the icons (paraphrasing), which led to (presumably) the inability to display a larger icon for the addin.

Comment 15

[Bryan Clark (DevTools PM) [:clarkbw]]

tested on linux and looks good :)

Comment 17

[Phil Ringnalda (:philor)]

http://hg.mozilla.org/comm-central/rev/01164c096e2e