519951 - Closing a contentTab leaks an nsBrowserStatusFilter and others

Status: RESOLVED FIXED

(Thunderbird :: Toolbars and Tabs, defect)

Description

[Mark Banner (:standard8)]

Attachment: The fix

I saw this on the bloat boxes the other day when I'd temporarily let the what's new page check be broken and so it was actually being shown and causing a lot of leaks.

The issue is that we're setting up a c++ instance (the nsBrowserStatusFilter) with a listener (tabProgressListener) that is holding onto the tab object (mTab et al) which is then holding onto the c++ instance.

We need to break this cycle when we close the tab - so we save the listener and then remove it later.

I would also like to enable the content tab in the bloat tests, but it appears when we switch/close the content tab back to the main 3 pane tab, we're causing a bunch of other leaks - so I'll raise a bug on following that up as well and that can be the one to enable the content tab on the leak tests.

Comment 1

[Mark Banner (:standard8)]

Checked in: http://hg.mozilla.org/comm-central/rev/d4529d3c2429