Closed Bug 519961 Opened 11 years ago Closed 11 years ago

Warning: XUL box for hbox element contained an inline img child when opening addressbook

Categories

(Thunderbird :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0rc1

People

(Reporter: vkondakoff, Assigned: philor)

References

Details

Attachments

(1 file, 1 obsolete file)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.3) Gecko/20090824 Firefox/3.5.3
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.1.4pre) Gecko/20090930 Shredder/3.0pre

Every time when opening address book there are two warnings in error console:

Warning: XUL box for hbox element contained an inline img child, forcing all its children to be wrapped in a block.
Source File: chrome://messenger/content/addressbook/addressbook.xul
Line: 0

Reproducible: Always
Duplicate of this bug: 519443
Set to minor (or better trivial?)
Severity: normal → minor
Severity: minor → normal
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows 7 → All
Hardware: x86 → All
Target Milestone: --- → Thunderbird 3.0rc1
Version: unspecified → Trunk
Attached patch Fix v.1 (obsolete) — Splinter Review
I like this a little better than the other alternative dbaron offered, to do what the code that issues the warning does and wrap an html:div around the html:img (with the slight improvement that if we do it, we can skip where it wraps the spacers, too).
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #404392 - Flags: review?(bugzilla)
Attached patch Fix v.2Splinter Review
Neil pointed out that he already fixed this for editing cards, in bug 513471, and we might as well use that same solution for display.
Attachment #404392 - Attachment is obsolete: true
Attachment #404466 - Flags: review?(bugzilla)
Attachment #404392 - Flags: review?(bugzilla)
Attachment #404466 - Flags: review?(bugzilla) → review+
Comment on attachment 404466 [details] [diff] [review]
Fix v.2

Trivial console-noise-shusher.
Attachment #404466 - Flags: approval-thunderbird3+
http://hg.mozilla.org/comm-central/rev/1ea1a945d4a0
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Blocks: 762669
You need to log in before you can comment on or make changes to this bug.