515785 - Use new icons for each task in Win7 Jump list tasks

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[Jim Mathies [:jimm]]

The new win7 taskbar jump list supports custom tasks. Currently four tasks are supported in the working patch, three of which we hope to enable by default for the release:

open new window
open new tab
private browsing mode
profile manager

private browsing mode and profile manager may be hidden by default due to some limitations in launching them when there are running instances, but custom icons for each would still be nice. private browsing we deffinitely be enabled by default at some point.

These icons would most likely be embedded in firefox.exe. They should support the same color depths and resolutions as as the default firefox and firefox document icons.

Comment 1

[Jim Mathies [:jimm]]

Attachment: tasks list screenshots

Comment 2

[Norman Paschke]

Any updates on this?
Also Chrome, Opera and IE8+ also use favicons for recently/frequent visited sites, Firefox uses default html-icon.

Comment 3

[Norman Paschke]

nvm, just discovered Bug 549472

Comment 4

[Jim Mathies [:jimm]]

We don't have 'profiles' anymore. The current tasks are

open new window
open new tab
enter private browsing

Comment 5

[Jim Mathies [:jimm]]

(In reply to comment #3)
> nvm, just discovered Bug 549472

I had hoped to get that done for the release, but I'm not sure I will. (We have a lot of cleanup work to do.)

Comment 6

[Brian R. Bondy [:bbondy]]

Should there be another task defined for this for a graphic designer to make the custom images?  I can do the rest for this task once I know which images to use.

Comment 7

[Jim Mathies [:jimm]]

(In reply to comment #6)
> Should there be another task defined for this for a graphic designer to make
> the custom images?  I can do the rest for this task once I know which images
> to use.

Yes, I'd file a new bug (theme maybe?) and cc shorlander and faaborg.

Comment 8

[Brian R. Bondy [:bbondy]]

Posted here: Bug 672177 - New icons for each Win7 Jump list task

Comment 9

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: WIP of patch

This patch includes everything that we should need with the exception of the correct icons.

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Patch for bug

This patch includes the new icons. Thanks Stephen :)

Here is a screenshot of it: http://screencast.com/t/8EAPf2E7o7E

Comment 11

[Brian R. Bondy [:bbondy]]

Comment on attachment 619135 [details] [diff] [review]
Patch for bug

Review of attachment 619135 [details] [diff] [review]:
-----------------------------------------------------------------

Nice work, looks good.
As long as it passes try tests we're good to go.

Comment 12

[Jared Wein [:jaws] (please needinfo? me)]

Pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=5cf59016afe7

Comment 13

[Jared Wein [:jaws] (please needinfo? me)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d913b3d444e4

Comment 15

[Ryan VanderMeulen [:RyanVM]]

http://hg.mozilla.org/mozilla-central/rev/d913b3d444e4

Comment 16

[Rain [:rain1] (inactive)]

Aww, you guys don't do anything clever with extracting icons out of theme PNGs at build time. That's what Tb does (bug 659788).