520391 - Cmd-C does not work in selectable description

Status: VERIFIED DUPLICATE of bug 521003

(Thunderbird :: Mail Window Front End, defect)

Description

[Ben Bucksch (:BenB)]

Split-off from bug 489609 comment 16 and 34, 40, 41

Environment:
Intel Mac
Thunderbird

Reproduction:
1. Apply patch from bug 489609, which has a
   <description style="-moz-user-select: text"> ,
2. Select some text (in the subject)
3. Press Cmd-C to copy the selection
4. Try to paste it.

Actual result:
Nothing. The text was not selected.

Expected result:
Cmd-C copies selected text.

Narrowing down:
Mac only:
The same (Ctrl-C) works on Linux (the real clipboard works on Linux, not just PRIMARY = select and middleclick), and I think on Windows, so this is Mac-specific.

Thunderbird only:
A minimal testcase <http://www.bucksch.org/xfer/select.xul> works in Firefox on Mac, so there must be something Thunderbird-specific or at least content-specific involved.

David A wrote: random possibly useful info:
mail/base/content/utilityOverlay.xul has a <key id="key_copy"
key="&copyCmd.key;" modifiers="accel"/> which doesn't bind it to cmd_copy,
while the one at
http://mxr.mozilla.org/comm-central/source/mozilla/toolkit/content/editMenuOverlay.xul#38
does.

Comment 1

[Mark Banner (:standard8)]

If I enter:

Components.classes['@mozilla.org/appshell/window-mediator;1'].getService(Components.interfaces.nsIWindowMediator).getMostRecentWindow("mail:3pane").document.getElementById("tabmail").openTab("contentTab", {contentPage: "http://www.bucksch.org/xfer/select.xul"});

into the error console to get that test page open in a content tab (i.e. browser element showing content), then cmd-c works fine for me on latest trunk.

Comment 2

[Ben Bucksch (:BenB)]

Yeah, I wrote that select.xul works even on Mac.

Comment 3

[Mark Banner (:standard8)]

(In reply to comment #2)
> Yeah, I wrote that select.xul works even on Mac.

Either I'm misunderstanding you or you're misunderstanding me. My comment 1 was meant to show that select.xul works within Thunderbird on Mac.

Your comment 0 implies that because select.xul works in Firefox on Mac then the issue with <description style="-moz-user-select: text"> is Thunderbird-only.

I'm challenging that as select.xul works within Thunderbird in a browser element/content case then it isn't a Thunderbird-only issue and/or the testcase is wrong.

Comment 4

[Ben Bucksch (:BenB)]

Oh. With "within Thunderbird", I meant as part of the TB main window - with all the overlays, key bindings and the other things that Thunderbird does in the main window. Something in mainwin must interfere with the key binding. David A provided a suspicion,

but I can't test it, because I have no Mac.

Comment 5

[Ben Bucksch (:BenB)]

After gozer was nice enough to give me access to a Mac box via VNC, and I was able to use it via VNC for Moz dev (took me ~3 hours). I couldn't apply the patch v6 from bug 489609, because the latest nightly is outdated. So, I did essentially patch v2 and replaced the textbox of mail-headerfield around line 192 in mailWidgets.xml with
<description style="-moz-user-select: text; -moz-user-focus: normal;">foobar baz</description>
and found that Cmd-C *does* work.

So, could somebody please test bug 489609 patch v6 again and double-check that Cmd-C really does not work there?

Comment 6

[Ludovic Hirlimann [:Usul]]

(In reply to comment #5)
 
> So, could somebody please test bug 489609 patch v6 again and double-check that
> Cmd-C really does not work there?

Adding a few cc for that ...

Comment 7

[Mark Banner (:standard8)]

I've just tried this and it worked fine - see Bug 489609 comment 44.

Comment 8

[Ben Bucksch (:BenB)]

Thanks for texting it!
Closing INVALID, as the original description was based on a report from David A. Maybe he just didn't apply the patch correctly.

Comment 9

[Blake Winton (:bwinton) (:☕️)]

Reopening, because the steps in comment 0 still fail for me with patch 7 of bug 489609 applied.

I'm on OS X 10.6.1, just in case that's part of the problem.

Comment 11

[Vitaliy]

This also happens on Windows with Thunderbird 3 release: cannot select text in "subject" and use CTRL-C to copy.

However, if you right click there is "Copy" available which does work. In fact, this "Copy" can also be activated with "C" key (i.e., "right-click-C").

Not sure if a separate bug should be opened for Windows.

Comment 12

[Jamie Kitson]

Yep, me too, 3.0, Windows XP.

Comment 13

[Chris]

I'm having the same issue, 3.0, with XP Pro 2002 SP3. I can select the Subject line text just fine, but then, it doesnt copy using CTRL C. Here's something I bet is part of the problem. If I select a block of Subject line text, I can then go into the body of that email, and select/highlight text there, and the Subject line block I'd selected stays selected/highlighted! If this was working correctly, I'd expect to be seeing either/or. In other words, Once I select text in body of email, the Subject line selection should un-highlight. The selection action doesnt seem to be bound between subject line and body of email. Can't wait for this to be fixed. For those of us who live and breathe our keyboard shortcuts, it'll be a great help!

Comment 14

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Turning platform-agnostic since it might occur on other platforms besides Mac.

Comment 15

[David :Bienvenu]

hmm, WFM on Windows trunk builds. Marking non-blocking.

Comment 16

[Dan Mosedale (:dmosedale, :dmose)]

Adding qawanted and CCing Ludo in the hopes of finding steps to reproduce that actually work most of the time.  Moving back to blocking, because I see this from time to time, and it's really frustrating.

Comment 17

[Noel Grandin]

There is a possibly related issue which is 100% reproducible for me:
(1) select a piece of the subject line from the message pane
(2) hit ctrl-C
(3) notice that the clipboard does not contain the relevant information

Note that this is under Windows XP, Thunderbird 3.0.1

Note also that {mouse-right-click, select-copy-from-context-menu} does work

Comment 18

[Ludovic Hirlimann [:Usul]]

(In reply to comment #17)
> There is a possibly related issue which is 100% reproducible for me:

In -safe-mode too ?

Comment 19

[Noel Grandin]

(In reply to comment #18)
> In -safe-mode too ?

No, the bug disappears in safe mode.
Doing a binary search reveals that my bug is somehow related to the lightning addon.

Comment 20

[Dan Mosedale (:dmosedale, :dmose)]

We don't currently have strong reason to believe this is a bug in core, which means that we wouldn't hold 3.1 for it as it's currently understood.  Feel free to renominate if that changes.  Adding Philipp to see if he has any insight into what's going on here...

Comment 21

[Philipp Kewisch [:Fallen] [:📆][:🧩]]

Looks like bug 521003, go ahead and mark a duplicate if the Thunderbird side of things are taken care of.

Comment 22

[Dan Mosedale (:dmosedale, :dmose)]

My understanding of this bug is that there is no Thunderbird side, so marking as a DUP.  Someone please correct me if that's wrong.

Comment 23

[Ben Bucksch (:BenB)]

Ah, so all people who saw this bug had Calendar installed? So, calendar caused the bug?
No wonder I was hunting ghosts for a day (back then)...

Comment 24

[Ben Bucksch (:BenB)]

No response from people here, but VERIFIED as Lighting bug in bug 521003 comment 22.