521113 - Don't allow kinetic scrolling to move sidebars

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Panning/Zooming, defect)

Description

[Benjamin Stover (:stechz)]

When zoomed in and panning content horizontally, stop any kinetic scrolling once the edge of content is reached to prevent sidebars from being shown.

Comment 1

[Matt Brubeck (:mbrubeck)]

See also: bug 607657

Comment 2

[Benjamin Stover (:stechz)]

Attachment: Don't allow kinetic scrolling to move sidebars

I tried to simplify the logic and I added a couple of tests:
* Test that URL bar cannot be panned in when content is being captured
* Test that kinetic panning cannot bring out sidebars

I've also added a simplified version of runNextTest to head.js. There could be
some tests that need something a little more advanced (it looks like
browser_sidebars.js does some special stuff), but that should be easy to
rewrite as we go along.

What do you think?

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

I want to make sure we have UX approval for this before any changes land

Comment 4

[Benjamin Stover (:stechz)]

Comment on attachment 530227 [details] [diff] [review]
Don't allow kinetic scrolling to move sidebars

Madhava, are you okay with kinetic panning not being applied to sidebars?

Comment 5

[Matt Brubeck (:mbrubeck)]

Comment on attachment 530227 [details] [diff] [review]
Don't allow kinetic scrolling to move sidebars

Beautiful!  Code looks good, and this also feels good to me from a user perspective.

Comment 7

[Benjamin Stover (:stechz)]

Pushed! http://hg.mozilla.org/mozilla-central/rev/45e307f12f90

Comment 8

[Anna (Waverley)]

VERIFIED FIXED on:

Build Id: Mozilla/5.0 (Maemo; Linux armv7l; rv:6.0a1) Gecko/20110510
Firefox/6.0a1 Fennec/6.0a1

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:6.0a1) Gecko/20110513 Firefox/6.0a1 Fennec/6.0a1 

Build Id: Mozilla /5.0 (Android;Linux armv7l;rv:5.0a1) Gecko/20110512 Firefox/5.0a2 Fennec/5.0a2 

Devices: Nokia N900 (Maemo GTK), HTC Desire Z (Android 2.2)