Closed
Bug 521988
Opened 16 years ago
Closed 15 years ago
[eu] Choose search plug-ins for Fennec in Basque
Categories
(Mozilla Localizations :: eu / Basque, defect)
Mozilla Localizations
eu / Basque
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: stas, Unassigned)
References
Details
(Keywords: productization, Whiteboard: [bootstrapped][twitter])
Attachments
(2 files)
8.71 KB,
patch
|
Details | Diff | Splinter Review | |
1.74 KB,
patch
|
sethb
:
review+
|
Details | Diff | Splinter Review |
You've indicated an interest in participating in the localization of mobile Firefox (aka Fennec). We want to ship Fennec with a good list of search engines for Basque. As the technical details of implementation are being worked on, we'd like to start the discussion about the choice of search engines. This bug is about agreeing on a set of search engines, and will not tackle the implementation (at least not yet).
First, the localization team and Staś will look at the market for the locale and come up with a good set of search providers. The guidelines for making recommendations are on https://wiki.mozilla.org/L10n:Mobile/Productization. You're welcome to suggest engines already shipped in desktop Firefox for Basque, if they fit well in the categories outlined on the wiki.
For en-US, we currently use the following set, which may serve as an inspiration:
Google, Wikipedia, Amazon, Yahoo, Twitter.
Note that according to the guidelines, for some categories it may be better to leave them empty than to ship with en engine that's irrelevant or unavailable in your region.
After we decided on a particular search engine, we will need to test it in Fennec. You can test on a mobile device and on the desktop (download the builds from <http://ftp.mozilla.org/pub/mozilla.org/mobile/nightly/>). Staś will help with testing on a device, too. If the service works fine, Staś will contact the owner and ask for permission, and for specifics like proper search flags. $name, we'll likely need your help to at least get the contact information if we don't have them already.
We don't know the implementation details yet, so for now, please don't create patches nor land anything. We will keep you posted as we figure out the how's and when's.
Thanks.
![]() |
||
Comment 1•16 years ago
|
||
Hi Guys: Just a friendly reminder, as we move closer to the general availability date for Fennec in mid-December, has your team had any chance to consider search providers? Thanks!
Reporter | ||
Comment 2•16 years ago
|
||
Here's a patch resetting the mobile/searchplugins/ directory to a minimal set of search engines that we would like to ship your locale with. Please read this comment carefully before you land this patch.
*Important*: There has been a change to how we use the <Description/> elements present in the plug-ins (see bug 528655 and bug 529869). We want to emphasize that the search is integrated with the browser to better reflect what a search plugin is and what it does. You will need to edit the Wikipedia plug-in before you commit this patch. Please read <https://wiki.mozilla.org/L10n:Integrated_Search_Instructions> for detailed instructions.
For Google and Twitter, we don't have to copy the XML files to your mobile/searchplugins/ directory. Plugins identical to en-US are pulled from source automatically. It's enough to put the engine's name in list.txt for this to work (which I did). I also updated the Wikipedia plug-in to use a bigger icon, see bug 517997 for details.
Please edit the Wikipedia plug-in and commit this patch before you opt-in in the mozilla.dev.l10n newsgroup. Opt-ins without this patch will not be taken. This does not mean that we don't want to include other search engines. On the contrary, the work and the discussion will continue in this bug until we choose a good set of search engines for your locale. Then, you will be able to opt in again, so that in the final release we include more search engines than the mineral set from this patch.
This patch is simply meant to reset your mobile/searchplugins directory so that we keep the repository clean and happy.
Thanks for understanding!
Comment 3•16 years ago
|
||
Just applied the bootstrapping patch.
For reference:
http://hg.mozilla.org/releases/l10n-mozilla-1.9.2/eu/rev/c305e94695f4
We may want to make some additions, but we haven't discussed this thoroughly in our group yet.
Reporter | ||
Comment 4•16 years ago
|
||
Thanks, let's continue discussing about other search engines in this bug.
Reporter | ||
Updated•16 years ago
|
Whiteboard: [bootstrapped][twitter]
Comment 5•15 years ago
|
||
Before signing-off any changesets for the Fennec 4.0 milestone, I guess this bug needs to be fixed.
Currently on mozilla-central we have a rough copy of en-US search plugins. I think it's enough to have localized plugins for Google and Wikipedia.
Any objections/comments?
![]() |
||
Comment 6•15 years ago
|
||
Google's technology is good and allows our localizers to not have to provided a specialized XML plugin for their services. They use their technology to detect language and IP settings to provide the best local search results, so no changes needed there.
For Wikipedia, you will need to provide the Basque plugin. This is a good reference point:
http://hg.mozilla.org/l10n-central/es-ES/file/default/browser/searchplugins/wikipedia-es.xml
Comment 7•15 years ago
|
||
Added Wikipedia-eu within the search plugins.
Attachment #515020 -
Flags: review?(sethb)
![]() |
||
Comment 8•15 years ago
|
||
Comment on attachment 515020 [details] [diff] [review]
Add Wikipedia-eu to searchplugins
You can land this. Looks good to me. Please add a comment to your checkin that says the following, "Bug 521988: Adding wikipedia-eu, r=sethb"
Once you land this, you will need to test the nightly and then sign off. After a successful round of testing, please sign off and then close this bug.
Attachment #515020 -
Flags: review?(sethb) → review+
Comment 9•15 years ago
|
||
All works fine. Already signed off in the dashboard.
Status: NEW → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•